From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 37628C4332F for ; Wed, 9 Nov 2022 11:37:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AB2BC8E0001; Wed, 9 Nov 2022 06:37:53 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A63286B0073; Wed, 9 Nov 2022 06:37:53 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8B57E8E0001; Wed, 9 Nov 2022 06:37:53 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 792256B0072 for ; Wed, 9 Nov 2022 06:37:53 -0500 (EST) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 401CEA0EBF for ; Wed, 9 Nov 2022 11:37:53 +0000 (UTC) X-FDA: 80113704426.28.379A76F Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by imf20.hostedemail.com (Postfix) with ESMTP id 4653E1C0017 for ; Wed, 9 Nov 2022 11:37:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1667993867; x=1699529867; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=B7eAMcEzPM2KkQYXCxVi6xhZQMt/OsUrrY3j9R/ezjY=; b=CTNij+ZYmBKkK99WyQ/MxTRHQbTCoPtW0UYilEWXQ9ZVDFzyHQ/5vcxt 8ebuBAWL6f29z4iJ4Zu4tJZ+eFeNT/5rmyXPEzrzfcNOxw2CmNHNHdZYd sUsYESFZeF11uLo/02lp84pu3t91xpiO/QIwgWOlNl8EKWXJfZSXFg8t4 mi6Y6Ozw9724BT75T9opkxdbwjvx2RkCQvp35svM/ZMI9SsRjCdG4KNZ6 oeVuW9aNFWidyhC9z9I/nYHdhhxGZr7+5RTMbKb8aDnrlgmPUGqVGl5PJ eDiQl38/cUPx7cGu/Fb+A3L+COMT/fNpBfXA9t5liOp4sXobkvy131iS7 A==; X-IronPort-AV: E=McAfee;i="6500,9779,10525"; a="291343404" X-IronPort-AV: E=Sophos;i="5.96,150,1665471600"; d="scan'208";a="291343404" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Nov 2022 03:36:48 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10525"; a="965961445" X-IronPort-AV: E=Sophos;i="5.96,150,1665471600"; d="scan'208";a="965961445" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmsmga005.fm.intel.com with ESMTP; 09 Nov 2022 03:36:48 -0800 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Wed, 9 Nov 2022 03:36:48 -0800 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Wed, 9 Nov 2022 03:36:48 -0800 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Wed, 9 Nov 2022 03:36:48 -0800 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.106) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Wed, 9 Nov 2022 03:36:47 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ADEhziHhHdJ3oB0KtcoKB61g/4bW8fOJo0+LrMEsnYb/2I3hJaNr0qX/bOTJBllqshHFYlpxcTn9jSmOQFiQkMtC6M8Ct8MZ4NqQQR02H5fQQhtZKgEt2ChYp+9bmOH4okwO+VHaU2FubEZR1gY3nFNgrFAd09DwqhgH4Ln1DODNEYref/hyMiYTLs4Ifubenxqod5KiDEffYTlO2qj5o3zuJylVKZtVtpThj0RR0aB5jSPzIoX6WNFV9S4HpF5oYWvzLGOJTWZzcrFmxmbK1OUE5k3HSPB/BtLePw9ECiFBvK9zYl+9o28HZKhfomw+8ZedDB5JLnzpfwEY+trlpg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rM7yQCuIM4wNgStuVZFsEbPjM/Ck18T25qCRGrc7V4s=; b=aIx1jTwqgkKNSR6sMaeMRAnwfwHYgSNrebnUjp/V9jA5petjGr2MLgZAT2sS1hBpqvT+pHKiFqOQQMqD28TJfJSG/Y6SjoFBEsr5XRu05CPcwpzRsdpPmsq+TduTGJNxjlqOVuM3h0IQqTvn5uU892/8thMSeGExO9TmBQpJ9GWzT+JZRBXLO2UlX0NgaLv14efnEsy/6Bq27hf4649BrvPe7hpYlGEZIcWYXO2LPygdne/HH5OG5VtX6y9wDPBtzRuuXraOl//lesaI5nkrE9gE3XZw4oshGjLxm0bvLGQXXqVv8zYdXyj14+lzeF36AC3rzKmEPfRBo6+enlq+Zw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from BYAPR11MB3495.namprd11.prod.outlook.com (2603:10b6:a03:8a::14) by CH3PR11MB7204.namprd11.prod.outlook.com (2603:10b6:610:146::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.12; Wed, 9 Nov 2022 11:36:45 +0000 Received: from BYAPR11MB3495.namprd11.prod.outlook.com ([fe80::acd8:2a14:5673:43e]) by BYAPR11MB3495.namprd11.prod.outlook.com ([fe80::acd8:2a14:5673:43e%4]) with mapi id 15.20.5791.027; Wed, 9 Nov 2022 11:36:45 +0000 From: "Wang, Haiyue" To: Baolin Wang , "akpm@linux-foundation.org" CC: "Huang, Ying" , "mike.kravetz@oracle.com" , "songmuchun@bytedance.com" , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" Subject: RE: [PATCH] Revert "mm: migration: fix the FOLL_GET failure on following huge page" Thread-Topic: [PATCH] Revert "mm: migration: fix the FOLL_GET failure on following huge page" Thread-Index: AQHY9BcDvagcT6C7uECM0PzSVGMzxa42dgOQ Date: Wed, 9 Nov 2022 11:36:45 +0000 Message-ID: References: <496786039852aba90ffa68f10d0df3f4236a990b.1667983080.git.baolin.wang@linux.alibaba.com> In-Reply-To: <496786039852aba90ffa68f10d0df3f4236a990b.1667983080.git.baolin.wang@linux.alibaba.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.500.17 x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BYAPR11MB3495:EE_|CH3PR11MB7204:EE_ x-ms-office365-filtering-correlation-id: 38482028-8e69-4499-e291-08dac246ae2e x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: LWcUsaMauQTzVkzFK7HCgdh4nlW2GqCQfhKMoEBzgE+S7KGgC4XIsSjzLICg2hm9Dia5SdlwbjY+95bKpa1kshGTqAWt0ifUhK4TK4H+WlVeOGew8EDLN+a9SnJW3anEUoWhxd2TYlCpdq9sFS+guMAzmq9+bnHfey4sbEP7Luc09L47vacArDjt7rWofH47LxXra4LazAPrnOXbtcFpnFkjmLihThCue0kJoXnHuDZ2ncxP+U2o2cf3bOMuJAWYDe6jSsxCi6OGhQ/wBes+jtZZ2Ss67Ot1qCDN45eALXCzAwNF6D7W1GslinlEOjSadGKubPK/KGvhxq7C8vYI5YX9GF8VFe94Z8i7dbUjFrcFz49oFRVeoLnHEyZx3sZa/VK9Qefkb+v3vDpx8hkZ6rPGfv9pMDhvW6QsYUPxk9vZjYZbCbEB4iTCyE3qUXj8GTrbDL2ZEIW/OL3r+ekwfAoNac6qCV2WdGr4DXV0Tmj7UyhIPyOrhG8hnHS5OTTWR8/vwl/6G9sXy+K98hTrmShme9Z7ik7BGVqHblSTyq/TTfdVtUUKrV4EtHKfvGPiPCb0XWKtO48R1nf3dyLpYihpi2cLevfSjjh5osAoNdTPcIz0v2Sj+S9yQWsjNBBy+OYI4ltyCs88jr4bGRZeIVQVEzDSXCYI3KM/bIB+4492FoGsB1gkPw6DFPdxT1ow3V2tEgx6gSDI8Ab0+T1HKmMcbVysaBTxPjMudo5jQ2THJgTaDbc5a24EWi6tKqaVrasmHn+Cbr3WAOXxmHFp3fPxA176GYP4mxDSxg+t9UQ= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR11MB3495.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(376002)(39860400002)(136003)(346002)(396003)(366004)(451199015)(478600001)(38100700002)(4744005)(2906002)(82960400001)(38070700005)(71200400001)(83380400001)(186003)(122000001)(26005)(33656002)(9686003)(53546011)(6506007)(7696005)(66446008)(64756008)(316002)(66476007)(66556008)(4326008)(8676002)(66946007)(76116006)(86362001)(55016003)(8936002)(52536014)(5660300002)(54906003)(110136005)(41300700001)(14583001);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?07j7+RIbRD/h+z+uQDEWv+EgnoAjeWBWH87hcqUk6vaNBu7KVdQ+Bul4D3F7?= =?us-ascii?Q?Tgu9g8J5tbkAZ/1wsilK+wpD0gj3ObbgRTTnU5512c3vgezJJTvkCuOTES1p?= =?us-ascii?Q?BZzRbJy7l0JMVYufZ1y/VYehhBRA+VkTc+hcvfqnv4D6zUJxlMz4+nmZAzD8?= =?us-ascii?Q?vbR2TB00MOMvJYxKa8G4u0e5JWBVLepN8QiS1khe3kasS5RlDf+eVvc0CoE4?= =?us-ascii?Q?zTGaLF+/6AZL6ufoNYLU/bLvcVkQNn7D86XOcRwAgo6R2TgbLNp0a0kJXQAg?= =?us-ascii?Q?JWhryeYKKk+YI0e3mpKkqSZX/NkPkdfUz2cplS87fGktyJBtghp3jME5GJKS?= =?us-ascii?Q?8QpWs7tZh16Tz3iVD2EGMekaYFz2b3l30qBhLxT/aSxgTR9G63pmYx1HOy84?= =?us-ascii?Q?LCq7m9kgltRKouWQCzAA2SkMr3D0JAYaJXsHdDJFgmCL9jdcr9wvbnszwtwn?= =?us-ascii?Q?c36HPIQcUdtDvmEOKbOOy6u913LWDZJA5ZrDQaDh1NPEsdFkSyyGEsJVhHxW?= =?us-ascii?Q?q9yXQqGn+kuZM771RJur6n7/HuT23rUSHCW1m0Tq4GJLs9PXxhhcUDdlkYSS?= =?us-ascii?Q?A+hEXBYHpxRO03+oRNVqj5OjUMbGCyL5mtp+rd8HBcY5ao6sCoppYmVk64Hr?= =?us-ascii?Q?hhemqknt9ZusYqrelp1d/JJAOvVda554Woy+E2bSZIREvR4h6j4hE6f9LyzD?= =?us-ascii?Q?EvwioNlOS4kdGweuJT2dsJi3iix5gBiGqCOGAqky7nwlY/G+g7VLu/tgP6cj?= =?us-ascii?Q?Bci9Sem58ECdjC+6JeF0ph9D5+g09XZmQ9amXgIUEXVDHtV7cC9eFCT6lato?= =?us-ascii?Q?gCt7uqFD9DE3IZBEDXkRLmEcQaJzvz4h1D6NnTL+PeIvXYRba6mUnDiJdfIr?= =?us-ascii?Q?g3I9SehXGfGoDVk++eDPFRjUv0N5ov51+5O1hWJYGl6Bf5UWQY6+fRAC7QcG?= =?us-ascii?Q?PNPZ6IX1YsNsSjYuPfLIEZzoE6otlvh6V006+kXxenuQajWC75+4rAhaOCtZ?= =?us-ascii?Q?vkWRw1UpcwnXTqXGwhwh0KqkhMK99k6ZxeJiHt0F7qI10UiKW/0hDtE386Gl?= =?us-ascii?Q?NFdfMx7i6i77M9zxrpE58gD/IFmYRiDQqxv9eq30AKiugUV+MYbyphXRvrft?= =?us-ascii?Q?c515UM9kOgBpojhrDAon2wtkxKnTZDhmRK9ZrtxfrS2/b6Vk3LiHHvl0ATq5?= =?us-ascii?Q?aSmm6vG4ncfFEaZMc+n9sCwd5ROzlNuqhRhv4rP4ZFkmtDsAucjhdA6uuZ+o?= =?us-ascii?Q?4G8vN4KkB1LHnNIULvgUv8vUOMDIhTI/tJWv9+sIUyR1QlucBL8VdGSdaB2m?= =?us-ascii?Q?H76HSsQmazwYqAximlD1Ta3324tmJl80eyXHDmfEcDFktBauoTxGTB5vc3H4?= =?us-ascii?Q?cOh7fXsHoy261u6sH1zKimli0D2DSmVhGa18gQfC3HTkq0eU1oSw4hgSJPU5?= =?us-ascii?Q?XEiy82g4a+mB1xIldxKY0I4AgLnFTreUdOEPmdAPhPWi+FVn4jG8XmXA6/68?= =?us-ascii?Q?+bXXzfQqvjYNOmvnB+M2TZjSsszkMjC6trXYgJ0s4Kv0/YytHGrfvXp2w4K2?= =?us-ascii?Q?S9vsjywaxvRQfksUxKSqiRBZbKoCC6TEASLgVQzx?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3495.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 38482028-8e69-4499-e291-08dac246ae2e X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Nov 2022 11:36:45.1685 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: PUcVdtGRoEtyCcgjN+V8DO5ajmebQ7UEgr1EqikLo0pK82JR5ELMggpljKKp/6OXqOoFnCPgFPGN5atIWTc/dA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR11MB7204 X-OriginatorOrg: intel.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1667993870; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=rM7yQCuIM4wNgStuVZFsEbPjM/Ck18T25qCRGrc7V4s=; b=Yv6bUmW3KPvvvA/YcQ+wvvFb9e5UQltKpM/bvq/cd4WKh2HCSQznB2zjnFXf9LYyHi1mxs Ix02Q0ehNapmC8yj2rMXcHWzNexFyvVdFgdUsTwag09buX0snz1bTSVqp6HszrN4KwXHne 3B+xtKrjPvmHsolSZoa26Z2QyxlwvuA= ARC-Authentication-Results: i=2; imf20.hostedemail.com; dkim=none ("invalid DKIM record") header.d=intel.com header.s=Intel header.b=CTNij+ZY; arc=pass ("microsoft.com:s=arcselector9901:i=1"); spf=pass (imf20.hostedemail.com: domain of haiyue.wang@intel.com designates 192.55.52.151 as permitted sender) smtp.mailfrom=haiyue.wang@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1667993870; a=rsa-sha256; cv=pass; b=z3iNyzLm9uliLoTfjZkxIqyJSlIJjQIb2EIwyJRHb+ESVkOK8PKLzzV8MP0g7w+Xvan896 t3JJcxCqtPbB6WtMwDoL05+Sn+9n15APRhJNLS/VifBbfFO6/FPngZjlatfww95Qs4N8fF 1AmUiaGnguDfxAEPfqWVMpuUOiES4Y4= X-Rspamd-Queue-Id: 4653E1C0017 Authentication-Results: imf20.hostedemail.com; dkim=none ("invalid DKIM record") header.d=intel.com header.s=Intel header.b=CTNij+ZY; arc=pass ("microsoft.com:s=arcselector9901:i=1"); spf=pass (imf20.hostedemail.com: domain of haiyue.wang@intel.com designates 192.55.52.151 as permitted sender) smtp.mailfrom=haiyue.wang@intel.com; dmarc=pass (policy=none) header.from=intel.com X-Rspamd-Server: rspam10 X-Rspam-User: X-Stat-Signature: xcrwwt44rjmkoaxpzhm7ui4nmqdsarbq X-HE-Tag: 1667993867-523708 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > -----Original Message----- > From: Baolin Wang > Sent: Wednesday, November 9, 2022 16:40 > To: akpm@linux-foundation.org > Cc: Wang, Haiyue ; Huang, Ying ; mike.kravetz@oracle.com; > songmuchun@bytedance.com; baolin.wang@linux.alibaba.com; linux-mm@kvack.o= rg; linux- > kernel@vger.kernel.org > Subject: [PATCH] Revert "mm: migration: fix the FOLL_GET failure on follo= wing huge page" >=20 > Revert commit 831568214883 ("mm: migration: fix the FOLL_GET failure on > following huge page"), since after commit 1a6baaa0db73 ("s390/hugetlb: > switch to generic version of follow_huge_pud()") and commit 57a196a58421 > ("hugetlb: simplify hugetlb handling in follow_page_mask") were merged, > now all the following huge page routines can support FOLL_GET operation. >=20 > Signed-off-by: Baolin Wang > --- Cool, thanks, my ugly code is gone. ;-) Acked-by: Haiyue Wang > mm/migrate.c | 10 ++-------- > 1 file changed, 2 insertions(+), 8 deletions(-) >=20 > -- > 1.8.3.1