From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,HTML_MESSAGE,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D884CC04AA7 for ; Mon, 13 May 2019 20:21:50 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 77FA42085A for ; Mon, 13 May 2019 20:21:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=amdcloud.onmicrosoft.com header.i=@amdcloud.onmicrosoft.com header.b="qBCHh27Z" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 77FA42085A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=amd.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 0E0C76B0003; Mon, 13 May 2019 16:21:50 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0920F6B0006; Mon, 13 May 2019 16:21:50 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E74E76B0007; Mon, 13 May 2019 16:21:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from mail-oi1-f198.google.com (mail-oi1-f198.google.com [209.85.167.198]) by kanga.kvack.org (Postfix) with ESMTP id B85606B0003 for ; Mon, 13 May 2019 16:21:49 -0400 (EDT) Received: by mail-oi1-f198.google.com with SMTP id h17so374104oih.2 for ; Mon, 13 May 2019 13:21:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:dkim-signature:from:to:cc:subject:thread-topic :thread-index:date:message-id:references:in-reply-to:accept-language :content-language:mime-version; bh=wdxiQKSrrmaWxwrq7RGlXrDnj2CdLeEzvCViF9BTZD0=; b=HKO9lwftgAS+xECGQOwx4OWxDtUhZCGCXCTyscNl4sAOMnghMz/vt0KqB8gObtAC0p O3GUi4CZwyOaR/gP/Wo1ukAo4j5fRUeNyKdl2rAI3PVwY5m3ksaJ+8OhglOenyoafhvK n0qE2bwX+0AZcJy8tOCSnbxmUYk26tYlWNC408b0EgLBcDKThNyw1CGUIDWaRWTvk6bX 950yo43XaaTvre6MwO2QHYq/Gun4NrjIXj/DX1d7Rxt1ZqGCZ4BRlIldsA+Niv9mAfz7 kNyg2uALIGcykws+1t+nsqxUy9ChNrjnajV8g+7f9Q7WeJn5RFxPq0WVmoDvWgH4DWGt BEdA== X-Gm-Message-State: APjAAAUwQiczzPg6/GE1uQHMf78xpXTsNOu9Zfuwa0a0XxWe3TN1WRIE 6EuEMA+RWVqAhaVVeGgFudQx2Mrh6zQk+TzL8iUMQ2zlLjhjQ16y3iAelvdXuqT66VfRSEl2hdW L2MTMQ665KItPupRY7ZKzN4sQepci3XJB1VGF0bxbMRZkbfPQdzfDUiBWIdjazhE= X-Received: by 2002:a05:6830:1584:: with SMTP id i4mr4741787otr.109.1557778909377; Mon, 13 May 2019 13:21:49 -0700 (PDT) X-Google-Smtp-Source: APXvYqwuz6qZrRxxzFx9U0KBHVScarzYLYZmJ2WhKtPOF46JqkSbdE4CGouGurhhbZrmBq1xn4nN X-Received: by 2002:a05:6830:1584:: with SMTP id i4mr4741747otr.109.1557778908428; Mon, 13 May 2019 13:21:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1557778908; cv=none; d=google.com; s=arc-20160816; b=tshyWRYOGT2zzPAt8a/T3/yWt3ofKK2t8ORFs1nMUVsUrBgW8lE5p2n1/UbHjlQuM5 x51E/lGK0FAjeD6dbXoMmRgRlet9mBomV5kinF8DE0VTDUhR1gZ31mywXhv9hy5Yqw39 EZzxojyTJqjxe+YpGWlm54Qr5wY7BCYwIGqU9FCZzC8mhT8rx1ssMzM1saFx3uZQ3mJY xGgiWE8h+wRIS4+DiGFKk/6eiOOINfHtMj42S4r41Ou7qCIQ6j+SHYYaUsMuM/31iePI hLLcoIbCzY7sx1Bjb/zjRJLKsg0eU58Pc5iCMjcCEMhQdiEthrvwGEXuB6RQz/7meMAm Bu0Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:content-language:accept-language:in-reply-to :references:message-id:date:thread-index:thread-topic:subject:cc:to :from:dkim-signature; bh=wdxiQKSrrmaWxwrq7RGlXrDnj2CdLeEzvCViF9BTZD0=; b=wsxG2+hkA9Hkv19enRZw+LzSB9+4neh5aIWV3Ss/vuWRtL5tQSPDTgoD1RItzGdc2h NxAxMUyBwwwTvcUSIw7xcSM6CBO49ukhou6e7/B8LMSUcNLiC6wvvCIkoiUTiBGfFdI6 VdZ8ilMqcTHvaRVeGQARWyIUucpbhqLaBDMSokV+urS4HLIKHmb3FRb2C1o5xp5r5gZd G7efuXdxENk4d9lHsaTP+fCv+hfG4mTOEmsRVZXKNU2MFJOpFwz/QFSpUhuKYOTNotVx OcuEwgkWCVPYRMrOHgStcxP0xFZeVscgh0iLTKnTh8EkM4o/zh44jmtFncrWeCs1Ugwz TY5A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@amdcloud.onmicrosoft.com header.s=selector1-amd-com header.b=qBCHh27Z; spf=neutral (google.com: 40.107.71.55 is neither permitted nor denied by best guess record for domain of alexander.deucher@amd.com) smtp.mailfrom=Alexander.Deucher@amd.com Received: from NAM05-BY2-obe.outbound.protection.outlook.com (mail-eopbgr710055.outbound.protection.outlook.com. [40.107.71.55]) by mx.google.com with ESMTPS id l25si6354065otk.209.2019.05.13.13.21.48 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 13 May 2019 13:21:48 -0700 (PDT) Received-SPF: neutral (google.com: 40.107.71.55 is neither permitted nor denied by best guess record for domain of alexander.deucher@amd.com) client-ip=40.107.71.55; Authentication-Results: mx.google.com; dkim=pass header.i=@amdcloud.onmicrosoft.com header.s=selector1-amd-com header.b=qBCHh27Z; spf=neutral (google.com: 40.107.71.55 is neither permitted nor denied by best guess record for domain of alexander.deucher@amd.com) smtp.mailfrom=Alexander.Deucher@amd.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amdcloud.onmicrosoft.com; s=selector1-amd-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wdxiQKSrrmaWxwrq7RGlXrDnj2CdLeEzvCViF9BTZD0=; b=qBCHh27Z/pAGZFoMs2iFozR4Zii++7JOq4q8Qn7wagGgIzOFWMWNp9IV5q0WDKdu6ExvFyW+XWJOVDXVNvwLbzqibzAwR2WzO+UlFvnIg9MZOSyYHXqWx1Nht7qdrqt8wkexaYLmbIKUWAIHpIY+ejNdDWdcQamsMA5Mlbjmg9k= Received: from BN6PR12MB1809.namprd12.prod.outlook.com (10.175.101.17) by BN6PR12MB1346.namprd12.prod.outlook.com (10.168.228.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1878.21; Mon, 13 May 2019 20:21:45 +0000 Received: from BN6PR12MB1809.namprd12.prod.outlook.com ([fe80::bc5b:de68:25b7:d853]) by BN6PR12MB1809.namprd12.prod.outlook.com ([fe80::bc5b:de68:25b7:d853%12]) with mapi id 15.20.1878.024; Mon, 13 May 2019 20:21:45 +0000 From: "Deucher, Alexander" To: "Kuehling, Felix" , Jerome Glisse CC: "linux-mm@kvack.org" , "airlied@gmail.com" , "amd-gfx@lists.freedesktop.org" , "dri-devel@lists.freedesktop.org" , "alex.deucher@amd.com" Subject: Re: [PATCH 2/2] mm/hmm: Only set FAULT_FLAG_ALLOW_RETRY for non-blocking Thread-Topic: [PATCH 2/2] mm/hmm: Only set FAULT_FLAG_ALLOW_RETRY for non-blocking Thread-Index: AQHVB2oNJpV4YZS9mkmbjza557LlUqZkyv6AgASskQCAAAwE5w== Date: Mon, 13 May 2019 20:21:45 +0000 Message-ID: References: <20190510195258.9930-1-Felix.Kuehling@amd.com> <20190510195258.9930-3-Felix.Kuehling@amd.com> <20190510201403.GG4507@redhat.com>,<65328381-aa0d-353d-68dc-81060e7cebdf@amd.com> In-Reply-To: <65328381-aa0d-353d-68dc-81060e7cebdf@amd.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Alexander.Deucher@amd.com; x-originating-ip: [71.219.84.143] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 60085c00-4007-4e74-8187-08d6d7e09eb9 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600141)(711020)(4605104)(4618075)(2017052603328)(7193020);SRVR:BN6PR12MB1346; x-ms-traffictypediagnostic: BN6PR12MB1346: x-ms-exchange-purlcount: 2 x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:2958; x-forefront-prvs: 0036736630 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(376002)(396003)(366004)(136003)(39860400002)(346002)(189003)(199004)(99286004)(66946007)(66476007)(6306002)(73956011)(76116006)(446003)(9686003)(236005)(8936002)(5660300002)(55016002)(7736002)(105004)(66446008)(64756008)(3846002)(66556008)(54896002)(316002)(2906002)(476003)(26005)(66574012)(53546011)(186003)(6506007)(7696005)(11346002)(76176011)(6436002)(86362001)(102836004)(71200400001)(4326008)(66066001)(25786009)(6116002)(54906003)(486006)(68736007)(8676002)(81166006)(52536014)(71190400001)(81156014)(478600001)(110136005)(74316002)(72206003)(14444005)(229853002)(53936002)(33656002)(19627405001)(256004)(966005)(6246003)(14454004)(606006);DIR:OUT;SFP:1101;SCL:1;SRVR:BN6PR12MB1346;H:BN6PR12MB1809.namprd12.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1; received-spf: None (protection.outlook.com: amd.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: 1nO0CFP/4aWYFCp0IazUJZ+VQPgVxteUY5s3FSVIHG4Sw+3xswZvIpJY1C1genH3jpJf+H5/bGtYFVTTSvZijphirJDF8blRlbmkXbwajt5xdVfauRUtGnupjSofSbmyJ6Yb5mEomVbXpYAQAD41eZT/Il2ML5rGblm6PFcZA2GLyskZEdt4o1kq77dLdgXtgOFQnPfW7+xptTFIJqr24LzgB4hXM2SLW6BJePJjZaB/SBBnOhgqhScFOUo/AfUMmGdokTUV0q7Pxu1dMk+Fc0ADIxr2Zy6xPJMf8Iy4+SeEWpiHzglpWuRz0KpqXUQT9OX095KIgI28ZfrLr4h8lhyExnS4Q12k41lquTuu8bm2PV+Yb3ZP2DYkJDtDgUCyoFlIg/3IH/JflXDV4g0M0GYgXEU1Mg7VL7bVkhUOpOk= Content-Type: multipart/alternative; boundary="_000_BN6PR12MB1809F26E6AF74BE9F96DB22DF70F0BN6PR12MB1809namp_" MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 60085c00-4007-4e74-8187-08d6d7e09eb9 X-MS-Exchange-CrossTenant-originalarrivaltime: 13 May 2019 20:21:45.3295 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR12MB1346 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: --_000_BN6PR12MB1809F26E6AF74BE9F96DB22DF70F0BN6PR12MB1809namp_ Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable I reverted all the amdgpu HMM patches for 5.2 because they also depended on= this patch: https://cgit.freedesktop.org/~agd5f/linux/commit/?h=3Ddrm-next-5.2-wip&id= =3Dce05ef71564f7cbe270cd4337c36ee720ea534db which did not have a clear line of sight for 5.2 either. Alex ________________________________ From: amd-gfx on behalf of Kuehling= , Felix Sent: Monday, May 13, 2019 3:36 PM To: Jerome Glisse Cc: linux-mm@kvack.org; airlied@gmail.com; amd-gfx@lists.freedesktop.org; d= ri-devel@lists.freedesktop.org; alex.deucher@amd.com Subject: Re: [PATCH 2/2] mm/hmm: Only set FAULT_FLAG_ALLOW_RETRY for non-bl= ocking [CAUTION: External Email] Hi Jerome, Do you want me to push the patches to your branch? Or are you going to apply them yourself? Is your hmm-5.2-v3 branch going to make it into Linux 5.2? If so, do you know when? I'd like to coordinate with Dave Airlie so that we can also get that update into a drm-next branch soon. I see that Linus merged Dave's pull request for Linux 5.2, which includes the first changes in amdgpu using HMM. They're currently broken without these two patches. Thanks, Felix On 2019-05-10 4:14 p.m., Jerome Glisse wrote: > [CAUTION: External Email] > > On Fri, May 10, 2019 at 07:53:24PM +0000, Kuehling, Felix wrote: >> Don't set this flag by default in hmm_vma_do_fault. It is set >> conditionally just a few lines below. Setting it unconditionally >> can lead to handle_mm_fault doing a non-blocking fault, returning >> -EBUSY and unlocking mmap_sem unexpectedly. >> >> Signed-off-by: Felix Kuehling > Reviewed-by: J=E9r=F4me Glisse > >> --- >> mm/hmm.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/mm/hmm.c b/mm/hmm.c >> index b65c27d5c119..3c4f1d62202f 100644 >> --- a/mm/hmm.c >> +++ b/mm/hmm.c >> @@ -339,7 +339,7 @@ struct hmm_vma_walk { >> static int hmm_vma_do_fault(struct mm_walk *walk, unsigned long addr, >> bool write_fault, uint64_t *pfn) >> { >> - unsigned int flags =3D FAULT_FLAG_ALLOW_RETRY | FAULT_FLAG_REMOTE; >> + unsigned int flags =3D FAULT_FLAG_REMOTE; >> struct hmm_vma_walk *hmm_vma_walk =3D walk->private; >> struct hmm_range *range =3D hmm_vma_walk->range; >> struct vm_area_struct *vma =3D walk->vma; >> -- >> 2.17.1 >> _______________________________________________ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx --_000_BN6PR12MB1809F26E6AF74BE9F96DB22DF70F0BN6PR12MB1809namp_ Content-Type: text/html; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable
I reverted all the amdgpu HMM patches for 5.2 because they also depended on= this patch:
which did not have a clear line of sight for 5.2 either.

Alex
From: amd-gfx <amd-gfx-b= ounces@lists.freedesktop.org> on behalf of Kuehling, Felix <Felix.Kue= hling@amd.com>
Sent: Monday, May 13, 2019 3:36 PM
To: Jerome Glisse
Cc: linux-mm@kvack.org; airlied@gmail.com; amd-gfx@lists.freedesktop= .org; dri-devel@lists.freedesktop.org; alex.deucher@amd.com
Subject: Re: [PATCH 2/2] mm/hmm: Only set FAULT_FLAG_ALLOW_RETRY for= non-blocking
 
[CAUTION: External Email]

Hi Jerome,

Do you want me to push the patches to your branch? Or are you going to
apply them yourself?

Is your hmm-5.2-v3 branch going to make it into Linux 5.2? If so, do you know when? I'd like to coordinate with Dave Airlie so that we can also
get that update into a drm-next branch soon.

I see that Linus merged Dave's pull request for Linux 5.2, which
includes the first changes in amdgpu using HMM. They're currently broken without these two patches.

Thanks,
   Felix

On 2019-05-10 4:14 p.m., Jerome Glisse wrote:
> [CAUTION: External Email]
>
> On Fri, May 10, 2019 at 07:53:24PM +0000, Kuehling, Felix wrote: >> Don't set this flag by default in hmm_vma_do_fault. It is set
>> conditionally just a few lines below. Setting it unconditionally >> can lead to handle_mm_fault doing a non-blocking fault, returning<= br> >> -EBUSY and unlocking mmap_sem unexpectedly.
>>
>> Signed-off-by: Felix Kuehling <Felix.Kuehling@amd.com>
> Reviewed-by: J=E9r=F4me Glisse <jglisse@redhat.com>
>
>> ---
>>   mm/hmm.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/mm/hmm.c b/mm/hmm.c
>> index b65c27d5c119..3c4f1d62202f 100644
>> --- a/mm/hmm.c
>> +++ b/mm/hmm.c
>> @@ -339,7 +339,7 @@ struct hmm_vma_walk {
>>   static int hmm_vma_do_fault(struct mm_walk *walk, unsi= gned long addr,
>>           &= nbsp;           &nbs= p;    bool write_fault, uint64_t *pfn)
>>   {
>> -     unsigned int flags =3D FAULT_FLAG_ALLOW_= RETRY | FAULT_FLAG_REMOTE;
>> +     unsigned int flags =3D FAULT_FLAG_RE= MOTE;
>>        struct hmm_vma_walk *hmm= _vma_walk =3D walk->private;
>>        struct hmm_range *range = =3D hmm_vma_walk->range;
>>        struct vm_area_struct *v= ma =3D walk->vma;
>> --
>> 2.17.1
>>
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://= lists.freedesktop.org/mailman/listinfo/amd-gfx
--_000_BN6PR12MB1809F26E6AF74BE9F96DB22DF70F0BN6PR12MB1809namp_--