linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Jens Rottmann <jens.rottmann@adlinktech.com>
To: Minchan Kim <minchan@kernel.org>
Cc: Lukasz Odzioba <lukasz.odzioba@intel.com>,
	Sasha Levin <sasha.levin@oracle.com>,
	"stable@vger.kernel.org" <stable@vger.kernel.org>,
	Michal Hocko <mhocko@suse.com>,
	"linux-mm@kvack.org" <linux-mm@kvack.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Mikulas Patocka <mpatocka@redhat.com>
Subject: Re: 4.1.28: memory leak introduced by "mm/swap.c: flush lru pvecs on compound page arrival"
Date: Sat, 16 Jul 2016 17:29:59 +0000	[thread overview]
Message-ID: <BLUPR0501MB208230C3CCB7AC91F4E91B0087340@BLUPR0501MB2082.namprd05.prod.outlook.com> (raw)
In-Reply-To: <20160716144740.GA29708@bbox>

Hi Minchan (& all),

Minchan Kim wrote:
> [...] found __lru_cache_add has a bug. [...]
[-]     if (!pagevec_space(pvec) || PageCompound(page))
[+]     if (!pagevec_add(pvec, page) || PageCompound(page))

Confirm that did plug the leak, thanks!

Also I just saw this was known already:
https://marc.info/?l=linux-kernel&m=146858368215856
Sorry for not noticing earlier, I did search for "4.1.28 memory leak", but not for "memleak".

Many thanks,
Jens

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2016-07-16 17:30 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-15 19:27 Jens Rottmann
2016-07-15 22:33 ` Jens Rottmann
2016-07-16 13:55 ` Jens Rottmann
2016-07-16 14:47 ` Minchan Kim
2016-07-16 17:29   ` Jens Rottmann [this message]
2016-07-16 18:48     ` Mikulas Patocka
2016-07-18  6:53   ` Michal Hocko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BLUPR0501MB208230C3CCB7AC91F4E91B0087340@BLUPR0501MB2082.namprd05.prod.outlook.com \
    --to=jens.rottmann@adlinktech.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=lukasz.odzioba@intel.com \
    --cc=mhocko@suse.com \
    --cc=minchan@kernel.org \
    --cc=mpatocka@redhat.com \
    --cc=sasha.levin@oracle.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox