From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B9AE3C3DA7F for ; Thu, 15 Aug 2024 16:43:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2EA456B0153; Thu, 15 Aug 2024 12:43:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 27CEF6B0155; Thu, 15 Aug 2024 12:43:46 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0EDA56B0157; Thu, 15 Aug 2024 12:43:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id DF9616B0153 for ; Thu, 15 Aug 2024 12:43:45 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 8A2DFA80EA for ; Thu, 15 Aug 2024 16:43:45 +0000 (UTC) X-FDA: 82455051210.13.7FD418E Received: from NAM04-DM6-obe.outbound.protection.outlook.com (mail-dm6nam04on2064.outbound.protection.outlook.com [40.107.102.64]) by imf30.hostedemail.com (Postfix) with ESMTP id 9914280017 for ; Thu, 15 Aug 2024 16:43:42 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b=UBRXbdGW; dmarc=pass (policy=reject) header.from=nvidia.com; spf=pass (imf30.hostedemail.com: domain of ziy@nvidia.com designates 40.107.102.64 as permitted sender) smtp.mailfrom=ziy@nvidia.com; arc=pass ("microsoft.com:s=arcselector10001:i=1") ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1723740141; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=MSVy3bKwDjMHUzo7lGYWM6T2eiAk/V4XhDwc/NiR1dM=; b=tW2KEQ3MSbzP1k7qm6hTrZ9/jA4CtaVVdz2wilnhN5uJ56ldS5EboEnKBtY+5cgZNWPwSo 0OY5v1PZdL9oZEhnNX+s1hVh4ebHT6thohGKOTgd8t6tH6PjIsAi4GVMPi5IU+71aDevKQ ISKECoqchevvivdAc5ZPGR91yqD/sBg= ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1723740141; a=rsa-sha256; cv=pass; b=Ze+trZC2NjeCSHryttVdNBK+fMXQkBYnRpinDDnQij8iojK6IAUoEWYruO3slcoaJpKxoo TV1c2FSzhq09zyWOZJxB99H9SSpocbGw/cEenTAt2yXeIcTbOoydzmPRbLwJwtiDb3BXCI pSKxxG5Lp60JJ7QroN5/hX3SqQnnBCs= ARC-Authentication-Results: i=2; imf30.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b=UBRXbdGW; dmarc=pass (policy=reject) header.from=nvidia.com; spf=pass (imf30.hostedemail.com: domain of ziy@nvidia.com designates 40.107.102.64 as permitted sender) smtp.mailfrom=ziy@nvidia.com; arc=pass ("microsoft.com:s=arcselector10001:i=1") ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=fXVLT9QnWvgQwmuCUMD10Ft5LIe/+u7ZPcj+YMxa4H7Dpfb+aVJ+Gkvpp3AkTbUxLH4+9CiQ1ztuEwxyJALkGYv37fdWPB2S6XcdW140O3syfFeKmHPsdjtADMGQ3NDGEtuNc2s8HzyHG77WrVPdqv2Laie/CPyNfvfOo51xXDF5PPkl5V96E0UD3YlGl4gN+6NRVecS6s9t5y1WWvpNYePCsp158WTlc1vB08+YDP7KFsaqBN1V2HoYnVWFr6i6xUQphbpa30P6WK0ICGh5u6LDcg+z5vt757zyFGBQrMLPBldFM8HoqIOTtuTPaMTYsJiBDeDa+MUvQOmMg/+1Cg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=MSVy3bKwDjMHUzo7lGYWM6T2eiAk/V4XhDwc/NiR1dM=; b=oPm+EItU4HkeobolHRI6Hgmx7x2rdcvr/HVAg+LJWgku0BOtwX0P45C5XWB7JFtQsdGaQgZCuKLxewI20BSNZ2Wa5Bih17xZwYxsRKUBNnJ77leg+O8hcLo1BwMXKrPIrh3ZEk98s95ftUcvfTo20kIngTAiZdXsA1bSCpBaPUSbhVxhd8DcRorgr5GXiZNTeJdBglKj5DboyrU/dzqdpYNfvilH8I2a5///eOIncjP3JTTpwYL214tmVmPc64ld3DChRhW56Wx00eyCoDa7wawS/fPbbvxBi/V0B+D9ZXBNrT9MbTmOzCyyqlzCZiQjYlPb8y5NAQ44DYVE8Eu7VQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MSVy3bKwDjMHUzo7lGYWM6T2eiAk/V4XhDwc/NiR1dM=; b=UBRXbdGWGskFRY+IzOho+c6jEyNji9gVfp78S9Os9AwRjQbPLQy0LwrtLnJMsraTJy9/WuBKq1/ecgq9gjlHkYf4j5+LNWEsfqvmw/eFDHsQXmJYNQK5y/agtKlISPfg5FIMhvJ56IHfsUNx2MGIbugJpljF5je+7Ezt/+HIWPWYw7NZqnQQHR/fLttU8Urg1Ie5CGMuFYzUg0eXqVoN4jkLy6IZX8yNiwFtO6xdwWfNPf1RQOC2bOzoqlJchfTeFIfLSWYouVsDBiNN7WOSnNU8X3VCowxtsQekG1htu32TK1jgIIqVhii1IpuAQLf6+SakwVca3oiZPt2oJV1+ww== Received: from CYXPR12MB9320.namprd12.prod.outlook.com (2603:10b6:930:e6::9) by MW5PR12MB5652.namprd12.prod.outlook.com (2603:10b6:303:1a0::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7875.18; Thu, 15 Aug 2024 16:43:38 +0000 Received: from CYXPR12MB9320.namprd12.prod.outlook.com ([fe80::9347:9720:e1df:bb5f]) by CYXPR12MB9320.namprd12.prod.outlook.com ([fe80::9347:9720:e1df:bb5f%4]) with mapi id 15.20.7875.016; Thu, 15 Aug 2024 16:43:38 +0000 From: Zi Yan To: Kefeng Wang Cc: Matthew Wilcox , Andrew Morton , David Hildenbrand , Oscar Salvador , linux-mm@kvack.org Subject: Re: [PATCH RFC] mm: skip gigantic pages in isolate_single_pageblock() when mem offline Date: Thu, 15 Aug 2024 12:43:35 -0400 X-Mailer: MailMate (1.14r6052) Message-ID: In-Reply-To: <113f25e0-7eed-405b-9369-bc23b780d315@huawei.com> References: <20240813125226.1478800-1-wangkefeng.wang@huawei.com> <92fedec5-62c9-4ec0-9d4c-a722b30aa63c@huawei.com> <905740F8-58C6-4333-8EA1-4A53C95CC1FE@nvidia.com> <50FEEE33-49CA-48B5-B4C5-964F1BE25D43@nvidia.com> <113f25e0-7eed-405b-9369-bc23b780d315@huawei.com> Content-Type: multipart/signed; boundary="=_MailMate_9EC08254-E0D6-4A95-A9B1-EAE5BE44EEA7_="; micalg=pgp-sha512; protocol="application/pgp-signature" X-ClientProxiedBy: BL1PR13CA0091.namprd13.prod.outlook.com (2603:10b6:208:2b9::6) To CYXPR12MB9320.namprd12.prod.outlook.com (2603:10b6:930:e6::9) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CYXPR12MB9320:EE_|MW5PR12MB5652:EE_ X-MS-Office365-Filtering-Correlation-Id: ea71915c-770a-461b-37dc-08dcbd4969a9 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|376014|366016; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?+A91qRd96pLEuHG/F79MhPtAvIr1Blym1xkuoxD9s+tu/9nV66ybi9iKqYGq?= =?us-ascii?Q?jTEPNGCaAFQxe7bbK2S2HOI2CsfGJN/Q75AN4V4JpCuC7bE8Ynifopr2zA2B?= =?us-ascii?Q?HxR6/v4p3RrwjSeI6DB1hocFvT7eKFgCESGzJb5+jOAyTajrsessFg/1P9m6?= =?us-ascii?Q?7u/6rTn7yXrfHaf9yHCCp35DzUkIOvJC4OCuM8LJbI8In1KSKqP/JdJs9QSs?= =?us-ascii?Q?Ovd2raSJ90BGMdLoc8lv93W74+hR/W72ix8D5nIdzB8d0q4kCnaqCyWRtXUf?= =?us-ascii?Q?GltHLkInqNAJ1/cisVhfOf3RYW2tWkK1l328z7npOkkdud9v/9ZPf9U5xSBS?= =?us-ascii?Q?pG/Ce+XQTozicsfzQpPEkGbdL+LpcZaEvajHcEv8IJoy0qvgtpwTgCnhRt2p?= =?us-ascii?Q?0HHEj6YG03E4UIFLSvH0RWB0PYMmZDwnUMd+DrxIFkI3RfOkNkhvt/7VT/X/?= =?us-ascii?Q?krHc2T/UDWBQkeWH4doANhFawfd5LqZy/i7Blsb0nkOpHI8SFPEwA64fR5ZV?= =?us-ascii?Q?Qrf5rND2us6m0Ks9Oer5cxvYSF4kIx80bfjNFljq/gdBoAnZ+Ok3XSJTZ+nT?= =?us-ascii?Q?f13TzQlkRXUZbL/sUi+w7op5mBtKf7OuoIbUyD4NNOsNJ+I5ug87xcRu0I8H?= =?us-ascii?Q?TKMmIkplArm3Lslkeni+tJw4gOq8V+ZDm52EX3r53psjX+aDzHflyTGHmAMP?= =?us-ascii?Q?PbGszqreDOiy/MYhcEbJ7Czo0y1WxeTH4LSawW9bGyO3KUozJsiF5NMj1DaT?= =?us-ascii?Q?ZdEexlJhDHLm5eJSnzKUQVAYIGh2dTC/GzNfScC0dtYBlwjD038lhOukIZFB?= =?us-ascii?Q?Ev230Nk0J9fH5D02wlKrzK06fbEP2WMu/XOXOpP+2da/oSIaN1yK6lPQoTS3?= =?us-ascii?Q?Gv3Y09z+xNeHzefi/2pm8d9RbscPuzuWisW4qqH4FeCBeqn65UeZ7WAhIN5B?= =?us-ascii?Q?sfbfaVZl8UEXypVLe6xuRpBuE4jeqb0X4aw1rY6aXbvtbah7uLamf1ASU3mT?= =?us-ascii?Q?wtVzPJdGldE+R82zoKCPH700kAlVyJjyNp03Zcztv7vNR5d5a6gn+MycH8xM?= =?us-ascii?Q?voLkfqYaT6vLTy0nxd9oKeTlN7vy08MB/dB1xgAq7R/yh9iNGnDRfsCkhoJm?= =?us-ascii?Q?bEBE8AkAfWaec8i/NCQGGO8SYE7r7CMl2AiSAau+tXVWDtyYxmqHAIg4TsH+?= =?us-ascii?Q?D3KgXLp8D5kN46I7StcmalB+6rwMRbYRfBsnjwf+PxZxxcHyKFLSjy0yW7fa?= =?us-ascii?Q?zVLNJbayJh5Lzfwc8s+p3PJNXsqj6arwfdlnAsn1on5R41mxR4Y0CFVOhD8H?= =?us-ascii?Q?hKvU4RrOKIF73SCfNHWQh1yO0oqAuIuXngiorXbp6xCoysMvveq/uxbAI0oO?= =?us-ascii?Q?rHXS0Rk=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CYXPR12MB9320.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(376014)(366016);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?jyKxVQXLMSbuYKpDzNK9e8Ej578kcACE3vhLCehWLq34stk51aeXwpmDF/th?= =?us-ascii?Q?2Khrje3wTr9Kev89l7nz69Av7+Vvmu8EkE5yjtkVUtcJkPIemx9tT7imhpNE?= =?us-ascii?Q?rqizGoAJzINxQ4eqxtfW8WS88mUKAc1JDzDYGRVLf12FZr7phKva+D37OsXI?= =?us-ascii?Q?OUQ9BUNm4l7JvqIQJsVKozWR92j20V1IlCZdQnjd9FwRWLS7ojyWW+jU5lOG?= =?us-ascii?Q?1cUSSgRiTXBaFqGsQ3LIjty2bFKAs2ZUnDeauTzKXIPfO1qFjSlYB+KWPrY/?= =?us-ascii?Q?Rgh57lzHAkSYCsjshzcpn4cn44mL0d8kyVZNL9ufQuaOsGpbEhsLwp9n3U1H?= =?us-ascii?Q?5drjeEtHGFSmSP/2foZsjk2NXIUou1w2QwpuC2NBp9pOXgidRQJTtcmsy9qp?= =?us-ascii?Q?bSNGTj6uPJK5nMM+C0tIKMd5lkCuId6lBfCiTbZwqQ2+eQyVdFRjLeZBdpaR?= =?us-ascii?Q?bKxWndofzzB6XMzxMjbDtO3kFXEx39Ltu8+xRUTUDLUfmgQTbzpNGlKqh/u/?= =?us-ascii?Q?j7ul7oVr65/egcH3fy8/RWUTN9JsNubNW9lOUsQ06HjrHvqFDv+YJZAkc4bz?= =?us-ascii?Q?svJgcGaAubcrbdgwlDdcS8l5xKNoM5zMyOT7CUJzD0ZKZ1sW/meT8nt+B4vN?= =?us-ascii?Q?/gjCgT1j9YK3yBnpDxcCift7kFTJQVe6V/9o3N/skqsyesmlT1PKwfP/knIq?= =?us-ascii?Q?tOhlxzBj94+KY1CVAU8UWw3n6izfKWKmLo+VbXpJPNe4kMo8WPWq7lCVbuVL?= =?us-ascii?Q?dZ7zXwE9pd5/jpR+UTkU3a3Ahl+GfEF5U8nhVFcvqHFnwyXLkyt6nxMyUItK?= =?us-ascii?Q?uz3OHBDjpS3+VoQuMbzc/O+fXmTjwAx/O6g1A86m5SbzLOOhb3Jc6kZuziL0?= =?us-ascii?Q?htyI/E6EpBskO5pq0IhxWvaLsWEMq6/bFNQ90cF6QCVq2rtbfSkthy/Nx7pU?= =?us-ascii?Q?Sv8ZA6tXBmo2FNE6BKH4ACrdXbAnIhKZIzsP6jCDSaoskU6rEGfXD/XOxtB+?= =?us-ascii?Q?xY/5JtBWagSP66EX8EvQepUT6SP68cqgH4CYHEZY0BKMw/M/NzTN/FD0B3zF?= =?us-ascii?Q?51sXhr2qygHcgg75HJw/eUPxxGWz++fl6vMga/r6MOyeLblxvHRpqiXT6UlF?= =?us-ascii?Q?0kKNEfe1U95jHbznlhtDOhDZcDCI6HLbaklZ9LWCPmhIl8rvYc8A/H2TA/x5?= =?us-ascii?Q?4E48w57D4vsnejvXU8G0a++p+nypCL7u/RnmzB1sJdr6N0M6gqkrk+nRlSls?= =?us-ascii?Q?IBagriSCKzMB2EdnPRqheE2Iv5tiZ+fW3eXZph0AASErklo1k1QYDj1fU806?= =?us-ascii?Q?BGFCT31Woy93hz/2qNHzWhBmczo2POwIOTNF5/OSbvUO40hTdpLEpvZ4HEi4?= =?us-ascii?Q?oU5BjpllslxJw7kHpYqM51zm40LDPHckexnDpVo4+AxdMDPOrkmu5XYua9eP?= =?us-ascii?Q?rcBv4fmXPeM6WiKTw6hUntzvECQslxKJQN3AWT3QCYiFGlNU5svpd+1nylm2?= =?us-ascii?Q?QOoT3dcOYXt6RcLBY5NeWnU76WEyTIrfyzxmY8MEV1g8odpDDRJTJJ27RJAe?= =?us-ascii?Q?HVTVtED3MOBXrRUw+baZ7GlMvYqyf40IQiNPw5YP?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: ea71915c-770a-461b-37dc-08dcbd4969a9 X-MS-Exchange-CrossTenant-AuthSource: CYXPR12MB9320.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Aug 2024 16:43:38.3847 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 35ksW7lVhAjAdVmoUaCxVjuhs6vy6MTynmY6eOuZW27yGbdxkL1HHAdwBXWtFJLz X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW5PR12MB5652 X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 9914280017 X-Stat-Signature: spnbg7kai1cnhou6yp79cjub47ck3ebc X-Rspam-User: X-HE-Tag: 1723740222-555136 X-HE-Meta: U2FsdGVkX18rqIgv6obY5jfU1Qc06K+7RWSPrtL7NrysR0Go0HFqdFlWkIxhYDoBHG1H1dPs3kDYjrj+NmFryxXIm54/x/mXAjKCbKZYWrQf6mTyfwXEpeFL2XOrSQqDvsWzMqGmmd+mbx3MYjMIaUhW/fZ0/TJejjlTCwsqdReAtmQVcNT5gXFlue5nB+vA8VP7UonfQCeDkZbouJ+8kAKSuCa7azP6IdMevUj0Lp4K59kr/4wlKk4X3xAKzV0tqeph8Gx7B0QYDEJThGKE1Q4dTveVmB2qxf/tKF61Nb2aVSF/frGgmC8Ltoc91zHBHgBfLXCmf/TFgyOf+89BI2rfK4IKRxBndG4En9778HFgsoLvZ2Rc3XaM5PfAx6J8hiGmUxMv7RAFpgZzc88p9m4OISzOGfwUxotrQEFwcoHPh/C55C+bRHapYEiCkzKpT2c/pCvGETfTVqx3GEPjLfefPz85gg5A5I7jVURTSXVG8Y66BaP7PqbFCL1PwDCK6DeDBKdE4p4NL98RdQuePSOIFUs8mSPmK/KCx1QhW8u8wa0HieH+Omcoqlr78bE7qIg5k9jJhRYblocCXYfjXor2Er1N3sYarq2WCHUG0nWwVireHW9ikHPyPkYAHiN2Dxg9Gm+Yn655ZcGgNk8tRn4CVXLkA41dG9ViPSvvztmYlrYmmFD8THMJleKy8zq/yxZJSZYpDDgX1N5QVrWqXBy75Gc6PJ8OaRMkRYXN8APhPBHul8h0MSFncbB9yfbp9lyD0cu83Zu5mYqcMoc+ZhRpMLzOgjKOutcfxTrYqkc932NHpiS7vo5V5n0+lohiprEBRD+VWjDlgNBQoEPzogXQ2zCMU1++BRQWS7lfv9uoyTqgr+11mX/454V7LFF8gWR3ilf9Yy9KRJCS2SBp+d90FY90fX0mpIcWzaTxSdniqCUs6jtCLY4hsTQP6pNNjqPxiLop0G4IIHIafJ8 IYODR+4V s5xTQ2CI2bP3MClgiE0Sol0VkcBZt9Cjv/VYg9qsRUpRQH16OLSYg7gwr9JlxVvTm1czmPFUUs3ca5EQw3kyyFilEvCjSP2dypOkgnB2GA7EBQIPHNOiP8WTUxZxIWqpaddUZFvEUfRJE19/aCFitOTm9bvB9711odMw3Gi+M47TYPp/HxOT0MlTwzSYXpz3SA7ZApltZcQ7WHQ0m83tEpHtRCdYPmmythyUAIXd7XM2xWOVd4SeB89o4gupbdAq9V5OFYYWhojco9h2OGfkqiEX6Lct5HnhDDtZdjTQ211mirLULIFlTtsW+KzXYF5wYGfqLBPi4NrtzH842AviLh8W4exLydIMIL8Z8cMz2jBdEua6qyuSqjJER/alE3B1v5yGsylgdlnTJtaiD5N/3ioi1rLLRR8uI0TRglRII5qUad6tgxCBw+V8URV2VYcvUeR0SdnSIibKlB8d56yPCGZquU4FVwXmuptvSRzfFJRqVmHL0QNMYPExW+c15LnRQCJB8hRfoSASPln2Fr6Gm45q2i6oQiS7GyLOA X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: --=_MailMate_9EC08254-E0D6-4A95-A9B1-EAE5BE44EEA7_= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable On 14 Aug 2024, at 22:58, Kefeng Wang wrote: > On 2024/8/14 22:53, Zi Yan wrote: >> On 13 Aug 2024, at 22:01, Kefeng Wang wrote: >> >>> On 2024/8/13 22:59, Zi Yan wrote: >>>> On 13 Aug 2024, at 10:46, Kefeng Wang wrote: >>>> >>>>> On 2024/8/13 22:03, Matthew Wilcox wrote: >>>>>> On Tue, Aug 13, 2024 at 08:52:26PM +0800, Kefeng Wang wrote: >>>>>>> The gigantic page size may larger than memory block size, so memo= ry >>>>>>> offline always fails in this case after commit b2c9e2fbba32 ("mm:= make >>>>>>> alloc_contig_range work at pageblock granularity"), >>>>>>> >>>>>>> offline_pages >>>>>>> start_isolate_page_range >>>>>>> start_isolate_page_range(isolate_before=3Dtrue) >>>>>>> isolate [isolate_start, isolate_start + pageblock_nr_pag= es) >>>>>>> start_isolate_page_range(isolate_before=3Dfalse) >>>>>>> isolate [isolate_end - pageblock_nr_pages, isolate_end) = pageblock >>>>>>> __alloc_contig_migrate_range >>>>>>> isolate_migratepages_range >>>>>>> isolate_migratepages_block >>>>>>> isolate_or_dissolve_huge_page >>>>>>> if (hstate_is_gigantic(h)) >>>>>>> return -ENOMEM; >>>>>>> >>>>>>> [ 15.815756] memory offlining [mem 0x3c0000000-0x3c7ffffff] fai= led due to failure to isolate range >>>>>>> >>>>>>> Fix it by skipping the __alloc_contig_migrate_range() if met giga= ntic >>>>>>> pages when memory offline, which return back to the original logi= c to >>>>>>> handle the gigantic pages. >>>>>> >>>>>> This seems like the wrong way to fix this. The logic in the next >>>>>> PageHuge() section seems like it's specifically supposed to handle= >>>>>> gigantic pages. So you've just made that dead code, but instead o= f >>>>>> removing it, you've left it there to confuse everyone? >>>>> >>>>> isolate_single_pageblock() in start_isolate_page_range() will be ca= lled >>>>> from memory offline and contig allocation (alloc_contig_pages()), t= his >>>>> changes only restore the behavior from memory offline code, but we = still >>>>> fail in contig allocation. >>>>> >>>>> From memory offline, we has own path to isolate/migrate page or d= issolve >>>>> free hugetlb folios, so I think we don't depends on the __alloc_con= tig_migrate_range(). >>>>>> >>>>>> I admit to not understanding this code terribly well. >>>>>> >>>>> A quick search from [1], the isolate_single_pageblock() is added fo= r >>>>> contig allocation, but it has negative effects on memory hotplug, >>>>> Zi Yan, could you give some comments? >>>>> >>>>> [1] https://lore.kernel.org/linux-mm/20220425143118.2850746-1-zi.ya= n@sent.com/ >>>> >>>> Probably we can isolate the hugetlb page and use migrate_page() inst= ead of >>>> __alloc_contig_migrate_range() in the section below, since we are ta= rgeting >>>> only hugetlb pages here. It should solve the issue. >>> >>> For contig allocation, I think we must isolate/migrate page in >>> __alloc_contig_migrate_range(), but for memory offline,(especially fo= r >>> gigantic hugepage)as mentioned above, we already have own path to >>> isolate/migrate used page and dissolve the free pages,the >>> start_isolate_page_range() only need to mark page range MIGRATE_ISOLA= TE, >>> that is what we did before b2c9e2fbba32, >>> >>> start_isolate_page_range >>> scan_movable_pages >>> do_migrate_range >>> dissolve_free_hugetlb_folios >>> >>> Do we really need isolate/migrate the hugetlb page and for memory >>> offline path? >> >> For memory offline path, there is do_migrate_range() to move the pages= =2E >> For contig allocation, there is __alloc_contig_migrate_range() after >> isolation to migrate the pages. >> >> The migration code in isolate_single_pageblock() is not needed. >> Something like this would be OK, just skip the page and let either >> do_migrate_range() or __alloc_contig_migrate_range() to handle it: > > Oh, right, for alloc_contig_range(), we do have another __alloc_contig_= migrate_range() after start_isolate_page_range(), then we > could drop the following code, > >> >> diff --git a/mm/page_isolation.c b/mm/page_isolation.c >> index 042937d5abe4..587d723711c5 100644 >> --- a/mm/page_isolation.c >> +++ b/mm/page_isolation.c >> @@ -402,23 +402,6 @@ static int isolate_single_pageblock(unsigned long= boundary_pfn, int flags, >> >> #if defined CONFIG_COMPACTION || defined CONFIG_CMA >> if (PageHuge(page)) { >> - int page_mt =3D get_pageblock_migratet= ype(page); >> - struct compact_control cc =3D { >> - .nr_migratepages =3D 0, >> - .order =3D -1, >> - .zone =3D page_zone(pfn_to_pag= e(head_pfn)), >> - .mode =3D MIGRATE_SYNC, >> - .ignore_skip_hint =3D true, >> - .no_set_skip_hint =3D true, >> - .gfp_mask =3D gfp_flags, >> - .alloc_contig =3D true, >> - }; >> - INIT_LIST_HEAD(&cc.migratepages); >> - >> - ret =3D __alloc_contig_migrate_range(&= cc, head_pfn, >> - head_pfn + nr_= pages, page_mt); >> - if (ret) >> - goto failed; >> pfn =3D head_pfn + nr_pages; >> continue; >> } > > > But we need to remove the CONFIG_COMPACTION/CMA too, thought? > > diff --git a/mm/page_isolation.c b/mm/page_isolation.c > index 042937d5abe4..785c2d320631 100644 > --- a/mm/page_isolation.c > +++ b/mm/page_isolation.c > @@ -395,30 +395,8 @@ static int isolate_single_pageblock(unsigned long = boundary_pfn, int flags, > unsigned long head_pfn =3D page_to_pfn(head); > unsigned long nr_pages =3D compound_nr(head); > > - if (head_pfn + nr_pages <=3D boundary_pfn) { > - pfn =3D head_pfn + nr_pages; > - continue; > - } > - > -#if defined CONFIG_COMPACTION || defined CONFIG_CMA > - if (PageHuge(page)) { > - int page_mt =3D get_pageblock_migratety= pe(page); > - struct compact_control cc =3D { > - .nr_migratepages =3D 0, > - .order =3D -1, > - .zone =3D page_zone(pfn_to_page= (head_pfn)), > - .mode =3D MIGRATE_SYNC, > - .ignore_skip_hint =3D true, > - .no_set_skip_hint =3D true, > - .gfp_mask =3D gfp_flags, > - .alloc_contig =3D true, > - }; > - INIT_LIST_HEAD(&cc.migratepages); > - > - ret =3D __alloc_contig_migrate_range(&c= c, head_pfn, > - head_pfn + nr_p= ages, page_mt); > - if (ret) > - goto failed; > + if (head_pfn + nr_pages <=3D boundary_pfn || > + PageHuge(page)) > pfn =3D head_pfn + nr_pages; > continue; > } > @@ -432,7 +410,6 @@ static int isolate_single_pageblock(unsigned long b= oundary_pfn, int flags, > */ > VM_WARN_ON_ONCE_PAGE(PageLRU(page), page); > VM_WARN_ON_ONCE_PAGE(__PageMovable(page), page)= ; > -#endif > goto failed; > } That looks good to me. Best Regards, Yan, Zi --=_MailMate_9EC08254-E0D6-4A95-A9B1-EAE5BE44EEA7_= Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iQJDBAEBCgAtFiEEh7yFAW3gwjwQ4C9anbJR82th+ooFAma+MDgPHHppeUBudmlk aWEuY29tAAoJEJ2yUfNrYfqKIq4P/1GIwnyLazUTXGMo1KxXQ7kHohLoHGHXQ2+A kpEoA3KwQLqs9mRCnOH2uPRy6F5QDslR/NqMSADiEB2rqQ93GEcbpLay5R2PQeHh QkTwB3t0U+3/Yoc6tI4PjcIM0auZqetiiSM4Td2kb5Ba8bNHCwwLDandWeXJq6Tt Gtjv88kZbYl1jyqf1bWyMgGyPAV+/FdJ50Cz1bwpXayB9IKRESD4JSvmLufgzwYh dXhqg9IZ1abJyy4kyp0S93K6f4eaajChNhL+bKCBwKVcgoCDrbyJqEHeufXih6aI EZ4WmXVjHknba3VE9n6rXsFFE6bT94iWvOJ51um+r3bQFMKMwCAy9C+lmhoezkMI emi6o214J8byNi5y5WakIwHiNa9wRNtEnfCVgJv7d3kwbS2ldzxlJlQRYc22YCzK vnX4gzaXSLyiXTa7DnjSoxviUbQxrBhJuO50+XOYwu39bxsvzVisKACjQ0S7E21K lAnY9Hh0YtjZNHyw54DYUrGCeZImd3sZJrpvJkSpxaN8gtqhu9XUnNjwdQ1AJn4B zELopCiRlc9hZ2ewZfsm1q0/0PApWQtOCYQtCe+zX5+OhBrKziC8QNpxZL68Gnsk xN+ZFneY3VwiAbiKHYcVgV+5dOzJYd4wF5UPm8mC2usyxYjXVO6jVGxih5/aEBoP UPadBfNz =zAwf -----END PGP SIGNATURE----- --=_MailMate_9EC08254-E0D6-4A95-A9B1-EAE5BE44EEA7_=--