From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1F37EC433E0 for ; Fri, 26 Mar 2021 14:10:14 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 8A9EA61A0D for ; Fri, 26 Mar 2021 14:10:13 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8A9EA61A0D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=loongson.cn Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 25D826B0071; Fri, 26 Mar 2021 10:10:13 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 20D166B0072; Fri, 26 Mar 2021 10:10:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0105D6B0073; Fri, 26 Mar 2021 10:10:12 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0053.hostedemail.com [216.40.44.53]) by kanga.kvack.org (Postfix) with ESMTP id D17B46B0071 for ; Fri, 26 Mar 2021 10:10:12 -0400 (EDT) Received: from smtpin12.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 914A4A8FC for ; Fri, 26 Mar 2021 14:10:12 +0000 (UTC) X-FDA: 77962209864.12.A0B847B Received: from loongson.cn (mail.loongson.cn [114.242.206.163]) by imf29.hostedemail.com (Postfix) with ESMTP id DB7C72BEA for ; Fri, 26 Mar 2021 14:10:02 +0000 (UTC) Received: from [192.168.1.111] (unknown [175.152.148.180]) by mail.loongson.cn (Coremail) with SMTP id AQAAf9Dxr8tU6V1gRRgBAA--.961S2; Fri, 26 Mar 2021 22:01:58 +0800 (CST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.120.23.2.4\)) Subject: Re: [PATCH 2/6] MIPS: move FTRACE_SYSCALLS from ftrace.c into syscall.c From: Huang Pei In-Reply-To: <20210325153845.759b242e@gandalf.local.home> Date: Fri, 26 Mar 2021 22:01:56 +0800 Cc: Thomas Bogendoerfer , ambrosehua@gmail.com, Bibo Mao , linux-mips@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, Jiaxun Yang , Paul Burton , Li Xuefeng , Yang Tiezhu , Gao Juxin , Huacai Chen , Jinyang He , "Maciej W . Rozycki" , Jisheng Zhang , Masami Hiramatsu Content-Transfer-Encoding: quoted-printable Message-Id: References: <20210313064149.29276-1-huangpei@loongson.cn> <20210313064149.29276-3-huangpei@loongson.cn> <20210325153845.759b242e@gandalf.local.home> To: Steven Rostedt X-Mailer: Apple Mail (2.3608.120.23.2.4) X-CM-TRANSID:AQAAf9Dxr8tU6V1gRRgBAA--.961S2 X-Coremail-Antispam: 1UD129KBjvdXoW7JrW7Gw1DCF4rWrWrAw4Dtwb_yoWkXrcEyF WxKFyvkw1UtFn5JFW5tr4rXFy3Ww45Xw4kZ3WqgrW5ZasxJa1DJFWDtrW3Xr1xXF18XFs0 yw1fAryxtw12qjkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUIcSsGvfJTRUUUbVxFF20E14v26ryj6rWUM7CY07I20VC2zVCF04k26cxKx2IYs7xG 6rWj6s0DM7CIcVAFz4kK6r1j6r18M28lY4IEw2IIxxk0rwA2F7IY1VAKz4vEj48ve4kI8w A2z4x0Y4vE2Ix0cI8IcVAFwI0_Jr0_JF4l84ACjcxK6xIIjxv20xvEc7CjxVAFwI0_Gr0_ Cr1l84ACjcxK6I8E87Iv67AKxVW0oVCq3wA2z4x0Y4vEx4A2jsIEc7CjxVAFwI0_GcCE3s 1le2I262IYc4CY6c8Ij28IcVAaY2xG8wAqx4xG64xvF2IEw4CE5I8CrVC2j2WlYx0E2Ix0 cI8IcVAFwI0_Jr0_Jr4lYx0Ex4A2jsIE14v26r1j6r4UMcvjeVCFs4IE7xkEbVWUJVW8Jw ACjcxG0xvY0x0EwIxGrwACjI8F5VA0II8E6IAqYI8I648v4I1lFIxGxcIEc7CjxVA2Y2ka 0xkIwI1lc2xSY4AK67AK6ry5MxAIw28IcxkI7VAKI48JMxC20s026xCaFVCjc4AY6r1j6r 4UMI8I3I0E5I8CrVAFwI0_Jr0_Jr4lx2IqxVCjr7xvwVAFwI0_JrI_JrWlx4CE17CEb7AF 67AKxVW8ZVWrXwCIc40Y0x0EwIxGrwCI42IY6xIIjxv20xvE14v26r1j6r1xMIIF0xvE2I x0cI8IcVCY1x0267AKxVW8JVWxJwCI42IY6xAIw20EY4v20xvaj40_WFyUJVCq3wCI42IY 6I8E87Iv67AKxVWUJVW8JwCI42IY6I8E87Iv6xkF7I0E14v26r4j6r4UJbIYCTnIWIevJa 73UjIFyTuYvjfUYXdjDUUUU X-CM-SenderInfo: xkxd0whshlqz5rrqw2lrqou0/ X-Stat-Signature: 6y4ibifwh43fo3zxe5fwif73apts1e3o X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: DB7C72BEA Received-SPF: none (loongson.cn>: No applicable sender policy available) receiver=imf29; identity=mailfrom; envelope-from=""; helo=loongson.cn; client-ip=114.242.206.163 X-HE-DKIM-Result: none/none X-HE-Tag: 1616767802-906710 X-Bogosity: Ham, tests=bogofilter, spamicity=0.098568, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: I was intended to add -fpatchable-function-entry based new ftrace = implementation in parallel=20 with old -pg based one, which is enabled by supported gcc version at = build time, since=20 +. the fix for -fpatchable-function-entry is not merge into upstream;=20 +. the -fpatchable-function-entry does not support static function = tracing which is rarely used today,=20 which is only implemented in the old -pg based implementation; Move FTRACE_SYSCALLS into syscall.c, so both new and old implementation = can easily be switched freely. When everything is all right, old one can be easily removed, and = that is patch 1/2/3 intended for > On Mar 26, 2021, at 3:38 AM, Steven Rostedt = wrote: >=20 > On Sat, 13 Mar 2021 14:41:45 +0800 > Huang Pei wrote: >=20 > Why? >=20 > -- Steve >=20 >> Signed-off-by: Huang Pei >> --- >> arch/mips/kernel/Makefile | 1 - >> arch/mips/kernel/ftrace.c | 33 --------------------------------- >> arch/mips/kernel/syscall.c | 32 ++++++++++++++++++++++++++++++++ >> 3 files changed, 32 insertions(+), 34 deletions(-)