linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Muchun Song <muchun.song@linux.dev>
To: Oscar Salvador <osalvador@suse.de>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	David Hildenbrand <david@redhat.com>,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm, hugetlb: Increment the number of pages to be reset on HVO
Date: Tue, 15 Apr 2025 21:24:52 +0800	[thread overview]
Message-ID: <BDEBB9B4-D3D3-4CEA-8BE0-1E2947F688D4@linux.dev> (raw)
In-Reply-To: <20250415111859.376302-1-osalvador@suse.de>



> On Apr 15, 2025, at 19:18, Oscar Salvador <osalvador@suse.de> wrote:
> 
> commit 4eeec8c89a0c ("mm: move hugetlb specific things in folio to page[3]")
> shifted hugetlb specific stuff, and now mapping overlaps _hugetlb_cgroup field.
> 
> Upon restoring the vmemmap for HVO, only the first two tail pages are reset, and
> this causes the check in free_tail_page_prepare() to fail as it finds
> an unexpected mapping value in some tails.
> 
> Increment the number of pages to be reset to 4 (head + 3 tail pages)
> 
> Fixes: 4eeec8c89a0c ("mm: move hugetlb specific things in folio to page[3]")
> Suggested-by: David Hildenbrand <david@redhat.com>
> Signed-off-by: Oscar Salvador <osalvador@suse.de>

Reviewed-by: Muchun Song <muchun.song@linux.dev>

Thanks.



      parent reply	other threads:[~2025-04-15 13:25 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-15 11:18 Oscar Salvador
2025-04-15 13:02 ` David Hildenbrand
2025-04-15 13:24 ` Muchun Song [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BDEBB9B4-D3D3-4CEA-8BE0-1E2947F688D4@linux.dev \
    --to=muchun.song@linux.dev \
    --cc=akpm@linux-foundation.org \
    --cc=david@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=osalvador@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox