From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2C195C54FB3 for ; Thu, 29 May 2025 15:21:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id ADAD26B007B; Thu, 29 May 2025 11:21:23 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AB2D46B0083; Thu, 29 May 2025 11:21:23 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9A1346B0085; Thu, 29 May 2025 11:21:23 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 7BC606B007B for ; Thu, 29 May 2025 11:21:23 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 177471D3CA7 for ; Thu, 29 May 2025 15:21:23 +0000 (UTC) X-FDA: 83496309246.22.298F120 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2087.outbound.protection.outlook.com [40.107.93.87]) by imf23.hostedemail.com (Postfix) with ESMTP id 49652140002 for ; Thu, 29 May 2025 15:21:20 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b=ISHAS8ql; arc=pass ("microsoft.com:s=arcselector10001:i=1"); dmarc=pass (policy=reject) header.from=nvidia.com; spf=pass (imf23.hostedemail.com: domain of ziy@nvidia.com designates 40.107.93.87 as permitted sender) smtp.mailfrom=ziy@nvidia.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1748532080; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=60XXxnMSBwGcDdqtwi6bw5PE7YThq00CBn3ifuNBtiM=; b=kbR7iehxSgc7QDbY5qqugNMi0TfU8zd6om0rus7BNa9sajDElbWS0qgB5yonx6elg8Ky7e rnjeid9PN1M+KD9vtapMLz9jSNJ0DSIHwLyUjXr+kaounUQU45MFc8llFGTz1EgZKai3Po PAgWZn72P7436mA3wXRkRi/mRwMwam0= ARC-Authentication-Results: i=2; imf23.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b=ISHAS8ql; arc=pass ("microsoft.com:s=arcselector10001:i=1"); dmarc=pass (policy=reject) header.from=nvidia.com; spf=pass (imf23.hostedemail.com: domain of ziy@nvidia.com designates 40.107.93.87 as permitted sender) smtp.mailfrom=ziy@nvidia.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1748532080; a=rsa-sha256; cv=pass; b=UL2onvuo2IzKcpseGF3G17Uj1hkV/V7Eoj3EmlaUlsGrcXXw33wDVN0jx332q9zAMmAZPK KC+CzGOYjo0lTCy7QdyIfWWhxhFTZfdWg07jHIt2vbVlvsDAH9q8iqGgMi9OYMwET39+oA GMzPrx4kJ1U1wVOqoGRworONY3Rb1V4= ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=FNaulOfIvHZdL4SzhQR5dYpU3SbpBjzSWUTN1YwsZwVH2yVKZUv2w2f4KeGOP+EdsfLUIeFU3tZkP1mycXGYr8fP44nt4WnYBfCzjhyfwtd2L3JTw9QpSyxiT0sD0p4oxDqfgrJoj/1jJyT0ThHSvmHJUfVqF0llYpFBlZSa0mzuj+KjKjUeln5t/ggiBdjWtym8Aul+x/GHRWog7Y2IeHqeBN3hQpB3ociphdt44Cb2eNegw2DrCUHUuSf4BpDi6RuBD92srKvE8+v/l1BMlyxWFBq1cPxBSSWiGIpTlwkJl8r0SmaMGnEsGSMnQggX6eHzpOVGDJk29z4xSO3PUA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=60XXxnMSBwGcDdqtwi6bw5PE7YThq00CBn3ifuNBtiM=; b=aDsoASM1n3rwT3g/79NQn9qojAtfkj6T8ylZW6Hvu/OxGfCY4QUdhNE6JAlRBuYM4qPjbE94oLe8+wWkIqbPl8L5MqUhnOxYmTPnJWbuTyZVav25i5YaRCFNEOm/vFssBFFHNhMIt8A829kEeFJmX8STW0CkbD5Aq3/8HfLxBb4+0ho+4FAk+QAinIqHNoXp6i0FlLQi/+eMLYdhkL6OicpGYWquR3E1S90Erbq7uijq6a3q+e8b/rxVqQDudjHpiGCGp4TtIjkoYxbsnvIrL9wqSRxsROgQwBfj9wDhNOfQ4Wq9CkKOYmNG1tgpwGLzK8rP2h/EQDaVFMihl4Fu5Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=60XXxnMSBwGcDdqtwi6bw5PE7YThq00CBn3ifuNBtiM=; b=ISHAS8qlF+DnsMYmCdivSlh9n3m8ksZUTqjkvk2CXrO2lyVI0zZ3e1RAeqMjTy6cFmsCsToc/CNLA+8uBzEkR5UnyAnml/e3d8ABi4VwxoJkaOYcQTzxi+0sb/6tP0y10MSev/CvTBG1zxfD/erjcDHHDI84mrbEVeS/p2HLYaEXkoIqOHg4gA1CsyOXEirg8SEmOgNSbK+UpYdZAwlip+q2+moUGZNc9S0A0Wd8UjGirJb0+6Vhs6q0dhYULqC62aCKOOavs2C+hGBvHZ/joNgkqMITOurgtQLd1iE0g9+asXkkjKT4REcfCUNIk0VFkNCwa3D3FB/EKOSHfitaNQ== Received: from DS7PR12MB9473.namprd12.prod.outlook.com (2603:10b6:8:252::5) by LV3PR12MB9354.namprd12.prod.outlook.com (2603:10b6:408:211::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8769.30; Thu, 29 May 2025 15:21:14 +0000 Received: from DS7PR12MB9473.namprd12.prod.outlook.com ([fe80::5189:ecec:d84a:133a]) by DS7PR12MB9473.namprd12.prod.outlook.com ([fe80::5189:ecec:d84a:133a%4]) with mapi id 15.20.8769.025; Thu, 29 May 2025 15:21:13 +0000 From: Zi Yan To: Baolin Wang Cc: akpm@linux-foundation.org, hughd@google.com, david@redhat.com, lorenzo.stoakes@oracle.com, Liam.Howlett@oracle.com, npache@redhat.com, ryan.roberts@arm.com, dev.jain@arm.com, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] mm: shmem: disallow hugepages if the system-wide shmem THP sysfs settings are disabled Date: Thu, 29 May 2025 11:21:11 -0400 X-Mailer: MailMate (2.0r6255) Message-ID: In-Reply-To: References: Content-Type: text/plain Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: BL6PEPF0001640E.NAMP222.PROD.OUTLOOK.COM (2603:10b6:22e:400:0:1004:0:15) To DS7PR12MB9473.namprd12.prod.outlook.com (2603:10b6:8:252::5) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS7PR12MB9473:EE_|LV3PR12MB9354:EE_ X-MS-Office365-Filtering-Correlation-Id: 786cb66d-b822-4b6b-6107-08dd9ec472a9 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|7416014|376014|366016|1800799024|7053199007; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?oyc5sZZLwhW62JKTerGnHUpvhYdW8J0+e2G0tHx9jEau4G8MTK3QaHx5bZAW?= =?us-ascii?Q?aVEUnrkOjg8wgeSCOhkShu6oOlKLC8I/brcKFEGAL5CdFNX9zEXdUweWf5E+?= =?us-ascii?Q?BWmTvmUJXy+tO4Z9kl9ObqM7E2YNwSOtQDeryhyPvG3xEZCFV7ze67huVLrq?= =?us-ascii?Q?a2AqCzlcSAWkMlN7M4l4di4zYL6/KDE60SWZuGLSh9LWhfET74UnsdQ+bgDN?= =?us-ascii?Q?I6afx/7ciwHl6ne+CL2EJLh39FmEXdYeZlwagQuCl20A7UjCFoVz7IynKnzs?= =?us-ascii?Q?H98F3yh9B5PymYuBmV5tmxa8S8+eQJPkWxh03Y8B2961I3Zc2liw5nsoCr1A?= =?us-ascii?Q?i/dV6Re/8dB/x/+PyVWC7IyvJXWdxnlbkM6bpmDVi4V/l10ARfcdLnIBl19w?= =?us-ascii?Q?XaJlUgsKPhWGxzq/1CUmWsW1ceH07a4LNIZHvn4k7xMeom0umZTn8WE6qg73?= =?us-ascii?Q?lLhvvQhQix5tH76rVcuZTHoCQKIpCXO9YRpii2nWL0ehpxir0uIqB4HZtynP?= =?us-ascii?Q?6D699cMMqZ6MDfSQ1aLNYVNtXM5K8dcm3MYtlRJAY0mc7Cn59d1KABwq5i2c?= =?us-ascii?Q?Qd0ZN99ibqtAOt8LL1jm05ma6ElnAtTISeAQfJ1meVNpw4mC3insx4nscqpC?= =?us-ascii?Q?vUhQXz7x9YSxN6MzZ5770kD0gVndqymko6XWV03Jdw4dB9cQTqeodH7XOaoJ?= =?us-ascii?Q?Wz3WOqPIYgPiyPdlQmCws8n9H30vYZk5kBO/xoM2WK9KfJvHE2M6ccC3D0ON?= =?us-ascii?Q?RJJZxh20GFFdwodbp66LAFaYq6QPiZ0hbOlnmtD9UkxAsDIADFhhNRFu7Bpm?= =?us-ascii?Q?TuTeTIJyuKMejG88sChzQAW+LAa/LVPygHq7rzsRc5b0PRDStyEEKgw3J+CQ?= =?us-ascii?Q?xuxRq6a/1uCNr7jp0MXQado5xgENM5ewBPfGVQhIedGSoOaIrlqz/zVd30u6?= =?us-ascii?Q?fg1R6L8lOmCqf00N4H7vKD8rrr4I4Euqyuw8V8xIfFcS3TyHrKJKnP6SJg31?= =?us-ascii?Q?JKVLyIMRWzHsmifhj0QSNT2DUkFJbFvWU1NqHl1Uqp7tbFoGxl+naKlp2h3Y?= =?us-ascii?Q?/FHAjflfoBPIhtF9noPcBecpvbFDoBWvhcH9ZGfeS4LHUDAmBTHAbLpbYb4G?= =?us-ascii?Q?lG5ZOVtFCkKkF7pxh/0sPfgijjyr0YzI7ktPUvca7vNAco2ooVsetjhH4Er4?= =?us-ascii?Q?BeTx7H/9tn4/dqZoXtmbCg/ClEuUDx4AsjFR/ulfsLjAS1Y4OYZq773nz6DC?= =?us-ascii?Q?G3rMb1oUDbBtao1XKdfvtYM3scR2fKb3dDYV5BN7C7tPHf3L0M1tsKdc2r+X?= =?us-ascii?Q?NAa4HohZJlKA+VDaJ/NyEAudcu9XmBb67oKogETVM6BeKTiYDtBhyJwCmExR?= =?us-ascii?Q?U/lSSZ5pOa07OoSocfJaYD8yFyxzXMGMoqUhaQmzI29gZVhWSZpwsoZ+06sZ?= =?us-ascii?Q?HaEsC33RtHA=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR12MB9473.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(7416014)(376014)(366016)(1800799024)(7053199007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?idcHfEeV5Zcl+8OCKKAJt0hBreMES5vaDC19Fps//zIn+24oJuGkr+InYqJZ?= =?us-ascii?Q?G1hGL/BxZinfr6XiFACb0GMGqsWo2oH4MvV8iWh2IQcXiw80TndeeZe7Mzi5?= =?us-ascii?Q?OCpO7GWHEvB7mKmTeeCzrtLxygX2ewJCPrMrsNBYK7VHBgS0J/gsMkAqRWVh?= =?us-ascii?Q?RVmrInC/paUBGRNsaoqk2NW4kIFW60a1pHXZmvDArJ7fWHLpQdrWGDfImrZX?= =?us-ascii?Q?zD242ARaGRSAHEu9HEsoK5sURzo5bogY+fNBmvrUo9a4Rxl6eGkJG7AHE9wd?= =?us-ascii?Q?fw9dCYyocuYSDApt19j+oJ+pCOCIwvIvNW0k6KUHnLkr5hKXHghj+EmYw5Tn?= =?us-ascii?Q?Mi/I60eoNHZk5dvf+vsu48fWpKQiKMqeTfhMiUUtGxruNUNa3aWS/eBz7c6U?= =?us-ascii?Q?9TxIXLNpriTpr2GAKNrsv45CxKeXACyVRMNm82tBhFCBjQFKB5nedd1ZbUaE?= =?us-ascii?Q?xDyZ0I2g8j4sWE8ljVV269GMEA9wbA0yA7d5ug+ECfFHLnuulHPDn8rLxq2O?= =?us-ascii?Q?zpaLiOWO42ocmmx9H7BLXTDPKrdCuPBITmko439ZAzQQ/ZeVkJFf+0c18rhB?= =?us-ascii?Q?9GufysXtmj/DcBA9VnK8oB2th3/6CYtcyb6RmWkvZNrcKzN11TckYcLmK2uE?= =?us-ascii?Q?++ZJ2A/AXiKCR7J81kKlwYGPUA/uV18Cf9YYGHcncHgEIzDfINwwm0Dy/54i?= =?us-ascii?Q?bU2fvvjKgP5adsjHacf3DygmlLKq8qtLzbajcsUBQp73adXYwROH0C+d4ap3?= =?us-ascii?Q?pgyCfcuS5EMS8Od5UMSpWnrM8KpS9SrojCV2gAmxUZMkMnlMywOPW+xobcp5?= =?us-ascii?Q?+Y2T5SXGF5vvS/PYIAyKnyF57RvffmFnj9vn/aiwEP0ckunOZDVDcCnVnBcI?= =?us-ascii?Q?oTOGw1vaZQbvubitze5ygz6nqppQsuvCkuBMZXHtcUq1v8SjK74752FwToy6?= =?us-ascii?Q?V/fhQ35u+hOe/oJeQMQCWGi4XcIoy992+Vsuhemb0GYE1ui0gUYYff2WgJI0?= =?us-ascii?Q?hweDaFoXb/B+xkSlhD7U7XLLdL3Tr8+1/EIa2gVpHk/rX9coJ+h7n3GEGAdu?= =?us-ascii?Q?HSUoqiri4YV+jywJYdG1FWBa2BmT9MDkMtmlMIfSvrJyc/8cQ4jeZhdNs0ve?= =?us-ascii?Q?YBZcQMOxJ5Vlj6IhX6GpaB45xEbesoeURra38SDOQKCKFvsUXvh6/LTV3Emi?= =?us-ascii?Q?n1uoq3OtXJIzWcAc1vriDjnUdKD8thxrr1sjEuutVAi8+PRxw9YJ8aiQdq7q?= =?us-ascii?Q?DPISc98tB0n10JDi1B6TslKjbtCG3Lbp4ObhmSA/m17SeLcxQJi29//Doo/P?= =?us-ascii?Q?Ow4PgtBG/H+mvtiCWrQ7A81JL3lA79C0ssXkdc1s0Wz0B1AemVG30z1btcxc?= =?us-ascii?Q?WQG+4a8PjcIEsSbFM1tyjLIL3u07fnqyIlgUDUbkMP3t/mvBf2tPuhrwhGnE?= =?us-ascii?Q?2d7zR44XjAZngO1ytbZycm9K3ZmvARnUV96w/TDdSgYUiURvT3VXQ/lVMeFL?= =?us-ascii?Q?BSrNXvZGqKw1kcODE6dgUtIemfrwJAQ8Ot6Vl3p/nt3+EYgBu2C/lU2GUuoq?= =?us-ascii?Q?+5jQV000mR/CuaRUy6hPGHqmhZtPaorkdeNPFnJP?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 786cb66d-b822-4b6b-6107-08dd9ec472a9 X-MS-Exchange-CrossTenant-AuthSource: DS7PR12MB9473.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 May 2025 15:21:13.2444 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: bESJ+tbjLIZmavcr9mODknolWqwYMgGT8pNBwjHkecAMT7xUxMjnBlYvHUb220Su X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV3PR12MB9354 X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 49652140002 X-Stat-Signature: wjecbp81tjage3intc7ib49fjzef74xg X-Rspam-User: X-HE-Tag: 1748532080-567739 X-HE-Meta: U2FsdGVkX1+RRRWXncA4vBjePAbpC7LD7HOyZ5swVewz9D5Noms2gz1tv5xN5Wgklu1MKB+m58v9Mkch6gM24hY1SMFpy26GYA10C0/A1BstNaTfTzDJ+iANB0Aj6abJQV3VfwaezjQW2uNV5fJitU6YNzDNmPZltXglCuV7m8zTPLM82fLomrQJ+HlTUnWaHwWMV9ptmTkd277bQUOkZ9VC0Joi3P7xgOiVXNuaEQ/rb4jsQ9uC1nZGTV7tUyic4Mt2nNod+ycDc1fFyWJ6lFBQo+wXiIiM/H4DHl6hRnKiepgS20LWBeY1pBy73DW5d7XkUHpa8/3mj4+QYj7/rrPpKXmZPWl9frvblm+zvbAKr44afGS534iXXk+xxOOQpVZcSz9L4PQu3s3C6y6RNC+M9qYQqNI7Xm2wBW50FZ/0CVybmXYzKV+2cqB3LMEw5ATO0r8hjVG/qv7djrwW/CiCX1fRnGhXjP6K2DR1asTCJ7qweeat6Um+sLN/u5YOsdqZxzikVHbABEy4Rx8+BrdCNPg8KRJ/+6O/3AgniCdaB7yLV1JVaT368vn94XPHYaxz2O/ZYpBKAiPmkN6BAo+8vKsF+zY4G4/EFpddQhxa1OTy56yiIf3AmkpJBBZzsBnVeJPzeD679sAQdB4lywKa+N0J/U+BsnkZ7VkpHHsFAVkh2035nmu+7iRKutJPPSanRYU+F9ZJRAksedf9Mzs+rr053Bi7N/IBlEEmRJMpyR8EhI95JrQrTnD3TIIDn3D55ljhBGvimu0FGhdi83BoHcKA3WA23CKNYICa6jWeKu6HvOjnsWphjblTXMHqLSA6NXWO8zFe7EDjCA6r8OshmAq80Xr9EfARJCf9grLLMCPkjI0ZLBEfqY464SMd1kFx4AnHfrkW1M3G7pw/ePaK/cYGVVxl5BTMko0RdokY3inE2vDceUSgaRb95U9uYLXv7eEYDrJ5ZC9NWYa 0mBxNPQG avrD5Q9OwcmqgK8HGWIpN6XIy81TjIGDnlMHNRsNF7l0K7J5N/4Z2BDftir4VtRIW3DtymwepY6SIGH3occ4eD+vGC9/7SmSBrLiG9RUa2v+csIkUB7/fUIuGjK6aoR4qM8jJKZO/O689NIsBG/1OoD29fdB6xualXaj7bIYVvNnQcw+pyapMlDokLYriUW6KHGn9EFUzehYIte4m+2q3OiU1/mRMcjPzHiDe6CrNeUz3qibTD1CZMkLCI7zXK3f53tXuP7EQYP/UjhEp0SDvS1GMu9DUlhbWEbEp5gwtMIGjKy/TErQH/Pj12xl5Z+nE6POXoiRRL8CkrKoAZMMc2X4JFwlSA4+RsbgrAejZT4BVC/9bNak20uhcLneR0ajFsffKbWHXI0XdP1bec+atq6onivOfbw13XKVSPtYplts6Ox5r4pksccL8iQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 29 May 2025, at 4:23, Baolin Wang wrote: > The MADV_COLLAPSE will ignore the system-wide shmem THP sysfs settings,= which > means that even though we have disabled the shmem THP configuration, MA= DV_COLLAPSE > will still attempt to collapse into a shmem THP. This violates the rule= we have > agreed upon: never means never. > > Then the current strategy is: > For shmem, if none of always, madvise, within_size, and inherit have en= abled > PMD-sized mTHP, then MADV_COLLAPSE will be prohibited from collapsing P= MD-sized mTHP. > > For tmpfs, if the mount option is set with the 'huge=3Dnever' parameter= , then > MADV_COLLAPSE will be prohibited from collapsing PMD-sized mTHP. > > Signed-off-by: Baolin Wang > --- > mm/huge_memory.c | 2 +- > mm/shmem.c | 12 ++++++------ > 2 files changed, 7 insertions(+), 7 deletions(-) > > diff --git a/mm/huge_memory.c b/mm/huge_memory.c > index d3e66136e41a..a8cfa37cae72 100644 > --- a/mm/huge_memory.c > +++ b/mm/huge_memory.c > @@ -166,7 +166,7 @@ unsigned long __thp_vma_allowable_orders(struct vm_= area_struct *vma, > * own flags. > */ > if (!in_pf && shmem_file(vma->vm_file)) > - return shmem_allowable_huge_orders(file_inode(vma->vm_file), > + return orders & shmem_allowable_huge_orders(file_inode(vma->vm_file)= , > vma, vma->vm_pgoff, 0, > !enforce_sysfs); OK, here orders is checked against allowed orders. > > diff --git a/mm/shmem.c b/mm/shmem.c > index 4b42419ce6b2..4dbb28d85cd9 100644 > --- a/mm/shmem.c > +++ b/mm/shmem.c > @@ -613,7 +613,7 @@ static unsigned int shmem_get_orders_within_size(st= ruct inode *inode, > } > > static unsigned int shmem_huge_global_enabled(struct inode *inode, pgo= ff_t index, > - loff_t write_end, bool shmem_huge_force, > + loff_t write_end, > struct vm_area_struct *vma, > unsigned long vm_flags) > { > @@ -625,7 +625,7 @@ static unsigned int shmem_huge_global_enabled(struc= t inode *inode, pgoff_t index > return 0; > if (shmem_huge =3D=3D SHMEM_HUGE_DENY) > return 0; > - if (shmem_huge_force || shmem_huge =3D=3D SHMEM_HUGE_FORCE) > + if (shmem_huge =3D=3D SHMEM_HUGE_FORCE) > return maybe_pmd_order; shmem_huge is set by sysfs? > > /* > @@ -860,7 +860,7 @@ static unsigned long shmem_unused_huge_shrink(struc= t shmem_sb_info *sbinfo, > } > > static unsigned int shmem_huge_global_enabled(struct inode *inode, pgo= ff_t index, > - loff_t write_end, bool shmem_huge_force, > + loff_t write_end, > struct vm_area_struct *vma, > unsigned long vm_flags) > { > @@ -1261,7 +1261,7 @@ static int shmem_getattr(struct mnt_idmap *idmap,= > STATX_ATTR_NODUMP); > generic_fillattr(idmap, request_mask, inode, stat); > > - if (shmem_huge_global_enabled(inode, 0, 0, false, NULL, 0)) > + if (shmem_huge_global_enabled(inode, 0, 0, NULL, 0)) > stat->blksize =3D HPAGE_PMD_SIZE; > > if (request_mask & STATX_BTIME) { > @@ -1768,7 +1768,7 @@ unsigned long shmem_allowable_huge_orders(struct = inode *inode, > return 0; > > global_orders =3D shmem_huge_global_enabled(inode, index, write_end, > - shmem_huge_force, vma, vm_flags); > + vma, vm_flags); > /* Tmpfs huge pages allocation */ > if (!vma || !vma_is_anon_shmem(vma)) > return global_orders; > @@ -1790,7 +1790,7 @@ unsigned long shmem_allowable_huge_orders(struct = inode *inode, > /* Allow mTHP that will be fully within i_size. */ > mask |=3D shmem_get_orders_within_size(inode, within_size_orders, ind= ex, 0); > > - if (vm_flags & VM_HUGEPAGE) > + if (shmem_huge_force || (vm_flags & VM_HUGEPAGE)) > mask |=3D READ_ONCE(huge_shmem_orders_madvise); > > if (global_orders > 0) > -- = > 2.43.5 shmem_huge_force comes from !enforce_sysfs in __thp_vma_allowable_orders(= ). Do you know when sysfs is not enforced and why? Best Regards, Yan, Zi