From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail144.messagelabs.com (mail144.messagelabs.com [216.82.254.51]) by kanga.kvack.org (Postfix) with ESMTP id 5A6C98D003B for ; Thu, 21 Apr 2011 21:01:13 -0400 (EDT) Received: by iwg8 with SMTP id 8so267573iwg.14 for ; Thu, 21 Apr 2011 18:01:11 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <20110421160057.GA28712@suse.de> References: <20110415101248.GB22688@suse.de> <20110421110841.GA612@suse.de> <20110421142636.GA1835@barrios-desktop> <20110421160057.GA28712@suse.de> Date: Fri, 22 Apr 2011 10:01:11 +0900 Message-ID: Subject: Re: [PATCH] mm: Check if PTE is already allocated during page fault From: Minchan Kim Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Sender: owner-linux-mm@kvack.org List-ID: To: Mel Gorman Cc: akpm@linux-foundation.org, Andrea Arcangeli , raz ben yehuda , riel@redhat.com, kosaki.motohiro@jp.fujitsu.com, lkml , linux-mm@kvack.org, stable@kernel.org On Fri, Apr 22, 2011 at 1:00 AM, Mel Gorman wrote: > On Thu, Apr 21, 2011 at 11:26:36PM +0900, Minchan Kim wrote: >> On Thu, Apr 21, 2011 at 12:08:41PM +0100, Mel Gorman wrote: >> > On Thu, Apr 21, 2011 at 03:59:47PM +0900, Minchan Kim wrote: >> > > Hi Mel, >> > > >> > > On Fri, Apr 15, 2011 at 7:12 PM, Mel Gorman wrote: >> > > > With transparent hugepage support, handle_mm_fault() has to be car= eful >> > > > that a normal PMD has been established before handling a PTE fault= . To >> > > > achieve this, it used __pte_alloc() directly instead of pte_alloc_= map >> > > > as pte_alloc_map is unsafe to run against a huge PMD. pte_offset_m= ap() >> > > > is called once it is known the PMD is safe. >> > > > >> > > > pte_alloc_map() is smart enough to check if a PTE is already prese= nt >> > > > before calling __pte_alloc but this check was lost. As a consequen= ce, >> > > > PTEs may be allocated unnecessarily and the page table lock taken. >> > > > Thi useless PTE does get cleaned up but it's a performance hit whi= ch >> > > > is visible in page_test from aim9. >> > > > >> > > > This patch simply re-adds the check normally done by pte_alloc_map= to >> > > > check if the PTE needs to be allocated before taking the page tabl= e >> > > > lock. The effect is noticable in page_test from aim9. >> > > > >> > > > AIM9 >> > > > =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A02.6.38-vani= lla 2.6.38-checkptenone >> > > > creat-clo =C2=A0 =C2=A0 =C2=A0446.10 ( 0.00%) =C2=A0 424.47 (-5.10= %) >> > > > page_test =C2=A0 =C2=A0 =C2=A0 38.10 ( 0.00%) =C2=A0 =C2=A042.04 (= 9.37%) >> > > > brk_test =C2=A0 =C2=A0 =C2=A0 =C2=A052.45 ( 0.00%) =C2=A0 =C2=A051= .57 (-1.71%) >> > > > exec_test =C2=A0 =C2=A0 =C2=A0382.00 ( 0.00%) =C2=A0 456.90 (16.39= %) >> > > > fork_test =C2=A0 =C2=A0 =C2=A0 60.11 ( 0.00%) =C2=A0 =C2=A067.79 (= 11.34%) >> > > > MMTests Statistics: duration >> > > > Total Elapsed Time (seconds) =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0611.90 =C2=A0 =C2=A0612.22 >> > > > >> > > > (While this affects 2.6.38, it is a performance rather than a >> > > > functional bug and normally outside the rules -stable. While the b= ig >> > > > performance differences are to a microbench, the difference in for= k >> > > > and exec performance may be significant enough that -stable wants = to >> > > > consider the patch) >> > > > >> > > > Reported-by: Raz Ben Yehuda >> > > > Signed-off-by: Mel Gorman >> > > > -- >> > > > =C2=A0mm/memory.c | =C2=A0 =C2=A02 +- >> > > > =C2=A01 file changed, 1 insertion(+), 1 deletion(-) >> > > > >> > > > diff --git a/mm/memory.c b/mm/memory.c >> > > > index 5823698..1659574 100644 >> > > > --- a/mm/memory.c >> > > > +++ b/mm/memory.c >> > > > @@ -3322,7 +3322,7 @@ int handle_mm_fault(struct mm_struct *mm, st= ruct vm_area_struct *vma, >> > > > =C2=A0 =C2=A0 =C2=A0 =C2=A0 * run pte_offset_map on the pmd, if an= huge pmd could >> > > > =C2=A0 =C2=A0 =C2=A0 =C2=A0 * materialize from under us from a dif= ferent thread. >> > > > =C2=A0 =C2=A0 =C2=A0 =C2=A0 */ >> > > > - =C2=A0 =C2=A0 =C2=A0 if (unlikely(__pte_alloc(mm, vma, pmd, addr= ess))) >> > > > + =C2=A0 =C2=A0 =C2=A0 if (unlikely(pmd_none(*pmd)) && __pte_alloc= (mm, vma, pmd, address)) >> > > > =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0return VM_F= AULT_OOM; >> > > > =C2=A0 =C2=A0 =C2=A0 =C2=A0/* if an huge pmd materialized from und= er us just retry later */ >> > > > =C2=A0 =C2=A0 =C2=A0 =C2=A0if (unlikely(pmd_trans_huge(*pmd))) >> > > > >> > > >> > > Reviewed-by: Minchan Kim >> > > >> > > Sorry for jumping in too late. I have a just nitpick. >> > > >> > >> > Better late than never :) >> > >> > > We have another place, do_huge_pmd_anonymous_page. >> > > Although it isn't workload of page_test, is it valuable to expand yo= ur >> > > patch to cover it? >> > > If there is workload there are many thread and share one shared anon >> > > vma in ALWAYS THP mode, same problem would happen. >> > >> > We already checked pmd_none() in handle_mm_fault() before calling >> > into do_huge_pmd_anonymous_page(). We could race for the fault while >> > attempting to allocate a huge page but it wouldn't be as severe a >> > problem particularly as it is encountered after failing a 2M allocatio= n. >> >> Right you are. Fail ot 2M allocation would affect as throttle. >> Thanks. >> >> As I failed let you add the check, I have to reveal my mind. :) >> Actually, what I want is consistency of the code. > > This is a stronger arguement than as a performance fix. I was concerned > that if such a check was added that it would confuse someone in a years > time trying to figure out why the pmd_none check was really necessary. > >> The code have been same in two places but you find the problem in page_t= est of aim9, >> you changed one of them slightly. I think in future someone will >> have a question about that and he will start grep git log but it will ta= ke >> a long time as the log is buried other code piled up. >> > > Fair point. > >> I hope adding the comment in this case. >> >> =C2=A0 =C2=A0 =C2=A0 =C2=A0 /* >> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0* PTEs may be allocated unnecessarily = and the page table lock taken. >> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0* The useless PTE does get cleaned up = but it's a performance hit in >> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0* some micro-benchmark. Let's check pm= d_none before __pte_alloc to >> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0* reduce the overhead. >> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0*/ >> - =C2=A0 =C2=A0 =C2=A0 if (unlikely(__pte_alloc(mm, vma, pmd, address))) >> + =C2=A0 =C2=A0 =C2=A0 if (unlikely(pmd_none(*pmd)) && __pte_alloc(mm, v= ma, pmd, address)) >> > > I think a better justification is > > =C2=A0 =C2=A0 =C2=A0 =C2=A0/* > =C2=A0 =C2=A0 =C2=A0 =C2=A0 * Even though handle_mm_fault has already che= cked pmd_none, we > =C2=A0 =C2=A0 =C2=A0 =C2=A0 * have failed a huge allocation at this point= during which a > =C2=A0 =C2=A0 =C2=A0 =C2=A0 * valid PTE could have been inserted. Double = check a PTE alloc > =C2=A0 =C2=A0 =C2=A0 =C2=A0 * is still necessary to avoid additional over= head > =C2=A0 =C2=A0 =C2=A0 =C2=A0 */ > Hmm. If we disable thp, the comment about failing a huge allocation. was not true. So I prefer mine :) But Andrea suggested defining new pte_alloc which checks pmd_none internally for code consistency POV. In such case, I have no concern about comment. Is it okay? >> If you mind it as someone who have a question can find the log at last >> although he need some time, I wouldn't care of the nitpick any more. :) >> It's up to you. >> > > If you want to create a new patch with either your comment or mine > (whichever you prefer) I'll add my ack. I'm about to drop offline > for a few days but if it's still there Tuesday, I'll put together an > appropriate patch and submit. I'd keep it separate from the other patch > because it's a performance fix (which I'd like to see in -stable) where > as this is more of a cleanup IMO. Okay. Thanks, Mel. --=20 Kind regards, Minchan Kim -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org