From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail6.bemta7.messagelabs.com (mail6.bemta7.messagelabs.com [216.82.255.55]) by kanga.kvack.org (Postfix) with ESMTP id ACFB790010B for ; Mon, 16 May 2011 20:05:24 -0400 (EDT) Received: from wpaz37.hot.corp.google.com (wpaz37.hot.corp.google.com [172.24.198.101]) by smtp-out.google.com with ESMTP id p4H059fc029841 for ; Mon, 16 May 2011 17:05:09 -0700 Received: from qyk36 (qyk36.prod.google.com [10.241.83.164]) by wpaz37.hot.corp.google.com with ESMTP id p4H04YXj007672 (version=TLSv1/SSLv3 cipher=RC4-SHA bits=128 verify=NOT) for ; Mon, 16 May 2011 17:05:08 -0700 Received: by qyk36 with SMTP id 36so2532737qyk.18 for ; Mon, 16 May 2011 17:05:02 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <20110516231512.GW16531@cmpxchg.org> References: <1305583230-2111-1-git-send-email-yinghan@google.com> <20110516231512.GW16531@cmpxchg.org> Date: Mon, 16 May 2011 17:05:02 -0700 Message-ID: Subject: Re: [PATCH] memcg: fix typo in the soft_limit stats. From: Ying Han Content-Type: multipart/alternative; boundary=0016360e3f5c0dfb7404a36d8659 Sender: owner-linux-mm@kvack.org List-ID: To: Johannes Weiner Cc: KOSAKI Motohiro , Minchan Kim , Daisuke Nishimura , Balbir Singh , Tejun Heo , Pavel Emelyanov , KAMEZAWA Hiroyuki , Andrew Morton , Li Zefan , Mel Gorman , Christoph Lameter , Rik van Riel , Hugh Dickins , Michal Hocko , Dave Hansen , Zhu Yanhai , linux-mm@kvack.org --0016360e3f5c0dfb7404a36d8659 Content-Type: text/plain; charset=ISO-8859-1 On Mon, May 16, 2011 at 4:15 PM, Johannes Weiner wrote: > On Mon, May 16, 2011 at 03:00:30PM -0700, Ying Han wrote: > > This fixes the typo in the memory.stat including the following two > > stats: > > > > $ cat /dev/cgroup/memory/A/memory.stat > > total_soft_steal 0 > > total_soft_scan 0 > > > > And change it to: > > > > $ cat /dev/cgroup/memory/A/memory.stat > > total_soft_kswapd_steal 0 > > total_soft_kswapd_scan 0 > > > > Signed-off-by: Ying Han > > I am currently proposing and working on a scheme that makes the soft > limit not only a factor for global memory pressure, but for > hierarchical reclaim in general, to prefer child memcgs during reclaim > that are in excess of their soft limit. > > Because this means prioritizing memcgs over one another, rather than > having explicit soft limit reclaim runs, there is no natural counter > for pages reclaimed due to the soft limit anymore. > > Thus, for the patch that introduces this counter: > > Nacked-by: Johannes Weiner > This patch is fixing a typo of the stats being integrated into mmotm. Does it make sense to fix the existing stats first while we are discussing other approaches? --Ying --0016360e3f5c0dfb7404a36d8659 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable

On Mon, May 16, 2011 at 4:15 PM, Johanne= s Weiner <hannes= @cmpxchg.org> wrote:
On Mon, May 16, 2011 at 03:00:30PM -0700, Ying Han wrote:=
> This fixes the typo in the memory.stat including the following two
> stats:
>
> $ cat /dev/cgroup/memory/A/memory.stat
> total_soft_steal 0
> total_soft_scan 0
>
> And change it to:
>
> $ cat /dev/cgroup/memory/A/memory.stat
> total_soft_kswapd_steal 0
> total_soft_kswapd_scan 0
>
> Signed-off-by: Ying Han <ying= han@google.com>

I am currently proposing and working on a scheme that makes the soft<= br> limit not only a factor for global memory pressure, but for
hierarchical reclaim in general, to prefer child memcgs during reclaim
that are in excess of their soft limit.

Because this means prioritizing memcgs over one another, rather than
having explicit soft limit reclaim runs, there is no natural counter
for pages reclaimed due to the soft limit anymore.

Thus, for the patch that introduces this counter:

Nacked-by: Johannes Weiner <hannes= @cmpxchg.org>

This patch is fixi= ng a typo of the stats being integrated into mmotm. Does it make sense to f= ix the
existing stats first while we are discussing other=A0approaches?
=

--Ying
=A0

--0016360e3f5c0dfb7404a36d8659-- -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org