From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail143.messagelabs.com (mail143.messagelabs.com [216.82.254.35]) by kanga.kvack.org (Postfix) with ESMTP id 9C6178D003B for ; Fri, 22 Apr 2011 02:00:24 -0400 (EDT) Received: from kpbe15.cbf.corp.google.com (kpbe15.cbf.corp.google.com [172.25.105.79]) by smtp-out.google.com with ESMTP id p3M60MuT024160 for ; Thu, 21 Apr 2011 23:00:22 -0700 Received: from qyk7 (qyk7.prod.google.com [10.241.83.135]) by kpbe15.cbf.corp.google.com with ESMTP id p3M603wV004196 (version=TLSv1/SSLv3 cipher=RC4-SHA bits=128 verify=NOT) for ; Thu, 21 Apr 2011 23:00:21 -0700 Received: by qyk7 with SMTP id 7so216252qyk.17 for ; Thu, 21 Apr 2011 23:00:21 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <20110422142734.FA69.A69D9226@jp.fujitsu.com> References: <1303446260-21333-1-git-send-email-yinghan@google.com> <1303446260-21333-6-git-send-email-yinghan@google.com> <20110422142734.FA69.A69D9226@jp.fujitsu.com> Date: Thu, 21 Apr 2011 23:00:20 -0700 Message-ID: Subject: Re: [PATCH V7 5/9] Infrastructure to support per-memcg reclaim. From: Ying Han Content-Type: multipart/alternative; boundary=000e0ce008bcae9a9604a17b9272 Sender: owner-linux-mm@kvack.org List-ID: To: KOSAKI Motohiro Cc: Minchan Kim , Daisuke Nishimura , Balbir Singh , Tejun Heo , Pavel Emelyanov , KAMEZAWA Hiroyuki , Andrew Morton , Li Zefan , Mel Gorman , Christoph Lameter , Johannes Weiner , Rik van Riel , Hugh Dickins , Michal Hocko , Dave Hansen , Zhu Yanhai , linux-mm@kvack.org --000e0ce008bcae9a9604a17b9272 Content-Type: text/plain; charset=ISO-8859-1 On Thu, Apr 21, 2011 at 10:27 PM, KOSAKI Motohiro < kosaki.motohiro@jp.fujitsu.com> wrote: > > +static unsigned long shrink_mem_cgroup(struct mem_cgroup *mem_cont, int > order) > > +{ > > + return 0; > > +} > > this one and > > > @@ -2672,36 +2686,48 @@ int kswapd(void *p) > (snip) > > /* > > * We can speed up thawing tasks if we don't call > balance_pgdat > > * after returning from the refrigerator > > */ > > - if (!ret) { > > + if (is_global_kswapd(kswapd_p)) { > > trace_mm_vmscan_kswapd_wake(pgdat->node_id, order); > > order = balance_pgdat(pgdat, order, > &classzone_idx); > > + } else { > > + mem = mem_cgroup_get_shrink_target(); > > + if (mem) > > + shrink_mem_cgroup(mem, order); > > + mem_cgroup_put_shrink_target(mem); > > } > > } > > this one shold be placed in "[7/9] Per-memcg background reclaim". isn't it? > This is the infrastructure, and the shrink_mem_cgroup() is a noop. The [7/9] is the actual implementation. --Ying --000e0ce008bcae9a9604a17b9272 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable

On Thu, Apr 21, 2011 at 10:27 PM, KOSAKI= Motohiro <kosaki.motohiro@jp.fujitsu.com> wrote:
> +static unsigned long shrink_mem_cgroup(struct mem_c= group *mem_cont, int order)
> +{
> + =A0 =A0 return 0;
> +}

this one and

> @@ -2672,36 +2686,48 @@ int kswapd(void *p)
(snip)
> =A0 =A0 =A0 =A0 =A0 =A0 =A0 /*
> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0* We can speed up thawing tasks if we d= on't call balance_pgdat
> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0* after returning from the refrigerator=
> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0*/
> - =A0 =A0 =A0 =A0 =A0 =A0 if (!ret) {
> + =A0 =A0 =A0 =A0 =A0 =A0 if (is_global_kswapd(kswapd_p)) {
> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 trace_mm_vmscan_kswapd_wak= e(pgdat->node_id, order);
> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 order =3D balance_pgdat(pg= dat, order, &classzone_idx);
> + =A0 =A0 =A0 =A0 =A0 =A0 } else {
> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 mem =3D mem_cgroup_get_shrin= k_target();
> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 if (mem)
> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 shrink_mem_c= group(mem, order);
> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 mem_cgroup_put_shrink_target= (mem);
> =A0 =A0 =A0 =A0 =A0 =A0 =A0 }
> =A0 =A0 =A0 }

this one shold be placed in "[7/9] Per-memcg background reclaim&= quot;. isn't it?

This is the infras= tructure, and the shrink_mem_cgroup() is a noop. The [7/9] is the actual im= plementation.

--Ying=A0

--000e0ce008bcae9a9604a17b9272-- -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org