On Tue, Apr 19, 2011 at 5:54 PM, KOSAKI Motohiro <
kosaki.motohiro@jp.fujitsu.com> wrote:

> > On Tue, Apr 19, 2011 at 5:20 PM, KOSAKI Motohiro <
> > kosaki.motohiro@jp.fujitsu.com> wrote:
> >
> > > > This patch changes the shrink_slab and shrinker APIs by consolidating
> > > existing
> > > > parameters into scan_control struct. This simplifies any further
> attempts
> > > to
> > > > pass extra info to the shrinker. Instead of modifying all the
> shrinker
> > > files
> > > > each time, we just need to extend the scan_control struct.
> > > >
> > >
> > > Ugh. No, please no.
> > > Current scan_control has a lot of vmscan internal information. Please
> > > export only you need one, not all.
> > >
> > > Otherwise, we can't change any vmscan code while any shrinker are using
> it.
> > >
> >
> > So, are you suggesting maybe add another struct for this purpose?
>
> Yes. And please explain which member do you need.
>

For now, I added the "nr_slab_to_reclaim" and also consolidate the
gfp_mask. More importantly this makes any further change (pass stuff from
reclaim to the shrinkers) easier w/o modifying each file of the shrinker.

So make it into a new struct sounds reasonable to me. How about something
called "slab_control".

--Ying