linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Linus Torvalds <torvalds@linux-foundation.org>
To: "Bruno Prémont" <bonbons@linux-vserver.org>
Cc: Mike Frysinger <vapier.adi@gmail.com>,
	KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	linux-fsdevel@vger.kernel.org,
	"Paul E. McKenney" <paul.mckenney@linaro.org>,
	Pekka Enberg <penberg@kernel.org>
Subject: Re: 2.6.39-rc4+: Kernel leaking memory during FS scanning, regression?
Date: Mon, 25 Apr 2011 09:31:03 -0700	[thread overview]
Message-ID: <BANLkTikSLA59tdgRL4B=cr5tvP2NbzZ=KA@mail.gmail.com> (raw)
In-Reply-To: <20110425180450.1ede0845@neptune.home>

2011/4/25 Bruno Prémont <bonbons@linux-vserver.org>:
>
> kmemleak reports 86681 new leaks between shortly after boot and -2 state.
> (and 2348 additional ones between -2 and -4).

I wouldn't necessarily trust kmemleak with the whole RCU-freeing
thing. In your slubinfo reports, the kmemleak data itself also tends
to overwhelm everything else - none of it looks unreasonable per se.

That said, you clearly have a *lot* of filp entries. I wouldn't
consider it unreasonable, though, because depending on load those may
well be fine. Perhaps you really do have some application(s) that hold
thousands of files open. The default file limit is 1024 (I think), but
you can raise it, and some programs do end up opening tens of
thousands of files for filesystem scanning purposes.

That said, I would suggest simply trying a saner kernel configuration,
and seeing if that makes a difference:

> Yes, it's uni-processor system, so SMP=n.
> TINY_RCU=y, PREEMPT_VOLUNTARY=y (whole /proc/config.gz attached keeping
> compression)

I'm not at all certain that TINY_RCU is appropriate for
general-purpose loads. I'd call it more of a "embedded low-performance
option".

The _real_ RCU implementation ("tree rcu") forces quiescent states
every few jiffies and has logic to handle "I've got tons of RCU
events, I really need to start handling them now". All of which I
think tiny-rcu lacks.

So right now I suspect that you have a situation where you just have a
simple load that just ends up never triggering any RCU cleanup, and
the tiny-rcu thing just keeps on gathering events and delays freeing
stuff almost arbitrarily long.

So try CONFIG_PREEMPT and CONFIG_TREE_PREEMPT_RCU to see if the
behavior goes away. That would confirm the "it's just tinyrcu being
too dang stupid" hypothesis.

                     Linus

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2011-04-25 16:31 UTC|newest]

Thread overview: 88+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-24 18:21 Bruno Prémont
2011-04-24 21:59 ` Bruno Prémont
2011-04-25  2:42   ` KOSAKI Motohiro
2011-04-25  7:47     ` Mike Frysinger
2011-04-25  9:17       ` Bruno Prémont
2011-04-25  9:25         ` Pekka Enberg
2011-04-25 10:34           ` Bruno Prémont
2011-04-25 11:41             ` Bruno Prémont
2011-04-25 11:47               ` Pekka Enberg
2011-04-25 12:11                 ` Bruno Prémont
2011-04-25 12:14                 ` Tetsuo Handa
2011-04-25 12:21                   ` Tetsuo Handa
2011-04-25 15:22         ` Linus Torvalds
2011-04-25 16:04           ` Bruno Prémont
2011-04-25 16:31             ` Linus Torvalds [this message]
2011-04-25 17:00               ` Bruno Prémont
2011-04-25 17:10                 ` Linus Torvalds
2011-04-25 17:20                   ` Linus Torvalds
2011-04-25 18:36                   ` Bruno Prémont
2011-04-25 19:16                     ` Paul E. McKenney
2011-04-25 21:10                       ` Bruno Prémont
2011-04-25 21:26                         ` Paul E. McKenney
2011-04-25 21:30                         ` Linus Torvalds
2011-04-25 21:49                           ` Paul E. McKenney
2011-04-26  6:19                             ` Bruno Prémont
2011-04-26 11:27                               ` Paul E. McKenney
2011-04-26 16:38                                 ` Bruno Prémont
2011-04-26 17:09                                   ` Bruno Prémont
2011-04-26 17:18                                     ` Linus Torvalds
2011-04-26 22:28                                       ` Thomas Gleixner
2011-04-27  6:15                                         ` Bruno Prémont
2011-04-27 18:41                                           ` Bruno Prémont
2011-04-27 19:16                                             ` Pádraig Brady
2011-04-27 19:34                                               ` Bruno Prémont
2011-04-27 22:05                                                 ` Paul E. McKenney
2011-04-27 20:40                                             ` Bruno Prémont
2011-04-27 22:07                                               ` Paul E. McKenney
2011-04-28  6:10                                                 ` Bruno Prémont
2011-04-27 22:06                                             ` Thomas Gleixner
2011-04-27 22:27                                               ` Paul E. McKenney
2011-04-27 22:32                                                 ` Thomas Gleixner
2011-04-27 22:59                                                   ` Paul E. McKenney
2011-04-27 23:28                                                   ` Linus Torvalds
2011-04-27 23:46                                                     ` Linus Torvalds
2011-04-28  9:09                                               ` Thomas Gleixner
2011-04-28  9:17                                                 ` Sedat Dilek
2011-04-28  9:40                                                   ` Thomas Gleixner
2011-04-28 10:12                                                     ` Mike Galbraith
2011-04-28  9:45                                                 ` Sedat Dilek
2011-04-28 10:26                                                   ` Paul E. McKenney
2011-04-28 13:30                                                     ` Mike Galbraith
2011-04-28 15:28                                                       ` Sedat Dilek
2011-04-28 15:44                                                         ` Sedat Dilek
2011-04-28 15:48                                                         ` Linus Torvalds
2011-04-28 18:49                                                         ` Thomas Gleixner
2011-04-28 20:23                                                           ` Bruno Prémont
2011-04-28 20:29                                                             ` Thomas Gleixner
2011-04-28 20:44                                                               ` Bruno Prémont
2011-04-28 21:04                                                                 ` Thomas Gleixner
2011-04-28 21:51                                                                   ` john stultz
2011-04-28 22:02                                                                     ` Thomas Gleixner
2011-04-28 23:06                                                                       ` Sedat Dilek
2011-04-28 23:35                                                                         ` Sedat Dilek
2011-04-29  0:42                                                                           ` Paul E. McKenney
2011-04-29  9:34                                                                             ` Thomas Gleixner
2011-04-29  7:55                                                                       ` Sedat Dilek
2011-04-29 18:09                                                                       ` Mike Frysinger
2011-04-29 18:26                                                                         ` Thomas Gleixner
2011-04-29 19:31                                                                       ` Bruno Prémont
2011-04-29 20:10                                                                         ` Thomas Gleixner
2011-04-29 20:14                                                                           ` Bruno Prémont
2011-04-30  9:14                                                                             ` Sedat Dilek
2011-04-28 20:41                                                           ` Sedat Dilek
2011-04-28 19:22                                                         ` Mike Galbraith
2011-04-27 21:55                                         ` Paul E. McKenney
2011-04-28  6:22                                           ` Bruno Prémont
2011-04-28 10:26                                             ` Paul E. McKenney
2011-04-26 17:12                                   ` Linus Torvalds
2011-04-26 18:50                                     ` Paul E. McKenney
2011-04-26 19:17                                       ` Sedat Dilek
2011-04-27 22:02                                         ` Paul E. McKenney
2011-04-25 22:08                         ` Mike Frysinger
2011-04-25 17:29                 ` Paul E. McKenney
2011-04-25 18:13                   ` Sedat Dilek
2011-04-25 18:28                     ` Paul E. McKenney
2011-04-25 17:26               ` Paul E. McKenney
2011-04-27 10:28               ` Catalin Marinas
2011-04-25 17:51           ` Pekka Enberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='BANLkTikSLA59tdgRL4B=cr5tvP2NbzZ=KA@mail.gmail.com' \
    --to=torvalds@linux-foundation.org \
    --cc=bonbons@linux-vserver.org \
    --cc=kosaki.motohiro@jp.fujitsu.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=paul.mckenney@linaro.org \
    --cc=penberg@kernel.org \
    --cc=vapier.adi@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox