From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail172.messagelabs.com (mail172.messagelabs.com [216.82.254.3]) by kanga.kvack.org (Postfix) with ESMTP id 1B154900001 for ; Thu, 12 May 2011 14:53:44 -0400 (EDT) Received: from kpbe17.cbf.corp.google.com (kpbe17.cbf.corp.google.com [172.25.105.81]) by smtp-out.google.com with ESMTP id p4CIreYc015955 for ; Thu, 12 May 2011 11:53:40 -0700 Received: from qyk10 (qyk10.prod.google.com [10.241.83.138]) by kpbe17.cbf.corp.google.com with ESMTP id p4CIrcZ6014783 (version=TLSv1/SSLv3 cipher=RC4-SHA bits=128 verify=NOT) for ; Thu, 12 May 2011 11:53:38 -0700 Received: by qyk10 with SMTP id 10so1112689qyk.4 for ; Thu, 12 May 2011 11:53:38 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <1305212038-15445-1-git-send-email-hannes@cmpxchg.org> References: <1305212038-15445-1-git-send-email-hannes@cmpxchg.org> Date: Thu, 12 May 2011 11:53:37 -0700 Message-ID: Subject: Re: [rfc patch 0/6] mm: memcg naturalization From: Ying Han Content-Type: multipart/alternative; boundary=0016e64aefdafd6ae304a318b4e6 Sender: owner-linux-mm@kvack.org List-ID: To: Johannes Weiner Cc: KAMEZAWA Hiroyuki , Daisuke Nishimura , Balbir Singh , Michal Hocko , Andrew Morton , Rik van Riel , Minchan Kim , KOSAKI Motohiro , Mel Gorman , linux-mm@kvack.org, linux-kernel@vger.kernel.org --0016e64aefdafd6ae304a318b4e6 Content-Type: text/plain; charset=ISO-8859-1 On Thu, May 12, 2011 at 7:53 AM, Johannes Weiner wrote: > Hi! > > Here is a patch series that is a result of the memcg discussions on > LSF (memcg-aware global reclaim, global lru removal, struct > page_cgroup reduction, soft limit implementation) and the recent > feature discussions on linux-mm. > > The long-term idea is to have memcgs no longer bolted to the side of > the mm code, but integrate it as much as possible such that there is a > native understanding of containers, and that the traditional !memcg > setup is just a singular group. This series is an approach in that > direction. > > It is a rather early snapshot, WIP, barely tested etc., but I wanted > to get your opinions before further pursuing it. It is also part of > my counter-argument to the proposals of adding memcg-reclaim-related > user interfaces at this point in time, so I wanted to push this out > the door before things are merged into .40. > The memcg-reclaim-related user interface I assume was the watermark configurable tunable we were talking about in the per-memcg background reclaim patch. I think we got some agreement to remove the watermark tunable at the first step. But the newly added memory.soft_limit_async_reclaim as you proposed seems to be a usable interface. > > The patches are quite big, I am still looking for things to factor and > split out, sorry for this. Documentation is on its way as well ;) > This is a quite bit patchset includes different part. We might want to split it into steps. I will read them through now. --Ying > > #1 and #2 are boring preparational work. #3 makes traditional reclaim > in vmscan.c memcg-aware, which is a prerequisite for both removal of > the global lru in #5 and the way I reimplemented soft limit reclaim in > #6. > > The diffstat so far looks like this: > > include/linux/memcontrol.h | 84 +++-- > include/linux/mm_inline.h | 15 +- > include/linux/mmzone.h | 10 +- > include/linux/page_cgroup.h | 35 -- > include/linux/swap.h | 4 - > mm/memcontrol.c | 860 > +++++++++++++------------------------------ > mm/page_alloc.c | 2 +- > mm/page_cgroup.c | 39 +-- > mm/swap.c | 20 +- > mm/vmscan.c | 273 +++++++-------- > 10 files changed, 452 insertions(+), 890 deletions(-) > > It is based on .39-rc7 because of the memcg churn in -mm, but I'll > rebase it in the near future. > > Discuss! > > Hannes > --0016e64aefdafd6ae304a318b4e6 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable

On Thu, May 12, 2011 at 7:53 AM, Johanne= s Weiner <hannes= @cmpxchg.org> wrote:
Hi!

Here is a patch series that is a result of the memcg discussions on
LSF (memcg-aware global reclaim, global lru removal, struct
page_cgroup reduction, soft limit implementation) and the recent
feature discussions on linux-mm.

The long-term idea is to have memcgs no longer bolted to the side of
the mm code, but integrate it as much as possible such that there is a
native understanding of containers, and that the traditional !memcg
setup is just a singular group. =A0This series is an approach in that
direction.

It is a rather early snapshot, WIP, barely tested etc., but I wanted
to get your opinions before further pursuing it. =A0It is also part of
my counter-argument to the proposals of adding memcg-reclaim-related
user interfaces at this point in time, so I wanted to push this out
the door before things are merged into .40.

=
The memcg-reclaim-related user interface I assume was the watermark co= nfigurable tunable
we were talking about in the per-memcg backgro= und reclaim patch. I think we got some agreement
to remove the watermark tunable at the first step. But the newly added= memory.soft_limit_async_reclaim
as you proposed seems to be a us= able interface.
=A0

The patches are quite big, I am still looking for things to factor and
split out, sorry for this. =A0Documentation is on its way as well ;)

This is a quite bit patchset includes differe= nt part. We might want to split it into steps. I will read them through
now.

--Ying=A0

#1 and #2 are boring preparational work. =A0#3 makes traditional reclaim in vmscan.c memcg-aware, which is a prerequisite for both removal of
the global lru in #5 and the way I reimplemented soft limit reclaim in
#6.

The diffstat so far looks like this:

=A0include/linux/memcontrol.h =A0| =A0 84 +++--
=A0include/linux/mm_inline.h =A0 | =A0 15 +-
=A0include/linux/mmzone.h =A0 =A0 =A0| =A0 10 +-
=A0include/linux/page_cgroup.h | =A0 35 --
=A0include/linux/swap.h =A0 =A0 =A0 =A0| =A0 =A04 -
=A0mm/memcontrol.c =A0 =A0 =A0 =A0 =A0 =A0 | =A0860 +++++++++++++----------= --------------------
=A0mm/page_alloc.c =A0 =A0 =A0 =A0 =A0 =A0 | =A0 =A02 +-
=A0mm/page_cgroup.c =A0 =A0 =A0 =A0 =A0 =A0| =A0 39 +--
=A0mm/swap.c =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 | =A0 20 +-
=A0mm/vmscan.c =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 | =A0273 +++++++--------
=A010 files changed, 452 insertions(+), 890 deletions(-)

It is based on .39-rc7 because of the memcg churn in -mm, but I'll
rebase it in the near future.

Discuss!

=A0 =A0 =A0 =A0Hannes

--0016e64aefdafd6ae304a318b4e6-- -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org