Re: [PATCH 00/12] IO-less dirty throttling v7

[Sedat Dilek <sedat.dilek@googlemail.com>]

[-- Attachment #1: Type: text/plain, Size: 1895 bytes --]

On Sun, Apr 17, 2011 at 3:44 AM, Wu Fengguang <fengguang.wu@intel.com> wrote:
> Hi Sedat,
>
> On Sun, Apr 17, 2011 at 12:27:58AM +0800, Sedat Dilek wrote:
>
>> I pulled your tree into linux-next (next-20110415) on an i386 Debian host.
>>
>> My build breaks here:
>> ...
>>   MODPOST vmlinux.o
>>   GEN     .version
>>   CHK     include/generated/compile.h
>>   UPD     include/generated/compile.h
>>   CC      init/version.o
>>   LD      init/built-in.o
>>   LD      .tmp_vmlinux1
>> mm/built-in.o: In function `bdi_position_ratio':
>> page-writeback.c:(.text+0x5c83): undefined reference to `__udivdi3'
>
> Yes it can be fixed by the attached patch.
>
>> mm/built-in.o: In function `calc_period_shift.part.10':
>> page-writeback.c:(.text+0x6446): undefined reference to `____ilog2_NaN'
>
> I cannot reproduce this error. In the git tree, calc_period_shift() is
> actually quite simple:
>
> static int calc_period_shift(void)
> {
>        return 2 + ilog2(default_backing_dev_info.avg_write_bandwidth);
> }
>
> where avg_write_bandwidth is of type "unsigned long".
>
>> make[4]: *** [.tmp_vmlinux1] Error
>>
>> BTW, which kernel-config options have to be set besides
>> CONFIG_BLK_DEV_THROTTLING=y?
>
> No. I used your kconfig on 2.6.39-rc3 and it compiles OK for i386.
>
> I've pushed two patches into the git tree fixing the compile errors.
> Thank you for trying it out and report!
>
> Thanks,
> Fengguang
>

Thanks for your patch.

The 1st part of the build-error is gone, but 2nd part still remains:

  LD      .tmp_vmlinux1
mm/built-in.o: In function `calc_period_shift.part.10':
page-writeback.c:(.text+0x6458): undefined reference to `____ilog2_NaN'
make[4]: *** [.tmp_vmlinux1] Error 1

I have attached some disasm-ed files.

Unfortunately, I don't see any new commits in your GIT tree.

- Sedat -

[-- Attachment #2: mm_built-in.o.disasm.xz --]
[-- Type: application/octet-stream, Size: 442676 bytes --]

[-- Attachment #3: mm_page-writeback.o.disasm.xz --]
[-- Type: application/octet-stream, Size: 20252 bytes --]