From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail137.messagelabs.com (mail137.messagelabs.com [216.82.249.19]) by kanga.kvack.org (Postfix) with ESMTP id 009626B0011 for ; Thu, 5 May 2011 00:26:20 -0400 (EDT) Received: from kpbe16.cbf.corp.google.com (kpbe16.cbf.corp.google.com [172.25.105.80]) by smtp-out.google.com with ESMTP id p454QGll030934 for ; Wed, 4 May 2011 21:26:17 -0700 Received: from qwk3 (qwk3.prod.google.com [10.241.195.131]) by kpbe16.cbf.corp.google.com with ESMTP id p454Pu9S027505 (version=TLSv1/SSLv3 cipher=RC4-SHA bits=128 verify=NOT) for ; Wed, 4 May 2011 21:26:15 -0700 Received: by qwk3 with SMTP id 3so1747647qwk.33 for ; Wed, 04 May 2011 21:26:15 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: References: Date: Wed, 4 May 2011 21:26:14 -0700 Message-ID: Subject: Re: [PATCH] mm: fix possible cause of a page_mapped BUG From: Michel Lespinasse Content-Type: text/plain; charset=ISO-8859-1 Sender: owner-linux-mm@kvack.org List-ID: To: Linus Torvalds Cc: =?UTF-8?B?Um9iZXJ0IMWad2nEmWNraQ==?= , Hugh Dickins , Andrew Morton , Miklos Szeredi , "Eric W. Biederman" , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Peter Zijlstra , Rik van Riel On Wed, May 4, 2011 at 8:37 PM, Linus Torvalds wrote: > I seriously considered making that "skip stack guard page" and the > "mlock lookup" be two separate bits, because conceptually they are > really pretty independent, but right now the only _users_ seem to be > tied together, so I kept it as one single bit (FOLL_MLOCK). Yes, this seems best for now. > But as far as I can tell, the attached patch is 100% equivalent to > what we do now, except for that "skip stack guard pages only for > mlock" change. > > Comments? I like this patch because it seems to make the logic more > straightforward. > > But somebody else should double-check my logic. It makes perfect sense. Reviewed-by: Michel Lespinasse (I would argue for it to go to stable trees as well) -- Michel "Walken" Lespinasse A program is never fully debugged until the last user dies. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org