* [PATCH] mm: memory: remove unreachable code
@ 2011-05-08 21:18 Maxin B John
2011-05-08 21:29 ` Rik van Riel
0 siblings, 1 reply; 3+ messages in thread
From: Maxin B John @ 2011-05-08 21:18 UTC (permalink / raw)
To: linux-kernel; +Cc: akpm, riel, walken, aarcange, hughd, linux-mm
Remove the unreachable code found in mm/memory.c
Signed-off-by: Maxin B. John <maxin.john@gmail.com>
---
diff --git a/mm/memory.c b/mm/memory.c
index 27f4253..d3b30af 100644
--- a/mm/memory.c
+++ b/mm/memory.c
@@ -3695,7 +3695,6 @@ static int __access_remote_vm(struct task_struct *tsk, struct mm_struct *mm,
if (ret <= 0)
#endif
break;
- bytes = ret;
} else {
bytes = len;
offset = addr & (PAGE_SIZE-1);
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] mm: memory: remove unreachable code
2011-05-08 21:18 [PATCH] mm: memory: remove unreachable code Maxin B John
@ 2011-05-08 21:29 ` Rik van Riel
2011-05-08 21:44 ` Maxin John
0 siblings, 1 reply; 3+ messages in thread
From: Rik van Riel @ 2011-05-08 21:29 UTC (permalink / raw)
To: Maxin B John; +Cc: linux-kernel, akpm, walken, aarcange, hughd, linux-mm
On 05/08/2011 05:18 PM, Maxin B John wrote:
> Remove the unreachable code found in mm/memory.c
>
> Signed-off-by: Maxin B. John<maxin.john@gmail.com>
> ---
> diff --git a/mm/memory.c b/mm/memory.c
> index 27f4253..d3b30af 100644
> --- a/mm/memory.c
> +++ b/mm/memory.c
> @@ -3695,7 +3695,6 @@ static int __access_remote_vm(struct task_struct *tsk, struct mm_struct *mm,
> if (ret<= 0)
> #endif
> break;
> - bytes = ret;
> } else {
> bytes = len;
> offset = addr& (PAGE_SIZE-1);
Is it really impossible for vma->vm_ops->access to return a
positive value?
--
All rights reversed
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] mm: memory: remove unreachable code
2011-05-08 21:29 ` Rik van Riel
@ 2011-05-08 21:44 ` Maxin John
0 siblings, 0 replies; 3+ messages in thread
From: Maxin John @ 2011-05-08 21:44 UTC (permalink / raw)
To: Rik van Riel; +Cc: linux-kernel, akpm, walken, aarcange, hughd, linux-mm
Hi,
>
> Is it really impossible for vma->vm_ops->access to return a
> positive value?
>
Got it .. Thank you very much for pointing it out.
Best Regards,
Maxin
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-05-08 21:45 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-05-08 21:18 [PATCH] mm: memory: remove unreachable code Maxin B John
2011-05-08 21:29 ` Rik van Riel
2011-05-08 21:44 ` Maxin John
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox