On Apr 8, 2011 10:23 PM, "Dave Hansen" <dave@linux.vnet.ibm.com> wrote:
> +       if (fmt) {
> +               printk(KERN_WARNING);
> +               va_start(args, fmt);
> +               r = vprintk(fmt, args);
> +               va_end(args);
> +       }

Could we make the "printk(KERN_WARNING);" go away and require caller to
specify level?

> +       printk(KERN_WARNING);
> +       printk("%s: page allocation failure: order:%d, mode:0x%x\n",
> +                       current->comm, order, gfp_mask);

Even more so here. Why not pr_warning instead of two non-atomic calls to
printk?