From: "Yan, Zheng" <zyan@redhat.com>
To: Jan Kara <jack@suse.cz>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, linux-fsdevel@vger.kernel.org,
Ilya Dryomov <idryomov@gmail.com>,
ceph-devel@vger.kernel.org
Subject: Re: [PATCH 03/15] ceph: Use pagevec_lookup_range_tag()
Date: Fri, 29 Sep 2017 09:20:56 +0800 [thread overview]
Message-ID: <BA15B4B8-3646-4382-8BA4-6D3B773FDDD5@redhat.com> (raw)
In-Reply-To: <20170927160334.29513-4-jack@suse.cz>
> On 28 Sep 2017, at 00:03, Jan Kara <jack@suse.cz> wrote:
>
> We want only pages from given range in ceph_writepages_start(). Use
> pagevec_lookup_range_tag() instead of pagevec_lookup_tag() and remove
> unnecessary code.
>
> CC: Ilya Dryomov <idryomov@gmail.com>
> CC: "Yan, Zheng" <zyan@redhat.com>
> CC: ceph-devel@vger.kernel.org
> Signed-off-by: Jan Kara <jack@suse.cz>
> ---
> fs/ceph/addr.c | 19 +++----------------
> 1 file changed, 3 insertions(+), 16 deletions(-)
>
> diff --git a/fs/ceph/addr.c b/fs/ceph/addr.c
> index b3e3edc09d80..e57e9d37bf2d 100644
> --- a/fs/ceph/addr.c
> +++ b/fs/ceph/addr.c
> @@ -871,13 +871,10 @@ static int ceph_writepages_start(struct address_space *mapping,
> get_more_pages:
> pvec_pages = min_t(unsigned, PAGEVEC_SIZE,
> max_pages - locked_pages);
> - if (end - index < (u64)(pvec_pages - 1))
> - pvec_pages = (unsigned)(end - index) + 1;
> -
> - pvec_pages = pagevec_lookup_tag(&pvec, mapping, &index,
> - PAGECACHE_TAG_DIRTY,
> + pvec_pages = pagevec_lookup_range_tag(&pvec, mapping, &index,
> + end, PAGECACHE_TAG_DIRTY,
> pvec_pages);
> - dout("pagevec_lookup_tag got %d\n", pvec_pages);
> + dout("pagevec_lookup_range_tag got %d\n", pvec_pages);
> if (!pvec_pages && !locked_pages)
> break;
> for (i = 0; i < pvec_pages && locked_pages < max_pages; i++) {
> @@ -895,16 +892,6 @@ static int ceph_writepages_start(struct address_space *mapping,
> unlock_page(page);
> continue;
> }
> - if (page->index > end) {
> - dout("end of range %p\n", page);
> - /* can't be range_cyclic (1st pass) because
> - * end == -1 in that case. */
> - stop = true;
> - if (ceph_wbc.head_snapc)
> - done = true;
> - unlock_page(page);
> - break;
> - }
> if (strip_unit_end && (page->index > strip_unit_end)) {
> dout("end of strip unit %p\n", page);
> unlock_page(page);
> --
> 2.12.3
>
Reviewed-by: "Yan, Zheng" <zyan@redhat.com>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2017-09-29 1:21 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-27 16:03 [PATCH 0/15 v2] Ranged pagevec tagged lookup Jan Kara
2017-09-27 16:03 ` [PATCH 01/15] mm: Implement find_get_pages_range_tag() Jan Kara
2017-09-27 16:03 ` [PATCH 02/15] btrfs: Use pagevec_lookup_range_tag() Jan Kara
2017-09-27 16:03 ` [PATCH 03/15] ceph: " Jan Kara
2017-09-29 1:20 ` Yan, Zheng [this message]
2017-09-27 16:03 ` [PATCH 04/15] ext4: " Jan Kara
2017-09-27 16:03 ` [PATCH 05/15] f2fs: " Jan Kara
2017-09-27 16:03 ` [PATCH 06/15] f2fs: Simplify page iteration loops Jan Kara
2017-09-27 16:03 ` [PATCH 07/15] f2fs: Use find_get_pages_tag() for looking up single page Jan Kara
2017-09-27 16:03 ` [PATCH 08/15] gfs2: Use pagevec_lookup_range_tag() Jan Kara
2017-09-27 16:03 ` [PATCH 09/15] nilfs2: " Jan Kara
2017-09-28 1:40 ` Ryusuke Konishi
2017-09-27 16:03 ` [PATCH 10/15] mm: Use pagevec_lookup_range_tag() in __filemap_fdatawait_range() Jan Kara
2017-09-27 22:19 ` Dave Chinner
2017-10-03 8:38 ` Jan Kara
2017-09-27 16:03 ` [PATCH 11/15] mm: Use pagevec_lookup_range_tag() in write_cache_pages() Jan Kara
2017-09-27 16:03 ` [PATCH 12/15] mm: Add variant of pagevec_lookup_range_tag() taking number of pages Jan Kara
2017-09-29 21:45 ` Daniel Jordan
2017-10-03 8:51 ` Jan Kara
2017-09-27 16:03 ` [PATCH 13/15] ceph: Use pagevec_lookup_range_nr_tag() Jan Kara
2017-09-27 16:03 ` [PATCH 14/15] mm: Remove nr_pages argument from pagevec_lookup_{,range}_tag() Jan Kara
2017-09-29 21:46 ` Daniel Jordan
2017-10-03 9:07 ` Jan Kara
2017-09-27 16:03 ` [PATCH 15/15] afs: Use find_get_pages_range_tag() Jan Kara
2017-09-29 21:46 ` Daniel Jordan
2017-10-03 12:03 ` Jan Kara
-- strict thread matches above, loose matches on Subject: below --
2017-09-14 13:18 [PATCH 0/15 v1] Ranged pagevec tagged lookup Jan Kara
2017-09-14 13:18 ` [PATCH 03/15] ceph: Use pagevec_lookup_range_tag() Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BA15B4B8-3646-4382-8BA4-6D3B773FDDD5@redhat.com \
--to=zyan@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=ceph-devel@vger.kernel.org \
--cc=idryomov@gmail.com \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox