From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F0DBFCE7A81 for ; Mon, 25 Sep 2023 10:25:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 512626B013D; Mon, 25 Sep 2023 06:25:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4C22D6B013F; Mon, 25 Sep 2023 06:25:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3B1246B0140; Mon, 25 Sep 2023 06:25:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 2B24E6B013D for ; Mon, 25 Sep 2023 06:25:31 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id EB7D4140B17 for ; Mon, 25 Sep 2023 10:25:30 +0000 (UTC) X-FDA: 81274738020.13.2BB1396 Received: from out-197.mta1.migadu.com (out-197.mta1.migadu.com [95.215.58.197]) by imf01.hostedemail.com (Postfix) with ESMTP id 2EAF64000B for ; Mon, 25 Sep 2023 10:25:27 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=QrV5dHoo; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf01.hostedemail.com: domain of muchun.song@linux.dev designates 95.215.58.197 as permitted sender) smtp.mailfrom=muchun.song@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1695637528; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=yxFAw7nLddeOwtmNKD8bf5RBQDwgBmyQvveBR6J5fJc=; b=AMF9Llqp4zgswFnqmz0QZFvy/CNmxph8Lbjy2TIH5k2vekFPu4TOVBNPz4xnDMbWrrLO6F ehhyN5LOtFtXFXdkQTR5NHztwtbVj09m1x+RhUM013hsbCOAqCI0MXEtdtikySiEgEvLSG 5CP5UKFh4wTXBbXiBkHWb9mw44zv0x4= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=QrV5dHoo; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf01.hostedemail.com: domain of muchun.song@linux.dev designates 95.215.58.197 as permitted sender) smtp.mailfrom=muchun.song@linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1695637528; a=rsa-sha256; cv=none; b=ebgrA9YOPepOhbRkb5jUQVhhPyrIqLX6YaASBj0qCIm5n0LdIdmh5YDaXYoQfTQXPPq2cG HsMDvj/K+aK2TeT/4XRfhXQCetDPLKkrR1DaVrmeSQ5FAv+l26ZqoktbHGKBHsOSdhg983 BKINVtg87RfyNRpiXzyD547ZkJeQbzo= Content-Type: text/plain; charset=us-ascii DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1695637526; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=yxFAw7nLddeOwtmNKD8bf5RBQDwgBmyQvveBR6J5fJc=; b=QrV5dHooV0sNdc21vKmdxXgl33U78NkIKXuflqcD0/5sodkrFghgo3HrHr/RYT4sYAQrN9 QZst+umX1KRxopPYytR1SFUzAQvoDxvIT6dcxH0OuyJOByZNSVAQ9DA4P2WhgWZtm8CS1O IoxDLv+av824/6TvRxNpcQSBen82elM= Mime-Version: 1.0 Subject: Re: [PATCH v5 3/8] hugetlb: perform vmemmap optimization on a list of pages X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Muchun Song In-Reply-To: <20230925003953.142620-4-mike.kravetz@oracle.com> Date: Mon, 25 Sep 2023 18:24:39 +0800 Cc: Linux-MM , LKML , Muchun Song , Joao Martins , Oscar Salvador , David Hildenbrand , Miaohe Lin , David Rientjes , Anshuman Khandual , Naoya Horiguchi , Barry Song <21cnbao@gmail.com>, Michal Hocko , Matthew Wilcox , Xiongchun Duan , Andrew Morton Content-Transfer-Encoding: 7bit Message-Id: References: <20230925003953.142620-1-mike.kravetz@oracle.com> <20230925003953.142620-4-mike.kravetz@oracle.com> To: Mike Kravetz X-Migadu-Flow: FLOW_OUT X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 2EAF64000B X-Stat-Signature: rqysn7eujwpzo9aag1m6uo3rygtoh4y1 X-HE-Tag: 1695637527-149476 X-HE-Meta: U2FsdGVkX18V/CBgyHhvClb3JsST8ouhtEMUGgwdRy4onLgWPHu/nnmd8dByMYpbLt0It0o8iyop77SAHSaGMPYtuNWVOhUjqs7qYv/p+RIyPDFbTz0d8n/e8LLJdnWtaWkwnG1Wwbg+2b8pU7Kr5NGt3ZxEFDmMeWzv9eRncq8FEEtn4kvNkG4H7haDWZQZMO7+AwuW6DxUKweQT+Ie/XLhYLgIcb/D4hfyyGme6MidyqqR30TL/Rgra1DfWpU07OEHw7S9ABOUwOBUxkbzFNwhApD8qofnN7NwKJNLWvqlHEFhlFNY2RhcjBT3ugYpQ8MXsku+Ba41ay/RxGBgNeTzn30FB6UfNcGtnGGA/Qmt/Pk24OcVI79IpULIDg4YGtrEUF/8DzKgaCMDW3C3aY1KtWrSMjBMHWCWYfwvq1wEoXzEtFH0m43NCvWK4NiWtK5UmKTWoEUNzZ8qGwSuUH/2xGASK4aqm2tUfQPoH4+WumNVl2ahxI3g47mAGT6ZkCwuRg9lsousDDx4RD+oPh+OaswIYJ1rRpcsqS+3c7EAMaEx7uvclz8QmkVUz5aiQHvtf7Wjyg7QJ/U296iKX2pnMUq5lUFoNph2kdIVByP3YxXk78K7zCr9h4J0ZGw8kV4ghVWREnoj350pxCX4c9LGaj3fQPX1JlzDuQKGXDUzS/PJLbpRi8Rlh1C0CMVBfJJ6lU9X4T6y/tdyD2D2p/zvoFUjdJILlc1CFTuaENz2F+RdQCJIRveJjYoPmUZYIfBaJgDqG54S8YBEOqYK/fReEsRbIY3iAprW89s7SnftEt4pqGAOMXqxqK4hD9Hebsdzb5grjO77azw/E4iaF0JjOb/FtD6ZcUieemRi2hDdbUi9NM7bDVhv+Fpf35PCih1P6GitS7ozuGBI4OM/iVnv/RAXcZhgMebce2jxj3rtBTXx2FIi/Oon/BzX6v4fhfXW/B45XdpS5aUkqah ROutpNcR jpSNMMcQBc8Efs5DGb00/U3QBx6OytuiaP2KpiDZX5H3OUdZ8Nl3+aoafSvGpR8/ud33B3tlXfh/nPppH4ICyiKms2igjoHCJ9iMzEBsQnWKjMbi0mPv2WV2uqFUBszE1+RkWfORmrcS+VVcjnkZ+VJUgekL5UVnUwiIOecD83ZvUz5TytwCUgL9HOq2ukwrwwxVCDSFGStp+Ezl6PgyRm9ITBVvhV9mjqnHqFEVCoaFjDwntJ0LLQxIWGA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > On Sep 25, 2023, at 08:39, Mike Kravetz wrote: > > When adding hugetlb pages to the pool, we first create a list of the > allocated pages before adding to the pool. Pass this list of pages to a > new routine hugetlb_vmemmap_optimize_folios() for vmemmap optimization. > > Due to significant differences in vmemmmap initialization for bootmem > allocated hugetlb pages, a new routine prep_and_add_bootmem_folios > is created. > > We also modify the routine vmemmap_should_optimize() to check for pages > that are already optimized. There are code paths that might request > vmemmap optimization twice and we want to make sure this is not > attempted. > > Signed-off-by: Mike Kravetz Reviewed-by: Muchun Song Thanks.