From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 70F3EC433E1 for ; Sat, 18 Jul 2020 05:09:33 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 3F9CF2083B for ; Sat, 18 Jul 2020 05:09:33 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3F9CF2083B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=hisilicon.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id B05CC6B0078; Sat, 18 Jul 2020 01:09:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A8F066B007D; Sat, 18 Jul 2020 01:09:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 957EB6B007E; Sat, 18 Jul 2020 01:09:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0147.hostedemail.com [216.40.44.147]) by kanga.kvack.org (Postfix) with ESMTP id 7C9646B0078 for ; Sat, 18 Jul 2020 01:09:32 -0400 (EDT) Received: from smtpin18.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 204FC181AEF00 for ; Sat, 18 Jul 2020 05:09:32 +0000 (UTC) X-FDA: 77050018584.18.cake11_171753126f10 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin18.hostedemail.com (Postfix) with ESMTP id E8AF310044BDD for ; Sat, 18 Jul 2020 05:09:31 +0000 (UTC) X-HE-Tag: cake11_171753126f10 X-Filterd-Recvd-Size: 4034 Received: from huawei.com (szxga03-in.huawei.com [45.249.212.189]) by imf43.hostedemail.com (Postfix) with ESMTP for ; Sat, 18 Jul 2020 05:09:31 +0000 (UTC) Received: from dggemi404-hub.china.huawei.com (unknown [172.30.72.53]) by Forcepoint Email with ESMTP id 6CC67F0EEEC0DF655046; Sat, 18 Jul 2020 13:09:27 +0800 (CST) Received: from DGGEMI525-MBS.china.huawei.com ([169.254.6.52]) by dggemi404-hub.china.huawei.com ([10.3.17.142]) with mapi id 14.03.0487.000; Sat, 18 Jul 2020 13:09:17 +0800 From: "Song Bao Hua (Barry Song)" To: Jonathan Cameron , "linux-mm@kvack.org" , "linux-acpi@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "x86@kernel.org" CC: Lorenzo Pieralisi , Bjorn Helgaas , "linux-pci@vger.kernel.org" , "martin@geanix.com" , "Ingo Molnar" , "linux-ia64@vger.kernel.org" , Tony Luck , Fenghua Yu , Thomas Gleixner , Linuxarm , Dan Williams Subject: RE: [PATCH v2 1/6] ACPI: Add out of bounds and numa_off protections to pxm_to_node Thread-Topic: [PATCH v2 1/6] ACPI: Add out of bounds and numa_off protections to pxm_to_node Thread-Index: AQHWXGREtKO5c5ALFUyDHE/x3auv/qkMybkQ Date: Sat, 18 Jul 2020 05:09:16 +0000 Message-ID: References: <20200717175959.899775-1-Jonathan.Cameron@huawei.com> <20200717175959.899775-2-Jonathan.Cameron@huawei.com> In-Reply-To: <20200717175959.899775-2-Jonathan.Cameron@huawei.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.126.200.103] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-CFilter-Loop: Reflected X-Rspamd-Queue-Id: E8AF310044BDD X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam02 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > -----Original Message----- > From: Jonathan Cameron > Sent: Saturday, July 18, 2020 6:00 AM > To: linux-mm@kvack.org; linux-acpi@vger.kernel.org; > linux-arm-kernel@lists.infradead.org; x86@kernel.org > Cc: Lorenzo Pieralisi ; Bjorn Helgaas > ; linux-pci@vger.kernel.org; martin@geanix.com; Ingo > Molnar ; linux-ia64@vger.kernel.org; Tony Luck > ; Fenghua Yu ; Thomas > Gleixner ; Linuxarm ; Dan > Williams ; Song Bao Hua (Barry Song) > ; Jonathan Cameron > > Subject: [PATCH v2 1/6] ACPI: Add out of bounds and numa_off protections = to > pxm_to_node >=20 > The function should check the validity of the pxm value before using > it to index the pxm_to_node_map array. >=20 > Whilst hardening this code may be good in general, the main intent > here is to enable following patches that use this function to replace > acpi_map_pxm_to_node for non SRAT usecases which should return > NO_NUMA_NODE for PXM entries not matching with those in SRAT. >=20 > Signed-off-by: Jonathan Cameron Reviewed-by: Barry Song > --- > drivers/acpi/numa/srat.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/drivers/acpi/numa/srat.c b/drivers/acpi/numa/srat.c > index 5be5a977da1b..8ef44ee0d76b 100644 > --- a/drivers/acpi/numa/srat.c > +++ b/drivers/acpi/numa/srat.c > @@ -31,7 +31,7 @@ int acpi_numa __initdata; >=20 > int pxm_to_node(int pxm) > { > - if (pxm < 0) > + if (pxm < 0 || pxm >=3D MAX_PXM_DOMAINS || numa_off) > return NUMA_NO_NODE; > return pxm_to_node_map[pxm]; > } > -- > 2.19.1