From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9DF1DC433E0 for ; Tue, 23 Jun 2020 02:07:23 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 4670A20768 for ; Tue, 23 Jun 2020 02:07:23 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4670A20768 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=hisilicon.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id B860D6B0005; Mon, 22 Jun 2020 22:07:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B0F726B0006; Mon, 22 Jun 2020 22:07:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9AF476B0008; Mon, 22 Jun 2020 22:07:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0072.hostedemail.com [216.40.44.72]) by kanga.kvack.org (Postfix) with ESMTP id 7BCB86B0005 for ; Mon, 22 Jun 2020 22:07:22 -0400 (EDT) Received: from smtpin17.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 376A98248047 for ; Tue, 23 Jun 2020 02:07:22 +0000 (UTC) X-FDA: 76958839524.17.dad69_3a16f5326e37 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin17.hostedemail.com (Postfix) with ESMTP id 11ECC180D0180 for ; Tue, 23 Jun 2020 02:07:22 +0000 (UTC) X-HE-Tag: dad69_3a16f5326e37 X-Filterd-Recvd-Size: 3460 Received: from huawei.com (szxga02-in.huawei.com [45.249.212.188]) by imf45.hostedemail.com (Postfix) with ESMTP for ; Tue, 23 Jun 2020 02:07:21 +0000 (UTC) Received: from dggemi405-hub.china.huawei.com (unknown [172.30.72.57]) by Forcepoint Email with ESMTP id D1846DD068501499BC45; Tue, 23 Jun 2020 10:07:17 +0800 (CST) Received: from DGGEMI422-HUB.china.huawei.com (10.1.199.151) by dggemi405-hub.china.huawei.com (10.3.17.143) with Microsoft SMTP Server (TLS) id 14.3.487.0; Tue, 23 Jun 2020 10:07:17 +0800 Received: from DGGEMI525-MBS.china.huawei.com ([169.254.6.126]) by dggemi422-hub.china.huawei.com ([10.1.199.151]) with mapi id 14.03.0487.000; Tue, 23 Jun 2020 10:07:15 +0800 From: "Song Bao Hua (Barry Song)" To: Nathan Chancellor , Andrew Morton CC: "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , "clang-built-linux@googlegroups.com" Subject: RE: [PATCH] mm: cma: Return cma->name directly in cma_get_name Thread-Topic: [PATCH] mm: cma: Return cma->name directly in cma_get_name Thread-Index: AQHWSQHe9Q6zYWq9cEyE52thANJ/xKjlcxgA Date: Tue, 23 Jun 2020 02:07:15 +0000 Message-ID: References: <20200623015840.621964-1-natechancellor@gmail.com> In-Reply-To: <20200623015840.621964-1-natechancellor@gmail.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.126.202.192] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-CFilter-Loop: Reflected X-Rspamd-Queue-Id: 11ECC180D0180 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam03 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > -----Original Message----- > From: Nathan Chancellor [mailto:natechancellor@gmail.com] > Sent: Tuesday, June 23, 2020 1:59 PM > To: Andrew Morton > Cc: linux-mm@kvack.org; linux-kernel@vger.kernel.org; > clang-built-linux@googlegroups.com; Song Bao Hua (Barry Song) > ; Nathan Chancellor > > Subject: [PATCH] mm: cma: Return cma->name directly in cma_get_name >=20 > clang warns: >=20 > mm/cma.c:55:14: warning: address of array 'cma->name' will always > evaluate to 'true' [-Wpointer-bool-conversion] > return cma->name ? cma->name : "(undefined)"; > ~~~~~^~~~ ~ > 1 warning generated. >=20 > After commit e7f0557d7de9 ("mm: cma: fix the name of CMA areas"), > cma->name will be an array with some value worth printing so we do not > need to check for NULL. >=20 > Link: https://github.com/ClangBuiltLinux/linux/issues/1063 > Signed-off-by: Nathan Chancellor Thanks! Acked-by: Barry Song > --- > mm/cma.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/mm/cma.c b/mm/cma.c > index 31a61d410c59..6cf08817bac6 100644 > --- a/mm/cma.c > +++ b/mm/cma.c > @@ -52,7 +52,7 @@ unsigned long cma_get_size(const struct cma *cma) >=20 > const char *cma_get_name(const struct cma *cma) > { > - return cma->name ? cma->name : "(undefined)"; > + return cma->name; > } >=20 > static unsigned long cma_bitmap_aligned_mask(const struct cma *cma, >=20 > base-commit: 27f11fea33608cbd321a97cbecfa2ef97dcc1821 > -- > 2.27.0