From: Qian Cai <cai@lca.pw>
To: Alex Shi <alex.shi@linux.alibaba.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm/vmscan: remove prefetch_prev_lru_page
Date: Thu, 16 Jan 2020 07:26:23 -0500 [thread overview]
Message-ID: <B6E75D9E-E9A2-4078-A89A-267310467B0A@lca.pw> (raw)
In-Reply-To: <739f4470-8dfe-bb2f-8100-2134f48868b6@linux.alibaba.com>
> On Jan 14, 2020, at 9:33 PM, Alex Shi <alex.shi@linux.alibaba.com> wrote:
>
>
>
>> 在 2020/1/14 下午9:46, Qian Cai 写道:
>>
>>
>>>> On Jan 14, 2020, at 7:55 AM, Alex Shi <alex.shi@linux.alibaba.com> wrote:
>>>
>>> This macro are never used in git history. So better to remove.
>>
>> When removing unused thingy, it is important to figure out which commit introduced it in the first place and Cc the relevant people in that commit.
>>
>
> Thanks fore reminder, Qian!
>
> This macro was introduced in 1da177e4c3f4 Linux-2.6.12-rc2, no author or commiter could be found.
Looks a bit deeper for this, and I am not sure if it is necessary to remove it especially this does not cause any complication warning noise, because the macro looks like a part of API design to have a pair of both read and write version, even though only the write version is used at the moment.
In theory, there could be users for the read version in the future, and then it needs to be added back.
next prev parent reply other threads:[~2020-01-16 12:26 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-14 12:55 Alex Shi
2020-01-14 13:46 ` Qian Cai
2020-01-15 2:31 ` Alex Shi
2020-01-16 12:26 ` Qian Cai [this message]
2020-01-16 23:37 ` Andrew Morton
2020-01-16 13:18 ` Guoqing Jiang
2020-01-15 8:29 ` Christoph Hellwig
2020-01-15 18:27 ` Qian Cai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=B6E75D9E-E9A2-4078-A89A-267310467B0A@lca.pw \
--to=cai@lca.pw \
--cc=akpm@linux-foundation.org \
--cc=alex.shi@linux.alibaba.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox