linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Muchun Song <muchun.song@linux.dev>
To: Jiaqi Yan <jiaqiyan@google.com>
Cc: jane.chu@oracle.com, osalvador@suse.de, david@kernel.org,
	william.roche@oracle.com, linux-mm@kvack.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] hugetlb: simplify remove_inode_hugepages() return type
Date: Wed, 4 Feb 2026 14:06:14 +0800	[thread overview]
Message-ID: <B6A091A5-B25E-41CB-8882-493E006A0BE7@linux.dev> (raw)
In-Reply-To: <20260202233617.2350734-1-jiaqiyan@google.com>



> On Feb 3, 2026, at 07:36, Jiaqi Yan <jiaqiyan@google.com> wrote:
> 
> When remove_inode_hugepages is introduced in
> commit c86272287bc6 ("hugetlb: create remove_inode_single_folio to remove single file folio")
> it used to return a boolean to indicate if it bailed out due to race with
> page faults. However, since the race is already solved by [1],
> remove_inode_hugepages() doesn't have any path to return false anymore.
> 
> Simplify remove_inode_hugepages() return type to void, remove the
> unnecessary ret variable, and adjust the call site in
> remove_inode_hugepages(). No functional change in this commit.
> 
> [1] https://lore.kernel.org/all/20220914221810.95771-10-mike.kravetz@oracle.com
> 
> Suggested-by: Jane Chu <jane.chu@oracle.com>
> Signed-off-by: Jiaqi Yan <jiaqiyan@google.com>

Reviewed-by: Muchun Song <muchun.song@linux.dev>




  parent reply	other threads:[~2026-02-04  6:07 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-02 23:36 [PATCH v1] fs: " Jiaqi Yan
2026-02-04  4:26 ` jane.chu
2026-02-04  6:06 ` Muchun Song [this message]
2026-02-04 11:41 ` David Hildenbrand (arm)
2026-02-04 21:49   ` Jiaqi Yan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=B6A091A5-B25E-41CB-8882-493E006A0BE7@linux.dev \
    --to=muchun.song@linux.dev \
    --cc=david@kernel.org \
    --cc=jane.chu@oracle.com \
    --cc=jiaqiyan@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=osalvador@suse.de \
    --cc=william.roche@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox