linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Muchun Song <muchun.song@linux.dev>
To: Mike Kravetz <mike.kravetz@oracle.com>
Cc: Linux-MM <linux-mm@kvack.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Muchun Song <songmuchun@bytedance.com>,
	Joao Martins <joao.m.martins@oracle.com>,
	Konrad Dybcio <konradybcio@kernel.org>,
	Oscar Salvador <osalvador@suse.de>,
	David Hildenbrand <david@redhat.com>,
	Miaohe Lin <linmiaohe@huawei.com>,
	David Rientjes <rientjes@google.com>,
	Anshuman Khandual <anshuman.khandual@arm.com>,
	Naoya Horiguchi <naoya.horiguchi@linux.dev>,
	Barry Song <21cnbao@gmail.com>, Michal Hocko <mhocko@suse.com>,
	Matthew Wilcox <willy@infradead.org>,
	Xiongchun Duan <duanxiongchun@bytedance.com>,
	Sergey Senozhatsky <senozhatsky@chromium.org>,
	Usama Arif <usama.arif@bytedance.com>,
	Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH v8 3/8] hugetlb: perform vmemmap optimization on a list of pages
Date: Thu, 19 Oct 2023 11:12:24 +0800	[thread overview]
Message-ID: <B59EBDE7-0369-4AA1-90AC-DB930A04F92E@linux.dev> (raw)
In-Reply-To: <20231019023113.345257-4-mike.kravetz@oracle.com>



> On Oct 19, 2023, at 10:31, Mike Kravetz <mike.kravetz@oracle.com> wrote:
> 
> When adding hugetlb pages to the pool, we first create a list of the
> allocated pages before adding to the pool.  Pass this list of pages to a
> new routine hugetlb_vmemmap_optimize_folios() for vmemmap optimization.
> 
> Due to significant differences in vmemmmap initialization for bootmem
> allocated hugetlb pages, a new routine prep_and_add_bootmem_folios
> is created.
> 
> We also modify the routine vmemmap_should_optimize() to check for pages
> that are already optimized.  There are code paths that might request
> vmemmap optimization twice and we want to make sure this is not
> attempted.
> 
> Signed-off-by: Mike Kravetz <mike.kravetz@oracle.com>

Reviewed-by: Muchun Song <songmuchun@bytedance.com>

Thanks.



  reply	other threads:[~2023-10-19  3:13 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-19  2:31 [PATCH v8 0/8] Batch hugetlb vmemmap modification operations Mike Kravetz
2023-10-19  2:31 ` [PATCH v8 1/8] hugetlb: optimize update_and_free_pages_bulk to avoid lock cycles Mike Kravetz
2023-10-19  2:31 ` [PATCH v8 2/8] hugetlb: restructure pool allocations Mike Kravetz
2023-10-19  3:11   ` Muchun Song
2023-10-21  7:42   ` Sergey Senozhatsky
2023-10-19  2:31 ` [PATCH v8 3/8] hugetlb: perform vmemmap optimization on a list of pages Mike Kravetz
2023-10-19  3:12   ` Muchun Song [this message]
2023-10-19  2:31 ` [PATCH v8 4/8] hugetlb: perform vmemmap restoration " Mike Kravetz
2023-10-19  2:31 ` [PATCH v8 5/8] hugetlb: batch freeing of vmemmap pages Mike Kravetz
2023-10-19  2:31 ` [PATCH v8 6/8] hugetlb: batch PMD split for bulk vmemmap dedup Mike Kravetz
2023-10-19  2:31 ` [PATCH v8 7/8] hugetlb: batch TLB flushes when freeing vmemmap Mike Kravetz
2023-10-21 18:20   ` Jane Chu
2023-10-21 19:38     ` Mike Kravetz
2023-10-19  2:31 ` [PATCH v8 8/8] hugetlb: batch TLB flushes when restoring vmemmap Mike Kravetz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=B59EBDE7-0369-4AA1-90AC-DB930A04F92E@linux.dev \
    --to=muchun.song@linux.dev \
    --cc=21cnbao@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=anshuman.khandual@arm.com \
    --cc=david@redhat.com \
    --cc=duanxiongchun@bytedance.com \
    --cc=joao.m.martins@oracle.com \
    --cc=konradybcio@kernel.org \
    --cc=linmiaohe@huawei.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mhocko@suse.com \
    --cc=mike.kravetz@oracle.com \
    --cc=naoya.horiguchi@linux.dev \
    --cc=osalvador@suse.de \
    --cc=rientjes@google.com \
    --cc=senozhatsky@chromium.org \
    --cc=songmuchun@bytedance.com \
    --cc=usama.arif@bytedance.com \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox