From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0482DD729E9 for ; Fri, 29 Nov 2024 15:47:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8AA856B0088; Fri, 29 Nov 2024 10:47:13 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 85B4E6B0089; Fri, 29 Nov 2024 10:47:13 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6D3396B008C; Fri, 29 Nov 2024 10:47:13 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 509016B0088 for ; Fri, 29 Nov 2024 10:47:13 -0500 (EST) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id D4C9B1A015F for ; Fri, 29 Nov 2024 15:47:12 +0000 (UTC) X-FDA: 82839561210.06.E1E1D70 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2089.outbound.protection.outlook.com [40.107.220.89]) by imf18.hostedemail.com (Postfix) with ESMTP id 40F591C0032 for ; Fri, 29 Nov 2024 15:47:05 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b=YMHTFZgS; arc=pass ("microsoft.com:s=arcselector10001:i=1"); spf=pass (imf18.hostedemail.com: domain of ziy@nvidia.com designates 40.107.220.89 as permitted sender) smtp.mailfrom=ziy@nvidia.com; dmarc=pass (policy=reject) header.from=nvidia.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1732895224; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=y00F0h4CTlqUhsyP2zlqriZfXoOUmHYFbvcgzpKOU+w=; b=MiTQ7eeRSLojbIWsz/6QdOt/PEshZXtZKr9P2rhduzX6ZSAntjJXQ9UBlkj3uIOqdRbb8l wjveNqEEjZiQMmLkc2gTVcV+xoozApuiEGUGWKV8oa45Ezl1baA7FmY1rBQ3CEDnKNajTZ x41eGFhZwoOx7ptr/0O6bML67Pb77ns= ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1732895224; a=rsa-sha256; cv=pass; b=7onfUxTfUmnjrIP46xDa6Nd0nC2dZb1p7hblH6I1v/FBn2PduoX0AI/HgvGlD4Wqz8vZ6k UvAirRbeV+gS98odt1PvmHT7G5nDMQK+Z5zegb8Cb3CqOkBuFzgEWI1oi6dBTNp/1WcztH zXuwvSP6eYS8AmgouIi9DmTDAVLPKow= ARC-Authentication-Results: i=2; imf18.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b=YMHTFZgS; arc=pass ("microsoft.com:s=arcselector10001:i=1"); spf=pass (imf18.hostedemail.com: domain of ziy@nvidia.com designates 40.107.220.89 as permitted sender) smtp.mailfrom=ziy@nvidia.com; dmarc=pass (policy=reject) header.from=nvidia.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=yOryqKIZWYFmJQC63eyYz9GJi/ipX/EjQJBxvPKSUO39u1qnJ0XgWcNpgJtLM55hmaYURjGvJOGdGhXuzVjG+ZaqAk1AtCa6MVzbd2lh1CxVUrtbVuqUu69CIw20F/nHnH4EvDxPfeUuIAoBx9KomoC4qS/ZfPocTKQ7huAuiH2MzEwKsUXFWbF4GtEzAVc1ZJhYNvmm18hSf1n++oA2fjWZERk5BXWATeJxYfRwjomAtVqUFLUYKbcZ1Zzry1kJYLz/gmvMJK5OZQWbH8HpXNYa8Km6wmAi4YBXiGaChR8H0qVp8YVikweAydus/5JCGU6BhoZLWjEDbM49OcbcUA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=y00F0h4CTlqUhsyP2zlqriZfXoOUmHYFbvcgzpKOU+w=; b=W6B25s9b0Mt907OXWEl/pHY/e2yMLGdu0VHER6dwYgoQ89fgoKOxTGMMGTSy1kBYveTbQ6ynAMj9wSVpnAImmQl+hCv/IArsGRCRh5ELdLlfYTI/7fyzoKPy+ozXNdb9kaCdPVFjW1RVd5qt33fEGLrjZY6RFG3FfDBJQBM9unYEyxfYZjsQjR82Eetdo5qtrCdSdbNNrozlg5LITO7oxBBP07q+RukqNFyDyNedRIDfnQ9K66Lwyb1nLuCXfH5q1qJl33xAZ827V4XRl79tt4+Ax5/7SA0GEldxHNOE2cU+LFl5QSWmVB8JEQ7Mlaz3WTVezRpFP01hwnzfwi8/Pg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=y00F0h4CTlqUhsyP2zlqriZfXoOUmHYFbvcgzpKOU+w=; b=YMHTFZgStPPgAw1dYaD13Hg+7Odlr+hUWSkXWqEIU7Yr7Hc/v8GEyheCZhkQDuw4UNcUW42uDhrhRVcKCKuLxwQOwsR11SnmE4D6eML5fLnMJ/h1E4sMavxeJurDQPWk0MHBTaBbHHlrmMvW3GA49v1pqtKSracniob7lRNGt5sWjbBuN3oFZva9UfcCbyoVErwnPpzgbinp2qsROKh8bLSEY3Czkz49c0mw7WW8yycpNlSqFI/DUUsSdx+FVvq8LAH1lG3W0E8xJE2W8vJxYDIH4ke46M6bE+N9CmDS6YT987MrSglPwsM71MnE5yHWjFdr+PY+O6ypp74VptXJWA== Received: from DS7PR12MB9473.namprd12.prod.outlook.com (2603:10b6:8:252::5) by DS0PR12MB8200.namprd12.prod.outlook.com (2603:10b6:8:f5::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8207.14; Fri, 29 Nov 2024 15:47:06 +0000 Received: from DS7PR12MB9473.namprd12.prod.outlook.com ([fe80::5189:ecec:d84a:133a]) by DS7PR12MB9473.namprd12.prod.outlook.com ([fe80::5189:ecec:d84a:133a%7]) with mapi id 15.20.8207.010; Fri, 29 Nov 2024 15:47:06 +0000 From: Zi Yan To: "Matthew Wilcox (Oracle)" Cc: Andrew Morton , linux-mm@kvack.org, David Hildenbrand , William Kucharski , Miaohe Lin , Muchun Song Subject: Re: [PATCH v3 03/15] mm/page_alloc: Export free_frozen_pages() instead of free_unref_page() Date: Fri, 29 Nov 2024 10:47:04 -0500 X-Mailer: MailMate (1.14r6065) Message-ID: In-Reply-To: <20241125210149.2976098-4-willy@infradead.org> References: <20241125210149.2976098-1-willy@infradead.org> <20241125210149.2976098-4-willy@infradead.org> Content-Type: text/plain X-ClientProxiedBy: MN2PR04CA0021.namprd04.prod.outlook.com (2603:10b6:208:d4::34) To DS7PR12MB9473.namprd12.prod.outlook.com (2603:10b6:8:252::5) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS7PR12MB9473:EE_|DS0PR12MB8200:EE_ X-MS-Office365-Filtering-Correlation-Id: d74b5baf-d2c1-4e04-59ae-08dd108d139f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|376014|1800799024|7053199007; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?D2mmZ+LQtwu3z4NIQD2y+h0b7ERUlu87xNQuj5laop7QqUujwRKVx6bZE6xU?= =?us-ascii?Q?iky1HzkiJPpTFiGpCb3TdqRH9RlxMin2MkvrvsBRWe1HaiXmgxJ4B2YuuQq+?= =?us-ascii?Q?1kvoWaIvZsxJQtb816EnWhhQbViXvrrS2NfDmE8hQab3Mm8djZVKsu7OT0Y0?= =?us-ascii?Q?BGGTubfT95fZtwxb2H9PD88sz6DDBqzXytSB16YuKqaH/o2dKW+CeI9XJ0pq?= =?us-ascii?Q?gnrMEMbhBc+6dqNpJb3ddwqzQlPLcNrKF2O8LDeI5gtB4L9VIfUg4lNSp325?= =?us-ascii?Q?N626X4Er6KUesH9GUeNkAQa7kIiLTIpAPrAlmRiZP2iNGFH1U5WkgC7vEVr1?= =?us-ascii?Q?ry0V+6NA9dgFZZxzul1ld8F600Q6I7m3x5HfqlKgVueTPzFYfZ1oZxA+7SuC?= =?us-ascii?Q?+2gKjhR5V+fFlOt/4czauPRvFaJ+Y4Pb/nn0W/8X470tK6xYTBkG0bJtnRir?= =?us-ascii?Q?cSZFC1jjXtlAIdGiy631D0fzKhIxD4MT4T9EUx1vIWTVNNRepvpE4cyPyXiG?= =?us-ascii?Q?mEtl+Ml92KxB56zsxJheQ9XNQ8GbVXX8Vuv0z5LMhx+j47pAuw582oEfeB/B?= =?us-ascii?Q?ThmmIRv486qPfzWw0GhOEUvz+cpcm5HI6mxz4ER/Na0G4RKEauoBHNNFuDrZ?= =?us-ascii?Q?7tkxK/aPu7bQmYBMGSzf1zt1JnTr20C248tr8A206fuJYMQJY2zuQeZ1QIiR?= =?us-ascii?Q?P2qu9f9R5KtoG9nRlBkucUwyJh1TYYRv2G0aVXiL2wjmHdgMmTUvN50sfuXX?= =?us-ascii?Q?s3Jqh86qh0Slvvwo4S2E01AlbHEVgCrRSxbrH8RTX4+7BaabTIFDCIvAwNMd?= =?us-ascii?Q?ygQkNKfG8n/9iMIEG/nm+/WfdFfPm+XrkPLNRZ5/EgZI4ZA0UNn7vJxQwjXZ?= =?us-ascii?Q?lHYLgyOx7NU2sq+R3EDvH7FBiHInpxkCjJNaW+CfVT9/AiGQf/gSk3UM5gJ5?= =?us-ascii?Q?IP307hC1MVyzYmAr3vRqN+zRiC0i8535Ht6l6IhhVPd8ptPxTphN0AaliP+S?= =?us-ascii?Q?UsbBVGL8V2lZvzOJiJlqKsnzGXqBxBiKLdjWDw9gxiNw8VWCnZHKcps7Ufaw?= =?us-ascii?Q?YRIIhQHTSHCQHZvUpNv6/5XBxFPgteibY5njTMDOipW8TOlSBjDUnCYegG5O?= =?us-ascii?Q?7a5xG9GRkFlA8C/vZZAc5dqmNd71F75u/qlb6g9dPTLGnDOiUVQuyc6eyyKQ?= =?us-ascii?Q?OVLX2gmKGpDv5/H1v0syhQH14wOnFakt/u5G4Ipwoe5VT0SXsgBMwrC4jCyQ?= =?us-ascii?Q?u7wLvm4Iykj1tANwsTn/8HzLpo9o8SJ1rlKhIhZqQ39XklDfpG+JvrYnTIUq?= =?us-ascii?Q?HHfNNE/Uo/ANR0gHwMU1h93s5k1kfXhs1fTgDIUDls2pyQ=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR12MB9473.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(376014)(1800799024)(7053199007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?JTtwJ1LEkG8Ro2TZ7CE4LHf4qbw/tJRIv5uEJxU+hANvurH2c8IuI4d8oCYs?= =?us-ascii?Q?3JaC6q8g4T/+ixigufoBD+0k7x6zw+ZxXkWnTdte+lptMfbiwU7md5wCGjAf?= =?us-ascii?Q?4wdPNj1Vtrr6Cgx498/BSbwAVrrbIvLHJzEte42QUXxnxJ6ECACaOei2CIdp?= =?us-ascii?Q?HW/tnnvyPIaGQ/vSs1SM2tQhJ/4o3FkRW9aBC4VtsKDP9t3TPgHHyw319a/F?= =?us-ascii?Q?akAj/W6PPLji4ehBLNqlagyo0K/meVuzSl96F0QgmdmcQ/if1S7BKEy7ftkU?= =?us-ascii?Q?DyuImcAaMasn4B7e5xMGAPh6OJDiXhQ0IcZkVx5GmzPvUV36mwBYr2LrHTfg?= =?us-ascii?Q?OnAVZvytwE7FvEWZrYA73Ua9Vymfb6AaOa0nNbq5kCKdyni8Efq0y8f7SyOK?= =?us-ascii?Q?bky+2OIInHLr4xpOlXUFNrk74NMcydpIXRZ6nifZOdAO0n/kb4ue2mEAlZsL?= =?us-ascii?Q?s5RZwlmHkfywY6TG17ovXSwoOeQy22UEVMsxj7XP6wP1fLi4AAAF7Ww5d7GX?= =?us-ascii?Q?+TVIBPwrFexBYOEsn8jhyZHoINI9LPF6dlM+LPLXtxHOJqsWXcVV3InA3jkL?= =?us-ascii?Q?xNKLldJYbBqlsb8qA84LbKtYIw7cwyEQ0s0xa+cjKkrVcS2iDhjxxbBdid71?= =?us-ascii?Q?kMI52Irxy/sxGCLB2RnUe+G6OwlpdyOwHv3E/4OOiOmGEa4bhbulSIMq/BzN?= =?us-ascii?Q?sCHfgGdBzjLGIJL+EeOzIX/QrV3ZR1lnz55ns9BVN0f8MgSo5WwXddUoYShz?= =?us-ascii?Q?VOFHjqTEcD73x1WK2rxU1UgAGWqOdpCNYE/ira0As7kNQihZldgUtZRR8tZT?= =?us-ascii?Q?E1Px1zyg3TaTvAeNdnXE3ssSDnr6BEu8jpfOls6hGRWPaJJtCdZXQvI82exR?= =?us-ascii?Q?HSvUxoWMFv3fkp3KgSj2v6cjsYEZrTX67f0QYLQJwVrLg4iAstCobEOiZrn+?= =?us-ascii?Q?eN1g5iMHB+HVcBV14NZI+HVFzxBjIaDYCteSu9DfBm66UsRHQv81uu/2HIw+?= =?us-ascii?Q?N5udFTq+yNctgVRYdGXPMLKm3hSGX5Y7uUHptaPQFSYhA6tTtgBvrUKJhITI?= =?us-ascii?Q?0alKgXe7PnzwTqJ1TXKEil21nIhKUJ9LWIvufJdE0/LT6SCqTKdwT8zV0uLr?= =?us-ascii?Q?WpyvjP4C11LCQAIvjyLO/uKjVOc40tM9AVhAxTelwAOlFD3feIyqJspobqNV?= =?us-ascii?Q?4nIXHyTTwDkN/eho19EGdbJlHOi4K7q8aO5zVYbJ5v0Urpx8g4Gk9v/99VfK?= =?us-ascii?Q?JVE809sglz+U/tV+eYxRc51gsAlAVX0eQpGU4K5rcwVS4/OZ7gGalOiY1SkO?= =?us-ascii?Q?j+OzlO07TJeVCpHi/Ph/v+rd5TyQ0xErtB0kBGoMdVZrjltgsDEi2vpa0sSg?= =?us-ascii?Q?+MtDlDORDajG3+xp9ohxpFGch3cuiexPWaVVdHaLPcO9IOMayko8NQOfRrFQ?= =?us-ascii?Q?WGen/olK8PyTRGfQneDtk8EC+ifFNsz8vsDopg4AdqGbgYfhSv2umCDC6QMI?= =?us-ascii?Q?AZSyv+H8M9mrR9VqGWu9osXTW7vnYygcj9mc2OXF5Hf6u4K/w+C8Cb556S2u?= =?us-ascii?Q?UfBwcBEmO010PqlnnaVcsTbzaSfUR1yeGgxxnHjI?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: d74b5baf-d2c1-4e04-59ae-08dd108d139f X-MS-Exchange-CrossTenant-AuthSource: DS7PR12MB9473.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Nov 2024 15:47:06.2987 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: GKeni73IKq97vKWlUcvNkax48sQ2AbO87oN9LDAcXDh8FPbD3XhQn+TPW+Vcm5uu X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB8200 X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 40F591C0032 X-Stat-Signature: rj8u7x19wzg6msnsxhc8mxo19ekzxs5i X-Rspam-User: X-HE-Tag: 1732895225-527962 X-HE-Meta: U2FsdGVkX1/bhEwnrwSeZPoavodomOA0yCYsXLaCz2LddliqqzVpaKUsalLHmjp45IHE9OVIWhr11pjx4ILxRQjqBT8EutgxJa2wv+lxMXJW+HV0QMNIWQG6wFyQQ43FzOnSkPaRGajbWfZUbdnVLq7aWavqxMIpg/4pt5C/5G1g54eCQJc9vYmAuWChsVGmIKN99VzQGWdfCN42+KJuMutGqEQsOP1xHL6mb78EE5GY9IMrTSoxKxGo+nTgCJsYrYY5f06fIm5W+TjymgzMj28atbP2OdAO0MhSPAKmW5wcZkHqjBp2g8Hlwz1mOwq78YMWfaX9UpoAoat2ed9drGtNXDIu/9xFzwYoAlyPfNoQvjH+OABGApt5sKJoPxnWo6wGbl0+LbMG+d5fmSxVYKfptl75aAMjmNfUkrIxCXCJ/B8+BR2FVyh9NDjo5Oj8DjLIRrvVvVqJpLUDufBJggp0zoKnvKmTFA84eaQPp5dsXzNNd31xhrAeKDytNfQKnSfA0e7BOUTQWPzkGdywfJqiies4hoz16TejxoKHYGoNJiBFqdYVs1M/anh/zT6y+ybJzZ/LbVHV4FXGVr51PrPvbXLbwvgEMyXmAkyVAdK6D2XclAdMr+pXEFOChns8kDOkGjdNTa2Mwfn4Loqc/FfhTziWER3ELlpOWtC3DtIlbAnBGCt7MCdHdAxCk5Vgqxk7Jj9Zo2i3kDXXk1akmM4q6iE5jBqdTiPvWjYn4B4F60KigTcvU1HRSuGGSZ33hR3uLlo4w+9z/Tod4GUCCpfd+4TPImudqxBcsBS5ktGAZamN/wQlgB1AVmqJggOGTUXaoX1IlxkmV/Kw5tLHdKKt/KOpzIdzNLFsqHhxjCuM6PylJOTj+cpwXVknLg7w0xEkGwdQ71ZMT4kJhF7qJfhfCXY9Cz3BdC7NELccHlMT82NFLbV6KMZ39WVbDmLpFWY22YOy6LNsHVsViSU hg7NCMv2 xM2IDUnXxCD+PflhPMzkyM/cA2a00pwHUGOviYq8GAjtrguVzCDEDwCwHoCLNpwzJ5KWG0l2TV4sCuEpe8MO1M3Lu2WZUUr3wDnWJA8NuZ7dlNo7XBW4nTwMOHN6MB5bwVhmiup7vbYDb4WNw8lBL8xNggQLidPJdefGlEkijJh5BLQiCykghdNi0C+8wo+NYk2GEvRcmNmSKKLiA7t7/oTmBhTN6O/CdXDh0eHSX81/dWWs9OWc1t/dgEenlWX7KT/JgHP9VneHd7S/hklxwcftILDjzl2Zoom4D4XCjsKEQPS0tGBCG199zNxOEPOaYhCNqY6M3+Sz5d29r9ZcTQ30eD+Rb8aiRxpIVYIgAsnZx5ahYtLBvIm1bYh7OTf3Oi1UVO6Y4coc2KWIdWKtBpPdqCbOTJXvzFx2uo69DNsCByeDOtzUBx2/f+B1rvvJrcT6ea9jYvAz23QELpGfRMlYQ6G0AO/D9LJl0GEWi31+hIWepHuuWwa6fFw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 25 Nov 2024, at 16:01, Matthew Wilcox (Oracle) wrote: > We already have the concept of "frozen pages" (eg page_ref_freeze()), > so let's not complicate things by also having the concept of "unref > pages". > > Reviewed-by: David Hildenbrand > Reviewed-by: William Kucharski > Reviewed-by: Miaohe Lin > Reviewed-by: Muchun Song > Signed-off-by: Matthew Wilcox (Oracle) > --- > mm/internal.h | 2 +- > mm/page_alloc.c | 18 +++++++++--------- > mm/page_frag_cache.c | 6 +++--- > mm/swap.c | 2 +- > 4 files changed, 14 insertions(+), 14 deletions(-) Shouldn't the name be free_frozen_page() instead of free_frozen_pages()? It is still free a single page, right? If free_frozen_pages() is what we want, free_frozen_page_commit() should be free_frozen_pages_commit() to be consistent. Otherwise, LGTM. Reviewed-by: Zi Yan -- Best Regards, Yan, Zi