From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9BBCEC33C8C for ; Tue, 7 Jan 2020 12:04:56 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 5BE40207E0 for ; Tue, 7 Jan 2020 12:04:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lca.pw header.i=@lca.pw header.b="P6QMN6aA" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5BE40207E0 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lca.pw Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id EDDF28E002A; Tue, 7 Jan 2020 07:04:55 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E8EA98E001E; Tue, 7 Jan 2020 07:04:55 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DCB138E002A; Tue, 7 Jan 2020 07:04:55 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0090.hostedemail.com [216.40.44.90]) by kanga.kvack.org (Postfix) with ESMTP id C4A9B8E001E for ; Tue, 7 Jan 2020 07:04:55 -0500 (EST) Received: from smtpin15.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with SMTP id 6AE2B45A0 for ; Tue, 7 Jan 2020 12:04:55 +0000 (UTC) X-FDA: 76350706950.15.boat53_6522762eb405a X-HE-Tag: boat53_6522762eb405a X-Filterd-Recvd-Size: 3603 Received: from mail-qk1-f196.google.com (mail-qk1-f196.google.com [209.85.222.196]) by imf42.hostedemail.com (Postfix) with ESMTP for ; Tue, 7 Jan 2020 12:04:54 +0000 (UTC) Received: by mail-qk1-f196.google.com with SMTP id z14so41110687qkg.9 for ; Tue, 07 Jan 2020 04:04:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lca.pw; s=google; h=content-transfer-encoding:from:mime-version:subject:date:message-id :references:cc:in-reply-to:to; bh=MuqtmN0MFt5/BSWHnnCDhiDIpJDqzc52g9FK1ZZQ/fw=; b=P6QMN6aAicJ/3KyFVSfD6AG+DmfWQZzgY8AA09cSQlLZ5rOKsv7ArvS3svx5T2PcIi /7UfslQFUSs9wl1ph7rfZBWTobh5JjlMhtpG59SLutdcxIlWxax3Aei2ZMBfdjpo1nRa pvdgBEIpiD4OvY19ZR4uoFyy000WtBykqRSkZmD0f4Tw425jJFIa47z+WgtSGQTGfqYy adASraTaDcKBlUcb3G4ATnba/sBkugxxZiB4SyCuMvJgBRhAopfnUcfpbm1f8HeQQwB4 7CLyMhYtz+a8/+UbNjYT8UG17OMFEbyo1tRYbc5cFlHHsiASWFby1fkZiQGfwOXZOTOZ B+ug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:content-transfer-encoding:from:mime-version :subject:date:message-id:references:cc:in-reply-to:to; bh=MuqtmN0MFt5/BSWHnnCDhiDIpJDqzc52g9FK1ZZQ/fw=; b=tmK0Z6QHu4joyc3LFPidAERBBEKM6fE6EFaj+KiBna2vc9qjRdQhRYLIvrOW2fal8Y Uvz6Xmj5915L0LeMyDtcjWa9tiB9yZbvROSE9UHOFseX1hddKJ5wPamJHjzS3ApWaKn1 4IKOaaqWteppfUSOxa8NOwxcxfSv3P3APxdKeZoCMvrPHtWprY5S//yB8WgEmy7b0DF4 YBhJDF3xpqnKAUuzsCmyZHyAXVIG/LcgLqbzbvpaFmSrq4TJKc+TG/U9x26DLKfBxB26 sDO6IOwoQyDQekA52IPR06djPVAJBk1xjHxKR/pwYTNbvgWqjhwacKfhZ+MdeP/NWMLH Ci9A== X-Gm-Message-State: APjAAAVeddjC7Qh36KJNZgUXJpDkROp/Xk6Dh/kLVS2uGaWb34FC00+v 0Uw34Azhd02dLVTkHc35+0XNKWV/KA0= X-Google-Smtp-Source: APXvYqyhHiOIMlA7ezhoz8Y6cXcGrb4SZlqmg1I/AcA+ualt0ng8F6nmzlOHLfdO+Ihu8ZRZYZxiRA== X-Received: by 2002:ae9:eb48:: with SMTP id b69mr84907975qkg.43.1578398694077; Tue, 07 Jan 2020 04:04:54 -0800 (PST) Received: from [192.168.1.183] (pool-71-184-117-43.bstnma.fios.verizon.net. [71.184.117.43]) by smtp.gmail.com with ESMTPSA id u52sm25441921qta.23.2020.01.07.04.04.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 07 Jan 2020 04:04:53 -0800 (PST) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable From: Qian Cai Mime-Version: 1.0 (1.0) Subject: Re: [PATCH v2] slub: call BUG if next_object is not valid Date: Tue, 7 Jan 2020 07:04:52 -0500 Message-Id: References: <1578397918-22017-1-git-send-email-lijiazi@xiaomi.com> Cc: Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , lijiazi , linux-mm@kvack.org In-Reply-To: <1578397918-22017-1-git-send-email-lijiazi@xiaomi.com> To: lijiazi X-Mailer: iPhone Mail (17C54) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000005, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > On Jan 7, 2020, at 6:52 AM, lijiazi wrote: >=20 > If current object's memory is corrupted, there is a high > probability that next_objext stored in it will be rewritten as an > illegal value. It's better to check next_object this time than to > encounter a illegal pointer in next slub alloc like the following: I still have no answer for the previous question - how was current object=E2= =80=99s memory corrupted?=