From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 79C89C48BF6 for ; Thu, 29 Feb 2024 15:29:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EE9046B0092; Thu, 29 Feb 2024 10:29:01 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E99806B0095; Thu, 29 Feb 2024 10:29:01 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D39DD6B0098; Thu, 29 Feb 2024 10:29:01 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id C118C6B0092 for ; Thu, 29 Feb 2024 10:29:01 -0500 (EST) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 65EBB1C0EBC for ; Thu, 29 Feb 2024 15:29:01 +0000 (UTC) X-FDA: 81845224482.12.E48D6DA Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2062.outbound.protection.outlook.com [40.107.237.62]) by imf24.hostedemail.com (Postfix) with ESMTP id BE2A6180007 for ; Thu, 29 Feb 2024 15:28:58 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b=pMWYKGC6; dmarc=pass (policy=reject) header.from=nvidia.com; spf=pass (imf24.hostedemail.com: domain of ziy@nvidia.com designates 40.107.237.62 as permitted sender) smtp.mailfrom=ziy@nvidia.com; arc=pass ("microsoft.com:s=arcselector9901:i=1") ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1709220538; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=eahQHPXDqf//JLRcVijbi3Lj5d+GqCm5yV3cvARyWgY=; b=8C7WSu7Y/KSYcdC6wkPWrRAyXfl6hrT/jF2fVpg9MgNG3954zagdmrBvKk+etigT4waxg1 G89EGyQIF4VuDGDmZ/eX/3Fp4hqWRon0A78sB44/uQhNYVfJ7kEYwNBeCVoLJH16EStD8e jdbRFBzgthY4l7OUAFnO1TM6372zeKg= ARC-Authentication-Results: i=2; imf24.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b=pMWYKGC6; dmarc=pass (policy=reject) header.from=nvidia.com; spf=pass (imf24.hostedemail.com: domain of ziy@nvidia.com designates 40.107.237.62 as permitted sender) smtp.mailfrom=ziy@nvidia.com; arc=pass ("microsoft.com:s=arcselector9901:i=1") ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1709220538; a=rsa-sha256; cv=pass; b=EqYo4pkUF/JZb8e7NVInVcLOI0UwFIeBtNbrp8wzltvefjgIzL1JV89Hj+YJXxx0VPM6oh 6xP3yX5aLfT3ztjv7VlcHX+Tm2RDfKh+sfZKWi3aU2on3m/p9s//VNm9+a7cO8kpJTKPF7 Ed2l9sS9nb0MXZZa3tZB8G4mmjzj3ww= ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nXcGN7tgJG7b9X++edSi4wUALVAePU7bZ6z9gf6h6aXWGXUhdbhtabCte27/eXiY/m9qiUih0k1JwiiO1dPd3Zot5n8gBoip63XJK6UQVdjnPeXBnyfu4cL2Xon17Ay+I2aCQ4yfJvFqo3/T5Z5ikqLmBTFSEsRs/7ow7QJQ7M9Sy2V7T/cmUDFj0LphkZ8veZ77aIXsxX5wZmJKQOV4vPbxCxZ2jUqYTl1oZ201NeqGZoLH/RD1V8XBVLlzOhf9Mr2PByytbdEpW/JPoUfZq9+FBjTOozrnUfEM7y85YTihcUsRhafzLL5c49sGlc9hQip2kllEXSE2gpgPbOSK2A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=eahQHPXDqf//JLRcVijbi3Lj5d+GqCm5yV3cvARyWgY=; b=HHgNRO7sa5tHnR8U8szacA3Kc2LsmaCdTRTLmlKPsb22cs3b3h3wGyF1RCm51Hk61E9WE8bxCEvNr+KjPTP3xMQ3YKEAYy6pwgRGnz4LkrnEBb5AREVxVykWhbhevIr3dfVPj8jtCF+GSvNJmJQ+LqFDkaQErh9rp44Y7fK7nwUzGtTTYL/GTT9hhNyhSEmw7UUucOykrnuKDisY6ooVZDPtYVn5XnOVdRsh94/+kyBouZd8FPZgfGRJxqNMACntZ2gF507torchLetsplVM4NV6qYod+oyv0lKPrtURF1g0f+c8MPsDKvgz6iGYtpmn0K7K0lDo+BPuBtKvExqKrg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=eahQHPXDqf//JLRcVijbi3Lj5d+GqCm5yV3cvARyWgY=; b=pMWYKGC6x6AoBhaL3gFpZuM+5gjhMGNFOzUKSCYC/qVR0egrZmbaG18NIHZ/YLk8dJOzslqSu4hpZpCf8gHncnWFLku31mdXwsy0ftzKSEMS/R17OmbDtbdjrSIJBzOMHfv6zxCPnUE2gLXKAWl1G4KOBxKU85bILXEgeacpmUc/YTbVTpXJYOPfGdC65MvyQuAyI901466F24I/MtdwrfUxg53D85Oz2MMByaUE00Myw5V9MFGyTaXy1jN07LEh6VPeMuJQ4mkQptsmPF2WQS1zPy7hPGtutIlDsxMAl1uoL89uDNpY2u6w7Adey1OFGWmXwJ3R/Os5vjbi7wobIQ== Received: from DS7PR12MB5744.namprd12.prod.outlook.com (2603:10b6:8:73::18) by IA0PR12MB8930.namprd12.prod.outlook.com (2603:10b6:208:481::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7339.32; Thu, 29 Feb 2024 15:28:54 +0000 Received: from DS7PR12MB5744.namprd12.prod.outlook.com ([fe80::dc5c:2cf1:d5f5:9753]) by DS7PR12MB5744.namprd12.prod.outlook.com ([fe80::dc5c:2cf1:d5f5:9753%6]) with mapi id 15.20.7316.037; Thu, 29 Feb 2024 15:28:54 +0000 From: Zi Yan To: David Hildenbrand Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Barry Song , Vishal Moola , Ryan Roberts Subject: Re: [PATCH v1] mm: convert folio_estimated_sharers() to folio_likely_mapped_shared() Date: Thu, 29 Feb 2024 10:28:50 -0500 X-Mailer: MailMate (1.14r6018) Message-ID: In-Reply-To: <20240227201548.857831-1-david@redhat.com> References: <20240227201548.857831-1-david@redhat.com> Content-Type: multipart/signed; boundary="=_MailMate_01707C6A-30A7-49CE-9DC9-493ACB66318B_="; micalg=pgp-sha512; protocol="application/pgp-signature" X-ClientProxiedBy: MN2PR07CA0013.namprd07.prod.outlook.com (2603:10b6:208:1a0::23) To DS7PR12MB5744.namprd12.prod.outlook.com (2603:10b6:8:73::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS7PR12MB5744:EE_|IA0PR12MB8930:EE_ X-MS-Office365-Filtering-Correlation-Id: 1310d8a4-b4ad-4592-4b16-08dc393b23c2 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: NKf/cWlM07Rqp1dhArhzz5TeehxzNyhqLXYeVEgD8ZWnbh7rKXOYr6EmokDEJ4GeFdK3yUfcOFo8q+0mQlMgp0fARCuvErITnNY13cd+d9gFsRgNmyFt+0m3voQ7yhJDoT4N3JCPgRzmWpv3pV1zOmM+//ak4NwNv5ya7pizLFubxGqoLOjAW1UAI+ZskqWsFr+tYcE7E3yhSyYBQR3wiAclgc4kIPdZ0SeGqCS0/3N7M6XOkyL5YRpFL+X0KO3jrnjjcnwcHiUR2LlpP3zOk5NZuoBVy+c4ZIvdDElL4ihcMeWPGYNNao36zmMyokHmQ2LvpXIIxaGsGt8cTlhqucvFBkugiLhV4ilvWipjCg6avpTaLFns4AD5cfrsFInQ5dmXV9zsx/atxkQdOgOFJQ97l2OuUBu4A7GBETJjJNieyETMKEW2ekkF2y7mwLz9TJnksXJA9PDHRb/nxlB+RxkSv860hMcnMpoEMguvDpo13DEc0qKdlvf3pL3bfZsECngK+nj7+CeHhHr2cDWZMm8K6GotUyLpiK18g5gjZ7XVerxYli+XLa+WpwXtjOPWvzwgACEmRZYarrVprRpeCW/xynGtjpw3Fu1JE2nXAtOma/j0luDmH8KI1221akGnnhN5eff2P93WE/mLLEe3HQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR12MB5744.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?qlLgK5gx7QUb/CGVWDAQGVwGakw4wHLYPP5mhTISAZI2qYwcmh8dvDBQ0ECU?= =?us-ascii?Q?n2ksrizuqrrvqn0sDPIdsRbq65HFKJDNEIpWgPj0r79EXPEiSIc0gmjJoLrq?= =?us-ascii?Q?v9DIq+qubKL/uvmCVW2Fw0BiMaz+rOwK4VNibYgzAu7ZwtAhYVvwqLGbaNEj?= =?us-ascii?Q?387fYTq7Cj3L9S1k9gSixmEN1elEOF2lHvt94FYBzH9ZG3w9HdbbaoPXetHt?= =?us-ascii?Q?8wq1Qw59erUfZgHE7x0yeje3lPfMVw4GUMgvvycdLwURavmJxKUSNpoO3YQg?= =?us-ascii?Q?SlX3fNF4EEzHT1YaHzDyk+/b2PJXunZq/YcWSTyFYeNd70pvHEoVFid4HKew?= =?us-ascii?Q?XXdcRhM1KBrgpoYEKYFuxxSfCriluVuXEdJBM+RehOEYu+D9YiwQjytDz0Ix?= =?us-ascii?Q?8BSYisbF1BtxHsJ0oq5LXVbCE+MVYIOZRJlp0BiPqnDWMV8GpTCXm1aYjmBC?= =?us-ascii?Q?WnPf5xXgCZNgt6w8ql5ODMX9BjzOr0DBEy2DkA0lOrDUsLGB0rvcyqf/Pyo0?= =?us-ascii?Q?K6xhgB6QDe3snoehXIyY3I6WKbjyRGhZfgEgwDYZhaShOPZnkohulXheftMv?= =?us-ascii?Q?4QnXWJMEbkE3R3JOrZuNP1fqpViqUcLz0e62Cz5PZ/gLHwfmN/2dlblplq86?= =?us-ascii?Q?i7J+DBtbCYWEHN0qvZftUK9v7axmAiLRjO98q77HM1sLfs825LCnvi5CqB9h?= =?us-ascii?Q?XqI761Ahq2FPYExvJ27/usDxItMsLfMOvrml6RAFIh55/HyqvYLaK7i8JjWF?= =?us-ascii?Q?4Meb+LGz0Daq0IFqY8WyW6RoNW23rvmfN9ESfY7CzhrN+9z+/BY1NUDGDUUW?= =?us-ascii?Q?Ztog1/W3dk+9pq+mbmaqkXXXcnGXCjDvZ4lxEIylONpiQl+70a4OPPhbEKxp?= =?us-ascii?Q?h6tLmdTQMnWRcjTDrpaBKoJTkqErvP9rucl6ef7T9zxeiLw4b2khhyyUFg8T?= =?us-ascii?Q?uhX6BN+/YqHxhrG+1d7780UOfHqGlhefgg9pkk1yyGmi+3iz05FoosyWDY9D?= =?us-ascii?Q?JkWvIChf4apoaKYCCSfMt2iDVHyWLd0ZfI6eHzXGMBCo71fZ/6enOfMCdfqw?= =?us-ascii?Q?jGEwcpAwwvAVjjm8vpVBgaijcMud4wZpZEzsmnk3tFV1e5mMwOO/k3H9DJN6?= =?us-ascii?Q?unECvrZKFwribzv6pjTb3mOLoewiC/yLcaafA49GJxK94aeHUuCwkQIefGRS?= =?us-ascii?Q?DDMUi/ctzi91DJiMA0b8Jxl18e5k7jnsiIl1R090XEnc9Hr8B1Is/brETMBb?= =?us-ascii?Q?UwLiKeluLYxcHEpXUjiTevyIhBX14Hid/XRimuaxLVy0VfzigjPRuD2cGbAp?= =?us-ascii?Q?dtkk4FY64tCxLvPD4nzCUONFG3fnaPeMqi/7etNvbdjhMIBxNZYSRWQnfHMV?= =?us-ascii?Q?sWEIh0zBncP+wgXa/N42+F4tGXigFxBXGVq3pSthHZdShFdtRSxEFSZI/ADI?= =?us-ascii?Q?lLE98vUl8yEIxtMSQ2+lIRZlMiZ/5yaJW4RbhhIY2P2AtyHusdFBqwgwrxTJ?= =?us-ascii?Q?s8aqfpYGUlnNQx3bA9WvBCdUMNt3MgRMOtJOEaJkyZS086KrQBNpozXDu7u5?= =?us-ascii?Q?WW2nTJ+WdYNqUsUmSKo=3D?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1310d8a4-b4ad-4592-4b16-08dc393b23c2 X-MS-Exchange-CrossTenant-AuthSource: DS7PR12MB5744.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Feb 2024 15:28:54.6777 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ycLrllGdlsh0NrdJtEt1YQXmEqbjHbTCK1CNLOOjsWDSQfxuTvKa4S0uq/1O4Udn X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR12MB8930 X-Rspamd-Queue-Id: BE2A6180007 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: h83sqemqbig8unfxy1x3838qz4qoagwd X-HE-Tag: 1709220538-569292 X-HE-Meta: U2FsdGVkX1/GH2K09SBIUXidzvu/fqQUbkNz1pCZcvRx71O2g/9aQeiOpfjrCgYKWgp2cAisr30Q4ZB9tghP9DJxGcnDJRY7aS//es9On9QIhYQd//5yMEJVk5IF5MTkfSguP2WP9bfh2Gl8H/7UFcyAcawCXqT2tYvlp7ZTBv3V3UXH8chG/g7hfP0hN9SBxRbcrJ4L1pNW6q+lMU7SlvqDTVlCAz6ZzEFioHajTBmOg9amBtme99Gx4orfVvObHxgtjtHitteQl9n1Agpp7iQ/QE87Be+uzYXG3BoO3eDNcrh9P1sWHC4a8i+H6lJCEA0xRxcKZFMC0rWKyklRl6NiPTyp2Q27h+ifz6+h0q6d52/gol8S4xWp2zZaMEjRY0jJLkDPhD/Y4fHxC4zfiXSc5jUNiR4Jc3SZ6DKXiC+F1Dy+iGLA/1Au8znQsXkf6flMApzYXMhO8exTE+fTH8b2xT2gx2r5k6WkJup3lsqtLn15xfQds46A8f+9XIB/QSyke3J/imN1cM3PavFQSJTmQRG2WD3STbW3NQVH4+XRZ9zpH8V+JvacHu44EZHsLX3RCQpjFOu5zOro2CE2z9JeBjqU4UDbr44Br2LnC1OH7mhLhCh+vK8L5XzQOnRwbneAv4vexO0yyqYb5wc9wD4cF9ITUmavS4T8CP+dksSUvO85CVXcYPrarnb1yGRu38mYB1aHCas9UjNlcTXS1R71aRq/Czffi0UdrjO+1wfUkBh7u8wGqf0vHDW0TNna3CSoW3BDjF4AQ5HTyg7YMV+Xf/r+q66QnJBoXxbAROxyNpWsGNZmW+XLyPo+vxi5b1iMEzLpFhAXuOxmncKxljvJH9XtDABKGZzFhdBIEqZKhMvcuZCNCQOTGVUk9M36FGQB4NrAZc4lfH4ZLLN+ue+bkbq1nCkyEoHeSbTbtaDr11ntRrt7/m2wMVfiTtVpNeRlWw/ubfLe0Y7MGqL Xn6+ltxJ 2cZlbxXGwksX0LlXVr6bQLFUKngYBrryofi+m2CRP7Il4P4W7ytQjnQGmnCzyapIgNFxzbECQsb1TEJGuEqoyzPae7ckOjVfRfmE3+tKqhggFHx/fBhfJKZBhkrL3Xy08yX0JozSV6CZ7elMgd7vligGN3w== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: --=_MailMate_01707C6A-30A7-49CE-9DC9-493ACB66318B_= Content-Type: text/plain On 27 Feb 2024, at 15:15, David Hildenbrand wrote: > Callers of folio_estimated_sharers() only care about "mapped shared vs. > mapped exclusively", not the exact estimate of sharers. Let's consolidate > and unify the condition users are checking. While at it clarify the > semantics and extend the discussion on the fuzziness. > > Use the "likely mapped shared" terminology to better express what the > (adjusted) function actually checks. > > Whether a partially-mappable folio is more likely to not be partially > mapped than partially mapped is debatable. In the future, we might be able > to improve our estimate for partially-mappable folios, though. > > Note that we will now consistently detect "mapped shared" only if the > first subpage is actually mapped multiple times. When the first subpage > is not mapped, we will consistently detect it as "mapped exclusively". > This change should currently only affect the usage in > madvise_free_pte_range() and queue_folios_pte_range() for large folios: if > the first page was already unmapped, we would have skipped the folio. > > Cc: Barry Song > Cc: Vishal Moola (Oracle) > Cc: Ryan Roberts > Signed-off-by: David Hildenbrand > --- LGTM. Thanks for the documentation. Reviewed-by: Zi Yan -- Best Regards, Yan, Zi --=_MailMate_01707C6A-30A7-49CE-9DC9-493ACB66318B_= Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iQJDBAEBCgAtFiEE6rR4j8RuQ2XmaZol4n+egRQHKFQFAmXgorMPHHppeUBudmlk aWEuY29tAAoJEOJ/noEUByhUBwcP/Rt+az4MmAVLI8VgjNUHug5Fxl1LwkFz5aA9 5V0G2fnC2A/v8ndncu+C3RowNn1G6deDMEth9skQ1BvY5pIWMxLK6nwuwS10HQCN aBgXhKU0uXhxnKqMHLl/8SnbccvsxCu139nPEgo8mh8UOuLJG9mxh2wW59CsEL/A GrpseM47kUwLIVU6G7uvMywy7tJvggje71dF+Fn877pvPQY24kGVxZVIonezuOSm oWyuiARJ8RuRA2qN+X0/jHtJ5wqOsAHpGEZKCApeKW1HrlPLfT3KsPimSzx1BQ3l nG6VMM+qZVIfN39H1S7mil1xBnE+G5i7ZhIuA8io0IpqCzxzhakxZrexGs/Q3ho8 afzfgF2ctuVI6jqWJJfFI12P7mtl2fr7+ArKRzm4TOptV6dP0RfoPZUNnz55l1kZ JSf1in3v1aiJRynpYs/Llr/FA1mUUUhN68e1sNqkTzsCxJBRfo2IVbvB+vHqcs8t oGPrn30uOUxCHFE5B3LRqlA4PvaRX60maHwyVRjjGJTsNmJ3J1+g7tvfN2konnT2 rZpb55usPIbcs+J66xUwZo+aZhbbI9ZinFdBS57XOHQNB4t3QcMyU7IcvTpuvZIc Bw3JIl3wyNe0209ovdQ4SFR9aRq69Fef4Wqc2/MtaUn7WhqAyV4YTBRCVUcteYYH BxAk5e5I =kz5u -----END PGP SIGNATURE----- --=_MailMate_01707C6A-30A7-49CE-9DC9-493ACB66318B_=--