From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9FF8DC433EF for ; Thu, 21 Apr 2022 07:30:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 258036B0073; Thu, 21 Apr 2022 03:30:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 206F56B0074; Thu, 21 Apr 2022 03:30:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0336E6B0075; Thu, 21 Apr 2022 03:30:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.27]) by kanga.kvack.org (Postfix) with ESMTP id E87876B0073 for ; Thu, 21 Apr 2022 03:30:02 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id C8E6E25E2D for ; Thu, 21 Apr 2022 07:30:02 +0000 (UTC) X-FDA: 79380062244.15.0724A0C Received: from mx0a-00082601.pphosted.com (mx0a-00082601.pphosted.com [67.231.145.42]) by imf12.hostedemail.com (Postfix) with ESMTP id E17A740023 for ; Thu, 21 Apr 2022 07:29:58 +0000 (UTC) Received: from pps.filterd (m0148461.ppops.net [127.0.0.1]) by mx0a-00082601.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 23KILQ5D005924; Thu, 21 Apr 2022 00:29:26 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fb.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : mime-version; s=facebook; bh=SytBv/fTl3s52/xp64X2smoApsbas+GKqzKLLtoThjw=; b=qbnfNXKoEzUhNcsPw7JgCtcse8ce0/wfv0pAoD2OFcqFpPhllXywFP2+roZPdHbodV3s iIV0XQi72J3bJkXcEsGmO6GmtogslcS9rp9fQ7+VLqkf2CRP+3nX2JBPUUUHmsQqFxVh Y3unjqPj3PEHXFy/MxBVEG8J/V8z1tTpeo8= Received: from nam10-mw2-obe.outbound.protection.outlook.com (mail-mw2nam10lp2104.outbound.protection.outlook.com [104.47.55.104]) by mx0a-00082601.pphosted.com (PPS) with ESMTPS id 3fj7s40uk7-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 21 Apr 2022 00:29:25 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VrBGGJWL1nlIhUnnMWNbeUjTc0R0VIriPm2BBuUU2wncNK7i7356EfNWTbeEP7MH7Z0hQYUpPTWY1BgQ1N29obbKiBx/SniMXtLS/d+5PF3k3Z7vU7FXulaAHBGjE0FFT4LrQPU/7s7Phx/+QuQ0VNbkXGf4CF6RIenEk20G4jIGRHCpsqjxt7cEsrQue/jqSQ0QFr0RHrEvzNlVROXytyuU4+m9EjzYa/wVPpsYxxL98otIeCa87SAUTZfct+ShAxQd8P3ssp4EZFA+8H92Du/VmO3U7Q/i/jYh9pN0TcyNtzKPtFRP8RYRAseWNBDg0FB6ZTGOErxV7O0oR6cSEg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=SytBv/fTl3s52/xp64X2smoApsbas+GKqzKLLtoThjw=; b=Qh+pjesSw77f5F2EMKRHT/17aIsKxqvhExJS/P2dO9nkuulW8L/ZyBUoMwJGK30BJKmPXuF8p6SY4EG/UduVF0z/tvp9DVVcVKED10d7xrTEQtcFrjTq2TU+Xx98ANly+AMkPjTBVkuCLmuC9RoTTZaxm9/bQso39xER3cE25cWbz7SzCC511ywTu0fmLSYYvXdi/47oR/zuB5oVn5ecM5fj7/QWvQouHJFeOOVEbuyGI658tFLjZLVNWoKIR8hgwPMaD1x+DDKD/d7PJX5I0qJpjkSnLhcHP0dIgHBcAmnLGAR0HRAPbmfNU2jRTw6KsOepY1koJQMPhbX9YE1ucg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=fb.com; dmarc=pass action=none header.from=fb.com; dkim=pass header.d=fb.com; arc=none Received: from SA1PR15MB5109.namprd15.prod.outlook.com (2603:10b6:806:1dc::10) by MW4PR15MB5134.namprd15.prod.outlook.com (2603:10b6:303:182::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.13; Thu, 21 Apr 2022 07:29:23 +0000 Received: from SA1PR15MB5109.namprd15.prod.outlook.com ([fe80::20d2:26a2:6cb1:3c4b]) by SA1PR15MB5109.namprd15.prod.outlook.com ([fe80::20d2:26a2:6cb1:3c4b%7]) with mapi id 15.20.5186.014; Thu, 21 Apr 2022 07:29:23 +0000 From: Song Liu To: Linus Torvalds CC: Alexei Starovoitov , Mike Rapoport , "Edgecombe, Rick P" , "mcgrof@kernel.org" , "linux-kernel@vger.kernel.org" , "bpf@vger.kernel.org" , "hch@infradead.org" , "ast@kernel.org" , "daniel@iogearbox.net" , "linux-mm@kvack.org" , "song@kernel.org" , Kernel Team , "pmladek@suse.com" , "akpm@linux-foundation.org" , "hpa@zytor.com" , "dborkman@redhat.com" , "edumazet@google.com" , "bp@alien8.de" , "mbenes@suse.cz" , "imbrenda@linux.ibm.com" Subject: Re: [PATCH v4 bpf 0/4] vmalloc: bpf: introduce VM_ALLOW_HUGE_VMAP Thread-Topic: [PATCH v4 bpf 0/4] vmalloc: bpf: introduce VM_ALLOW_HUGE_VMAP Thread-Index: AQHYUOjRr/eYt5HVI0ucQZg4JV/u/6zxVckAgACoe4CAAPedAIAACgKAgAAgN4CAAlYOAIAA9TuAgAAUC4CAAD2oAIAA23uAgAAKuICAAHT81IAAz6kAgAEZSgA= Date: Thu, 21 Apr 2022 07:29:23 +0000 Message-ID: References: <4AD023F9-FBCE-4C7C-A049-9292491408AA@fb.com> <88eafc9220d134d72db9eb381114432e71903022.camel@intel.com> <20220420020311.6ojfhcooumflnbbk@MacBook-Pro.local.dhcp.thefacebook.com> <3F75142B-3E87-4195-A026-3A7F1E595960@fb.com> In-Reply-To: <3F75142B-3E87-4195-A026-3A7F1E595960@fb.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: yes X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.80.82.1.1) x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: d6b97881-10ec-4477-2d28-08da2368a890 x-ms-traffictypediagnostic: MW4PR15MB5134:EE_ x-microsoft-antispam-prvs: x-fb-source: Internal x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: /Iefpyc/zRnm8nIrECZMP3dXpFHyUmP1JFwoxKwRyXyYXGbbkMnHacyYESo5zxiLtqrnxt4A4OguDdvkI7oGX7wVks0WcL3Tl4ZLBELeVuLSZsqU6nZdtnKiFaRiK+b5d65G98lwHs3j1LdcN4JO21pzA6TmsW3K+D0IR6PHnG8QbrLiM0Gfm0WyiZ7QR/+Em69wX17OxRYpWgHIWYwdfUKQHQXidM2HZvS8J1X4pGwKZ22APS8nL4xtY3UtqFpet8dSAmH4k+WySl4rqsMOKfpWz1oZBLnZTu/e9o9I5L0ELwRrTOd6MegaaaT5kZUQ/1gfZZEi9OgzX+GKdZ2BLSe1/cN7HL0aO6X5V0DSUrEHjU2gQJAExw5pHjx8cZ5RfQ1bnXOIZ7Zj/YjiyyX9iulJgj+5xV712ufiyDzg4pyrwB2LYEgiIxcr1PBkNrsJH80wS3Z5WO1EmJoY33BoGwEby07jKWgKEHivyzoL3HUvI38ZVD+pmRfyVc5jlERiqpfeWrfCGzHkbmm9Xu/Zi7ke6DRlxQpCOM8lL0Ay9DuYkjaIVeacZeWNeM8WtO0D6jmLbzOZe8L4D+NEoIxpeR+weYN8Xx6hjlkW+4q5P+MTwfDAVFpGhT7ASX2drsc8HWsLrt54ZhmhQkTsTG2lfUkY9MYNeeuMj/MLU7hgY7caONetmXeCEDT+Jz+dEJV6IdnFJLZTq+uaJ2Id+XWzKW/oOw4Y+Qvr5mmg4UffTuYzdnXtvvQjd35r1Pz4DywEQewKJCa0e8VpXn91EqDvfQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SA1PR15MB5109.namprd15.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(4326008)(66446008)(64756008)(91956017)(122000001)(66556008)(71200400001)(6486002)(316002)(66476007)(76116006)(6916009)(54906003)(38100700002)(99936003)(33656002)(66946007)(36756003)(8676002)(86362001)(38070700005)(2616005)(6512007)(186003)(8936002)(7416002)(508600001)(6506007)(53546011)(5660300002)(2906002)(14583001)(45980500001);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?ORxLS+PTIdf+nM5sVj8SK/H0F7qXvyN0I/M+ad9AJyuGIRwui2iyXZovsLw/?= =?us-ascii?Q?iDDqBgZ3cjJ+xNz0s2o/+Af7Q5H3+197JBykNQGNFYO3zsKe1OOih2I/x1g8?= =?us-ascii?Q?bZwYMGg0mS4JOzoyujyjnImjQi3dfVAsf7mH3Qz70Mzb/BhoHPDyRdmcx36k?= =?us-ascii?Q?q0ofp0yN7Ilpqyii8BV1k0LV29b1tyfRxb1WW7VLFXN8vE3QxWlf2feJW+sR?= =?us-ascii?Q?8hmSRiQm5Kpp9zCnAOK7rLPrx8N6dDfICawImsD6EeT2MySBV8UbHA8SOi5K?= =?us-ascii?Q?K18bZnkPf1+KP3ir8tCwKOc3plml8R5IXaiQDAk38xL0zirVs39O7vQPtV4M?= =?us-ascii?Q?NGNKDenirLKqSxCeCmkcug7G19iHQiIsEZ2Iw2b1x+0aLMbnrAe4dvBCzaLj?= =?us-ascii?Q?HB+J8pFNwiPYIY0GeA8tB3vutT4HI783cGQslrCroiDesIrLHpz3CZth0oWT?= =?us-ascii?Q?0qenufXD7EdPYUp1oqvfQn861BeF7xyu0REKW+3Mc4d8V15diLeOeDyhRe4M?= =?us-ascii?Q?oeumEai+WrTrK7qJKYuS7PSoQbetSFaoJuRmxTCpAqzF3Sd7RhFPdBVtt3PA?= =?us-ascii?Q?Gwg+eNFGBu0KeNGuHC8I0By7dfZ0OOqM15Y/QZm29UHv4g6hjuWYH4DxAMNQ?= =?us-ascii?Q?dtLch/j15r4XiEeCnvrCx4RzMhDVL2e+dKhfPFwb/0PJfQOIiT2c4QxuV4fS?= =?us-ascii?Q?PN4jZEaFoYehad+JN8w/qzP0ALIHpv2uP/NVakHgWnEnbypcmr2JJChn98Jd?= =?us-ascii?Q?QkrEUKYgEmHqtr33s7YA0p/w0XKDYTWu95Hpk+nfBzMCNNw9dhOtoADe2K7B?= =?us-ascii?Q?eybnTDaKC8YI+0WObyprugCWwr1RmhZuCaKM92vPMxMSn6zjOqqAoCCijRaY?= =?us-ascii?Q?/D2RVSXvU56B/LPUWUwb+s2VjQGIVDNpWZhTR6Mu5a+woGmGITikNKbDYCq1?= =?us-ascii?Q?S3CG50Hy3Fmn4zwp11f7yjCKukr5uDqhx5zc9hywWQA91x9Ot/p8gk3ytZ/i?= =?us-ascii?Q?CsUp/V0OwOpgsDy9hs9rj01mc129W7opa35MUT2Fznm33aXamP+VXgSxRITt?= =?us-ascii?Q?ni372y7AHdhBKkMIXQH26LZv7KncYqXsU5fSgyX6uvIm5ttzg5Xtu1VL1RCa?= =?us-ascii?Q?nb/pZ66DOD00O+AtX+fZ3xOrdAJFS0kubEgngociTCgoUYd5QUoxP1MX+z7T?= =?us-ascii?Q?mOkRtjB0xQZiL1q1XV4duZepf30ic9v2wzN8pN0E4yvRxu2u5wv4F5w/oRfR?= =?us-ascii?Q?NZ+j5DykQzLvK4aVHxqNukBYZxgORROQVjRXpVPTSMLA9fHk/qk5IE+//2s4?= =?us-ascii?Q?u9kIjj+DefIe8DXECLzr8vGbz7Wd95W9qjvxJl6aMU26Yq1L6z0Dv0lIKYHA?= =?us-ascii?Q?sauAzyKsY38lHnui5lPydEtexSWH4DOihOiHDx948/95kSG7ivFNFozChHSU?= =?us-ascii?Q?MriK33Ja/HdLrrn9Tz8g4Sw+0NU3yRsxxmNgMCM5hL3LJ0l8NnoIJx70KGUT?= =?us-ascii?Q?wSFXKgDEdRiMJjIgBPiY+hvxHKKzHTmiW+Ux3A/R+v2FsJTMNYpmIEm3C2TC?= =?us-ascii?Q?bRgK/sE+2SKCCHJl5yqJeQn/xKeegZo05zzePcIdymLhaNzPwmxGPCOHRP+t?= =?us-ascii?Q?KXr83Z2fad0KeulCBM2+MuYc+ae3pXEtA/4Y5qtssAimGLCqI6lF/JYOf8Ud?= =?us-ascii?Q?Od3vNBvPKEQ+kJK0TY8IZXkiixfPUr/RlbqSLB8O8aC5OtIwHRMGX4g5ZNUa?= =?us-ascii?Q?h7SKiPyQypqHsBACROYq1hWCeIjEw40uszjZB4u65pdXzQ0rEBU6?= Content-Type: multipart/mixed; boundary="_004_B070EF43F4E042E4A0AFD7FAA99D5C82fbcom_" MIME-Version: 1.0 X-OriginatorOrg: fb.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SA1PR15MB5109.namprd15.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: d6b97881-10ec-4477-2d28-08da2368a890 X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Apr 2022 07:29:23.7626 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: M3c3L04c/tCVjezufJPvDXmWpI4hsmRdfKtRGYvLJefFy6TXTTlxiLP/B3iVmERYy+Siclf8bwrogRAmSnoOjA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR15MB5134 X-Proofpoint-ORIG-GUID: Jt2MVlmE6uvgCFydWOk3JLK_ujupqLjg X-Proofpoint-GUID: Jt2MVlmE6uvgCFydWOk3JLK_ujupqLjg X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.858,Hydra:6.0.486,FMLib:17.11.64.514 definitions=2022-04-20_06,2022-04-20_01,2022-02-23_01 Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=fb.com header.s=facebook header.b=qbnfNXKo; dmarc=pass (policy=reject) header.from=fb.com; spf=none (imf12.hostedemail.com: domain of "prvs=5110c58c6a=songliubraving@fb.com" has no SPF policy when checking 67.231.145.42) smtp.mailfrom="prvs=5110c58c6a=songliubraving@fb.com" X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: E17A740023 X-Stat-Signature: 3j8z3pjc73tg8u57995dj8qo3womebpe X-HE-Tag: 1650526198-585005 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: --_004_B070EF43F4E042E4A0AFD7FAA99D5C82fbcom_ Content-Type: multipart/alternative; boundary="_000_B070EF43F4E042E4A0AFD7FAA99D5C82fbcom_" --_000_B070EF43F4E042E4A0AFD7FAA99D5C82fbcom_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable > On Apr 20, 2022, at 7:42 AM, Song Liu wrote: > > Hi Linus, > >> On Apr 19, 2022, at 7:18 PM, Linus Torvalds wrote: >> >> On Tue, Apr 19, 2022 at 7:03 PM Alexei Starovoitov >> wrote: >>> >>> Here is the quote from Song's cover letter for bpf_prog_pack series: >> >> I care about performance as much as the next person, but I care about >> correctness too. >> >> That large-page code was a disaster, and was buggy and broken. >> >> And even with those four patches, it's still broken. >> >> End result: there's no way that thigh gets re-enabled without the >> correctness being in place. >> >> At a minimum, to re-enable it, it needs (a) that zeroing and (b) >> actual numbers on real loads. (not some artificial benchmark). >> >> Because without (a) there's no way in hell I'll enable it. >> >> And without (b), "performance" isn't actually an argument. > > I will send patch to do (a) later this week. > > For (b), we have seen direct map fragmentation causing visible > performance drop for our major services. This is the shadow > production benchmark, so it is not possible to run it out of > our data centers. Tracing showed that BPF program was the top > trigger of these direct map splits. Attached is the patch for (a). I also sent it to the mail list. Thanks, Song --_000_B070EF43F4E042E4A0AFD7FAA99D5C82fbcom_ Content-Type: text/html; charset="us-ascii" Content-ID: Content-Transfer-Encoding: quoted-printable


> On Apr 20, 2022, at 7:42 AM, Song Liu <songliubraving@fb.com> wr= ote:
>
> Hi Linus,
>
>> On Apr 19, 2022, at 7:18 PM, Linus Torvalds <torvalds@linux-fou= ndation.org> wrote:
>>
>> On Tue, Apr 19, 2022 at 7:03 PM Alexei Starovoitov
>> <alexei.starovoitov@gmail.com> wrote:
>>>
>>> Here is the quote from Song's cover letter for bpf_prog_pack s= eries:
>>
>> I care about performance as much as the next person, but I care ab= out
>> correctness too.
>>
>> That large-page code was a disaster, and was buggy and broken.
>>
>> And even with those four patches, it's still broken.
>>
>> End result: there's no way that thigh gets re-enabled without the<= br> >> correctness being in place.
>>
>> At a minimum, to re-enable it, it needs (a) that zeroing and (b) >> actual numbers on real loads. (not some artificial benchmark).
>>
>> Because without (a) there's no way in hell I'll enable it.
>>
>> And without (b), "performance" isn't actually an argumen= t.
>
> I will send patch to do (a) later this week.
>
> For (b), we have seen direct map fragmentation causing visible
> performance drop for our major services. This is the shadow
> production benchmark, so it is not possible to run it out of
> our data centers. Tracing showed that BPF program was the top
> trigger of these direct map splits.

Attached is the patch for (a). I also sent it to the mail list.

Thanks,
Song





--_000_B070EF43F4E042E4A0AFD7FAA99D5C82fbcom_-- --_004_B070EF43F4E042E4A0AFD7FAA99D5C82fbcom_ Content-Type: application/octet-stream; name="0001-bpf-invalidate-unused-part-of-bpf_prog_pack.patch" Content-Description: 0001-bpf-invalidate-unused-part-of-bpf_prog_pack.patch Content-Disposition: attachment; filename="0001-bpf-invalidate-unused-part-of-bpf_prog_pack.patch"; size=4638; creation-date="Thu, 21 Apr 2022 07:29:23 GMT"; modification-date="Thu, 21 Apr 2022 07:29:23 GMT" Content-ID: <6FF0BA4426A400499D47516C35D9C489@namprd15.prod.outlook.com> Content-Transfer-Encoding: base64 RnJvbSBlMWMxYTA5NGZmYzFiODJmMWQ3NjM2ZjMzZDk5MGE0M2NmNmE3ZmY4IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBTb25nIExpdSA8c29uZ0BrZXJuZWwub3JnPgpEYXRlOiBXZWQs IDIwIEFwciAyMDIyIDIzOjU4OjI4IC0wNzAwClN1YmplY3Q6IFtQQVRDSCBicGZdIGJwZjogaW52 YWxpZGF0ZSB1bnVzZWQgcGFydCBvZiBicGZfcHJvZ19wYWNrCgpicGZfcHJvZ19wYWNrIGVuYWJs ZXMgc2hhcmluZyBodWdlIHBhZ2VzIGFtb25nIG11bHRpcGxlIEJQRiBwcm9ncmFtcy4KVGhlc2Ug cGFnZXMgYXJlIG1hcmtlZCBhcyBleGVjdXRhYmxlLCBidXQgc29tZSBwYXJ0IG9mIHRoZXNlIGh1 Z2UgcGFnZQptYXkgbm90IGNvbnRhaW4gcHJvcGVyIEJQRiBwcm9ncmFtcy4gVG8gbWFrZSB0aGVz ZSBwYWdlcyBzYWZlLCBmaWxsIHN1Y2gKdW51c2VkIHBhcnQgb2YgdGhlc2UgcGFnZXMgd2l0aCBp bnZhbGlkIGluc3RydWN0aW9ucy4gVGhpcyBpcyBkb25lIHdoZW4gYQpwYWNrIGlzIGZpcnN0IGFs bG9jYXRlZCwgYW5kIHdoZW4gYSBicGYgcHJvZ3JhbSBpcyBmcmVlZC4uCgpGaXhlczogNTc2MzEw NTRmYWU2ICgiYnBmOiBJbnRyb2R1Y2UgYnBmX3Byb2dfcGFjayBhbGxvY2F0b3IiKQpGaXhlczog MzNjOTgwNTg2MGU1ICgiYnBmOiBJbnRyb2R1Y2UgYnBmX2ppdF9iaW5hcnlfcGFja19bYWxsb2N8 ZmluYWxpemV8ZnJlZV0iKQpTaWduZWQtb2ZmLWJ5OiBTb25nIExpdSA8c29uZ0BrZXJuZWwub3Jn PgotLS0KIGFyY2gveDg2L25ldC9icGZfaml0X2NvbXAuYyB8IDIyICsrKysrKysrKysrKysrKysr KysrKysKIGluY2x1ZGUvbGludXgvYnBmLmggICAgICAgICB8ICAyICsrCiBrZXJuZWwvYnBmL2Nv cmUuYyAgICAgICAgICAgfCAyMCArKysrKysrKysrKysrKysrLS0tLQogMyBmaWxlcyBjaGFuZ2Vk LCA0MCBpbnNlcnRpb25zKCspLCA0IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL2FyY2gveDg2 L25ldC9icGZfaml0X2NvbXAuYyBiL2FyY2gveDg2L25ldC9icGZfaml0X2NvbXAuYwppbmRleCA4 ZmUzNWVkMTFmZDYuLjU3MDk5ZDg5ZjJiZiAxMDA2NDQKLS0tIGEvYXJjaC94ODYvbmV0L2JwZl9q aXRfY29tcC5jCisrKyBiL2FyY2gveDg2L25ldC9icGZfaml0X2NvbXAuYwpAQCAtMjI4LDYgKzIy OCwyOCBAQCBzdGF0aWMgdm9pZCBqaXRfZmlsbF9ob2xlKHZvaWQgKmFyZWEsIHVuc2lnbmVkIGlu dCBzaXplKQogCW1lbXNldChhcmVhLCAweGNjLCBzaXplKTsKIH0KIAorI2RlZmluZSBJTlZBTElE X0JVRl9TSVpFIFBBR0VfU0laRQorc3RhdGljIGNoYXIgaW52YWxpZF9pbnNuX2J1ZltJTlZBTElE X0JVRl9TSVpFXTsKKworc3RhdGljIGludCBfX2luaXQgYnBmX2luaXRfaW52YWxpZF9pbnNuX2J1 Zih2b2lkKQoreworCWppdF9maWxsX2hvbGUoaW52YWxpZF9pbnNuX2J1ZiwgSU5WQUxJRF9CVUZf U0laRSk7CisJcmV0dXJuIDA7Cit9CitwdXJlX2luaXRjYWxsKGJwZl9pbml0X2ludmFsaWRfaW5z bl9idWYpOworCit2b2lkIGJwZl9hcmNoX2ludmFsaWRhdGVfdGV4dCh2b2lkICpkc3QsIHNpemVf dCBsZW4pCit7CisJc2l6ZV90IGkgPSAwOworCisJd2hpbGUgKGkgPCBsZW4pIHsKKwkJc2l6ZV90 IHMgPSBtaW5fdChzaXplX3QsIGxlbiAtIGksIElOVkFMSURfQlVGX1NJWkUpOworCisJCWJwZl9h cmNoX3RleHRfY29weShkc3QgKyBpLCBpbnZhbGlkX2luc25fYnVmLCBzKTsKKwkJaSArPSBzOwor CX0KK30KKwogc3RydWN0IGppdF9jb250ZXh0IHsKIAlpbnQgY2xlYW51cF9hZGRyOyAvKiBFcGls b2d1ZSBjb2RlIG9mZnNldCAqLwogCmRpZmYgLS1naXQgYS9pbmNsdWRlL2xpbnV4L2JwZi5oIGIv aW5jbHVkZS9saW51eC9icGYuaAppbmRleCBiZGI1Mjk4NzM1Y2UuLjIxNTczOTJhOTRkMSAxMDA2 NDQKLS0tIGEvaW5jbHVkZS9saW51eC9icGYuaAorKysgYi9pbmNsdWRlL2xpbnV4L2JwZi5oCkBA IC0yMzgyLDYgKzIzODIsOCBAQCBpbnQgYnBmX2FyY2hfdGV4dF9wb2tlKHZvaWQgKmlwLCBlbnVt IGJwZl90ZXh0X3Bva2VfdHlwZSB0LAogCiB2b2lkICpicGZfYXJjaF90ZXh0X2NvcHkodm9pZCAq ZHN0LCB2b2lkICpzcmMsIHNpemVfdCBsZW4pOwogCit2b2lkIGJwZl9hcmNoX2ludmFsaWRhdGVf dGV4dCh2b2lkICpkc3QsIHNpemVfdCBsZW4pOworCiBzdHJ1Y3QgYnRmX2lkX3NldDsKIGJvb2wg YnRmX2lkX3NldF9jb250YWlucyhjb25zdCBzdHJ1Y3QgYnRmX2lkX3NldCAqc2V0LCB1MzIgaWQp OwogCmRpZmYgLS1naXQgYS9rZXJuZWwvYnBmL2NvcmUuYyBiL2tlcm5lbC9icGYvY29yZS5jCmlu ZGV4IGIyYTYzNGQwZjg0Mi4uM2Y4YmRiYzBlOTk0IDEwMDY0NAotLS0gYS9rZXJuZWwvYnBmL2Nv cmUuYworKysgYi9rZXJuZWwvYnBmL2NvcmUuYwpAQCAtODczLDcgKzg3Myw3IEBAIHN0YXRpYyBz aXplX3Qgc2VsZWN0X2JwZl9wcm9nX3BhY2tfc2l6ZSh2b2lkKQogCXJldHVybiBzaXplOwogfQog Ci1zdGF0aWMgc3RydWN0IGJwZl9wcm9nX3BhY2sgKmFsbG9jX25ld19wYWNrKHZvaWQpCitzdGF0 aWMgc3RydWN0IGJwZl9wcm9nX3BhY2sgKmFsbG9jX25ld19wYWNrKGJwZl9qaXRfZmlsbF9ob2xl X3QgYnBmX2ZpbGxfaWxsX2luc25zKQogewogCXN0cnVjdCBicGZfcHJvZ19wYWNrICpwYWNrOwog CkBAIC04ODYsNiArODg2LDcgQEAgc3RhdGljIHN0cnVjdCBicGZfcHJvZ19wYWNrICphbGxvY19u ZXdfcGFjayh2b2lkKQogCQlrZnJlZShwYWNrKTsKIAkJcmV0dXJuIE5VTEw7CiAJfQorCWJwZl9m aWxsX2lsbF9pbnNucyhwYWNrLT5wdHIsIGJwZl9wcm9nX3BhY2tfc2l6ZSk7CiAJYml0bWFwX3pl cm8ocGFjay0+Yml0bWFwLCBicGZfcHJvZ19wYWNrX3NpemUgLyBCUEZfUFJPR19DSFVOS19TSVpF KTsKIAlsaXN0X2FkZF90YWlsKCZwYWNrLT5saXN0LCAmcGFja19saXN0KTsKIApAQCAtODk0LDcg Kzg5NSw3IEBAIHN0YXRpYyBzdHJ1Y3QgYnBmX3Byb2dfcGFjayAqYWxsb2NfbmV3X3BhY2sodm9p ZCkKIAlyZXR1cm4gcGFjazsKIH0KIAotc3RhdGljIHZvaWQgKmJwZl9wcm9nX3BhY2tfYWxsb2Mo dTMyIHNpemUpCitzdGF0aWMgdm9pZCAqYnBmX3Byb2dfcGFja19hbGxvYyh1MzIgc2l6ZSwgYnBm X2ppdF9maWxsX2hvbGVfdCBicGZfZmlsbF9pbGxfaW5zbnMpCiB7CiAJdW5zaWduZWQgaW50IG5i aXRzID0gQlBGX1BST0dfU0laRV9UT19OQklUUyhzaXplKTsKIAlzdHJ1Y3QgYnBmX3Byb2dfcGFj ayAqcGFjazsKQEAgLTkyMiw3ICs5MjMsNyBAQCBzdGF0aWMgdm9pZCAqYnBmX3Byb2dfcGFja19h bGxvYyh1MzIgc2l6ZSkKIAkJCWdvdG8gZm91bmRfZnJlZV9hcmVhOwogCX0KIAotCXBhY2sgPSBh bGxvY19uZXdfcGFjaygpOworCXBhY2sgPSBhbGxvY19uZXdfcGFjayhicGZfZmlsbF9pbGxfaW5z bnMpOwogCWlmICghcGFjaykKIAkJZ290byBvdXQ7CiAKQEAgLTk2NSw2ICs5NjYsNyBAQCBzdGF0 aWMgdm9pZCBicGZfcHJvZ19wYWNrX2ZyZWUoc3RydWN0IGJwZl9iaW5hcnlfaGVhZGVyICpoZHIp CiAJbmJpdHMgPSBCUEZfUFJPR19TSVpFX1RPX05CSVRTKGhkci0+c2l6ZSk7CiAJcG9zID0gKCh1 bnNpZ25lZCBsb25nKWhkciAtICh1bnNpZ25lZCBsb25nKXBhY2tfcHRyKSA+PiBCUEZfUFJPR19D SFVOS19TSElGVDsKIAorCWJwZl9hcmNoX2ludmFsaWRhdGVfdGV4dChoZHIsIGhkci0+c2l6ZSk7 CiAJYml0bWFwX2NsZWFyKHBhY2stPmJpdG1hcCwgcG9zLCBuYml0cyk7CiAJaWYgKGJpdG1hcF9m aW5kX25leHRfemVyb19hcmVhKHBhY2stPmJpdG1hcCwgYnBmX3Byb2dfY2h1bmtfY291bnQoKSwg MCwKIAkJCQkgICAgICAgYnBmX3Byb2dfY2h1bmtfY291bnQoKSwgMCkgPT0gMCkgewpAQCAtMTEw Myw3ICsxMTA1LDcgQEAgYnBmX2ppdF9iaW5hcnlfcGFja19hbGxvYyh1bnNpZ25lZCBpbnQgcHJv Z2xlbiwgdTggKippbWFnZV9wdHIsCiAKIAlpZiAoYnBmX2ppdF9jaGFyZ2VfbW9kbWVtKHNpemUp KQogCQlyZXR1cm4gTlVMTDsKLQlyb19oZWFkZXIgPSBicGZfcHJvZ19wYWNrX2FsbG9jKHNpemUp OworCXJvX2hlYWRlciA9IGJwZl9wcm9nX3BhY2tfYWxsb2Moc2l6ZSwgYnBmX2ZpbGxfaWxsX2lu c25zKTsKIAlpZiAoIXJvX2hlYWRlcikgewogCQlicGZfaml0X3VuY2hhcmdlX21vZG1lbShzaXpl KTsKIAkJcmV0dXJuIE5VTEw7CkBAIC0xMjA0LDYgKzEyMDYsMTYgQEAgdm9pZCBfX3dlYWsgYnBm X2ppdF9mcmVlKHN0cnVjdCBicGZfcHJvZyAqZnApCiAJYnBmX3Byb2dfdW5sb2NrX2ZyZWUoZnAp OwogfQogCit2b2lkIF9fd2VhayBicGZfYXJjaF9pbnZhbGlkYXRlX3RleHQodm9pZCAqZHN0LCBz aXplX3QgbGVuKQoreworCWNoYXIgYnVmWzFdID0ge307CisJaW50IGk7CisKKwlXQVJOX09OQ0Uo MSwgIlBsZWFzZSBvdmVycmlkZSBicGZfYXJjaF9pbnZhbGlkYXRlX3RleHQgZm9yIGJwZl9wcm9n X3BhY2tcbiIpOworCWZvciAoaSA9IDA7IGkgPCBsZW47IGkrKykKKwkJYnBmX2FyY2hfdGV4dF9j b3B5KGRzdCArIGksIGJ1ZiwgMSk7Cit9CisKIGludCBicGZfaml0X2dldF9mdW5jX2FkZHIoY29u c3Qgc3RydWN0IGJwZl9wcm9nICpwcm9nLAogCQkJICBjb25zdCBzdHJ1Y3QgYnBmX2luc24gKmlu c24sIGJvb2wgZXh0cmFfcGFzcywKIAkJCSAgdTY0ICpmdW5jX2FkZHIsIGJvb2wgKmZ1bmNfYWRk cl9maXhlZCkKLS0gCjIuMzAuMgoK --_004_B070EF43F4E042E4A0AFD7FAA99D5C82fbcom_--