From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 86A97C001DF for ; Sun, 30 Jul 2023 22:42:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DCDC56B0092; Sun, 30 Jul 2023 18:42:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D7D2D280006; Sun, 30 Jul 2023 18:42:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C6D226B0095; Sun, 30 Jul 2023 18:42:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id B3FC46B0092 for ; Sun, 30 Jul 2023 18:42:09 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 7E1FC1C900C for ; Sun, 30 Jul 2023 22:42:09 +0000 (UTC) X-FDA: 81069752778.17.E439210 Received: from mail-40132.protonmail.ch (mail-40132.protonmail.ch [185.70.40.132]) by imf25.hostedemail.com (Postfix) with ESMTP id A2D87A000D for ; Sun, 30 Jul 2023 22:42:07 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=protonmail.com header.s=protonmail3 header.b=RNr9dgZf; spf=pass (imf25.hostedemail.com: domain of bjorn3_gh@protonmail.com designates 185.70.40.132 as permitted sender) smtp.mailfrom=bjorn3_gh@protonmail.com; dmarc=pass (policy=quarantine) header.from=protonmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1690756927; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=7noDWhw9qbH9bbmDZ+mnoEvlUKMZe2LiLK48dmHENgQ=; b=EKM9+t9lcxd3n0WK0Jw9xxI5IRkQyJJ3pTD+YMUPfPhq7N2xiwLOYRatW/mJCv1n+k1pN6 Hw3BRXVLKYWd17MzcZR16i4VXOU6PVlrI/N08E0xiR1YCo3YCk5nv+EDeqNByR5LWXmryL Bq00RN+mH3BzsGIQhiB7kGwI+s/x1k4= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=protonmail.com header.s=protonmail3 header.b=RNr9dgZf; spf=pass (imf25.hostedemail.com: domain of bjorn3_gh@protonmail.com designates 185.70.40.132 as permitted sender) smtp.mailfrom=bjorn3_gh@protonmail.com; dmarc=pass (policy=quarantine) header.from=protonmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1690756927; a=rsa-sha256; cv=none; b=zx77x6a7E3StF/a5F5xu2mW4zxP+svvsMQ9229b/TzK4FAwoiexYZppnhOr7A4GDGZPuvB NdSd7EQzFacUyJa+kij2v85I8536f+t6UacM8PsKJ0sMFerMvnlgPNndf2GYyyRLLFrmCE djCfzOy1eyjgeXZzFw3tMsdeEEAwWxY= Date: Sun, 30 Jul 2023 22:41:54 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail3; t=1690756925; x=1691016125; bh=7noDWhw9qbH9bbmDZ+mnoEvlUKMZe2LiLK48dmHENgQ=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=RNr9dgZfi9jyPH/0Rrer91IoUFSMoz9Yf2Fj+jW55M4HxSuzalwr2Vt+xpBSbdGjP 2rUSV8LoZ9T5siafIa7w8ou6oWg72zJgi4oKjV+ztzZwKA5YUc3R7r6bgYULsgAaqp bSz4PS3wYtR8JQt/69+7Jy/zPXT/l18fTFe6LzhaARWS8YBLqpeUxqhzJeDAwOrrzs rcrqTO6cWHOJ6K/FAo++rYvaPgC1HLOjk9Y5wGjIajNDlXPdombk7rZ9U6WNUhMrtt sAagJVB7Jnt34fR3tKC7SPSVvLlB1zUepcJpCqiSxDNS544MZwrn9I+ML6TIIuoC+P ke2hdW/c5iSKw== To: Miguel Ojeda From: =?utf-8?Q?Bj=C3=B6rn_Roy_Baron?= Cc: Boqun Feng , rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Miguel Ojeda , Alex Gaynor , Wedson Almeida Filho , Gary Guo , Benno Lossin , Martin Rodriguez Reboredo , Alice Ryhl , Dariusz Sosnowski , Geoffrey Thomas , Fox Chen , John Baublitz , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Vlastimil Babka , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, Kees Cook , stable@vger.kernel.org, Andreas Hindborg Subject: Re: [PATCH 1/3] rust: allocator: Prevent mis-aligned allocation Message-ID: In-Reply-To: References: <20230730012905.643822-1-boqun.feng@gmail.com> <20230730012905.643822-2-boqun.feng@gmail.com> Feedback-ID: 27884398:user:proton MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: A2D87A000D X-Rspam-User: X-Stat-Signature: uuiczzursedimucy4ye64x4c8k3k5tjb X-Rspamd-Server: rspam01 X-HE-Tag: 1690756927-755093 X-HE-Meta: U2FsdGVkX1/M5vj3FxX8ltDa1Q0tppsUE6tLbpkX6t6c+EuLN3mn+eLkuVekrq2wEers+tvcGz9N5XqNXcY9xZWNZDWtjW208kTxQeB5pm2cy+/og6do0XsdubkblE94g81vBls/9RnYvUyhsQgsS6CNyrHlFWRPbd/c9Ssmy7Ba2QrdIj957PofYt6jEJJCovaxhtNqvf+c37AU0ytsdwomG4eFh1oWpb4yQfRf45bvWvi7FeeuaG6zuya8kptAy9k1RrcX8Smqlk5kLYzCKMIMhA2uOph2s1iIVVJlGMMr85av60H97OvPuvJXc2gUjrft2bn8cxuqV3BS1N9GMovndRbBcH5I5cvheBmopNwpo90KnXggALtJ3iYggiiB8ueoAtdW/9EYfP82B8dnDMTjoGi8I+la1vJprdOfZEW9k4N1X+hwgcHzUDymFbHn3wais7i9Z72NI8+Jo2hZ9GkEcvsA2DxYOP86+ystw8PyXRzI/5iJ/U+gA2n0jwSfpKUhVehGrmQAs8npRWaXFKPWtsslp2g/PfAceXd26f5ZPmZawjtgZ2J0HCmQNBEcWuqcbGRVzbBOqqQuESPVXZDT8emTHL4QSRH+znaanr4AN9qCnlaGqlNEgzfgPM34X8VGYqz5ElvncwI0dCNcRxelQNV8rPa4rqaFb2gL1QoiizAy54SepfkCKFueVLMAv/igS9IvnpXsnUCnq4xQRjmAGfRS0ntOl59ylXlEdBed7+61M8c7BeKupjEk2zjF2YB+mumAG2awQ5g5jgdZf669Ru/vbLquyszBTsmBsGoQTs+qBCgFTuW51Hb3Z8PKMTkFBa23aj9rrRfCrIdFq8VjUYNY7zc4d/IfvDd7GzNSJLiNUDrWbA2AsOabF2GGeGF9JB1IUCPfO3EUMfxszMSSSo8GK9o1p3vMe7j3TdK/6T9xArz4wQ1wSsywTh4eIGR+j++9JyQrq26eMua 16E6clSy g9tAaaE2SE/yH5hZCWuHoxK5Px33gr8it/n/XxE/xcMR9wSD1VErPBj7qkEqp7zKenJ8G2W27PEMdvhd3kuOZdEUdEH2mqFxcbszoYbajmBrkA8UhEjQfRy8aIKJlQdRetVrzhQ4tvg5cZBJfq6aQJaa6dKeDZx30Y2Tgkm/MVIanRzROqXoFc/Rjq+xKxrFwlIZGLHkLouUS0gT5/ir2VUkgeRy1YBMuQUH1w2HfBr9rpAh6GT+Y75NOXD2mLYIFdi3p8rSmffDilSlU08HtUFG2CgcMGNGEhAN9fW1OzofvP0+NHdIHwIqxEgpTAPIrHDEo X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Jul 30, 2023, 10:43 PM, Miguel Ojeda < miguel.ojeda.sandonis@gmail.com> = wrote: > On Sun, Jul 30, 2023 at 3:29=E2=80=AFAM Boqun > Feng wrote: > > > > +// Note: Although these are *safe* functions, but they are only genera= ted at > > +// `GlobalAlloc` callsites, hence we assume the parameters obey the sa= me > > +// `GlobalAlloc` function safety requirements: size and align should f= orm a > > +// valid layout, and size is greater than 0. > > Thanks for adding all the `// SAFETY` comments here Boqun! > > Bj=C3=B6rn, do they look good to you? (since you fixed the issue in the c= ompiler) Based on a quick look, yes. The __rust_* methods that are normally generate= d by the compiled directly jump to the respective global allocator method, = so they have the same safety requirements. > > On this comment in particular, "generated at `GlobalAlloc` callsites" sounds a bit confusing to me. Would "... called by the compiler with parameters that obey ..." make sense? Or does the sentence refer to the normal case (i.e. when the functions are generated)? Anyway, it is not a big deal. > > Cheers, > Miguel Cheers, Bj=C3=B6rn (resent as I accidentally sent html instead of plain text)