From: 赵军奎 <bernard@vivo.com>
To: Matthew Wilcox <willy@infradead.org>
Cc: Christoph Lameter <cl@linux.com>,
Pekka Enberg <penberg@kernel.org>,
David Rientjes <rientjes@google.com>,
Joonsoo Kim <iamjoonsoo.kim@lge.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
kernel@vivo.com
Subject: Re:Re: [PATCH] kmalloc_index optimization(code size & runtime stable)
Date: Fri, 17 Apr 2020 12:55:45 +0800 (GMT+08:00) [thread overview]
Message-ID: <AJoAMQC7CEStwOY-mOhlf4pz.3.1587099345148.Hmail.bernard@vivo.com> (raw)
In-Reply-To: <20200417032354.GK5820@bombadil.infradead.org>
[-- Attachment #1: Type: text/plain, Size: 1676 bytes --]
From: Matthew Wilcox <willy@infradead.org>
Date: 2020-04-17 11:23:54
To: Bernard Zhao <bernard@vivo.com>
Cc: Christoph Lameter <cl@linux.com>,Pekka Enberg <penberg@kernel.org>,David Rientjes <rientjes@google.com>,Joonsoo Kim <iamjoonsoo.kim@lge.com>,Andrew Morton <akpm@linux-foundation.org>,linux-mm@kvack.org,linux-kernel@vger.kernel.org,kernel@vivo.com
Subject: Re: [PATCH] kmalloc_index optimization(code size & runtime stable)>On Thu, Apr 16, 2020 at 07:03:30PM -0700, Bernard Zhao wrote:
>> kmalloc_index inline function code size optimization and runtime
>> performance stability optimization. After optimization, the function
>> kmalloc_index is more stable, the size will never affecte the function`s
>> execution efficiency.
>> And follow test data shows that the performance of new optimization
>> exceeds the original algorithm when applying for more than 512 Bytes
>> (include 512B).And new optimization runtime is more stable than before.
>
>That's all very well and good, but the vast majority of allocations
>are less than 512 bytes in size! Your numbers show that on average,
>this patch makes the kernel slower!
>
This is indeed the case, the new algorithm is stable at a time level, but
there is a certain performance loss for relatively small memory(little than 512).
I will continue to pay attention to this part later. Thanks.
>> size time/Per 100 million times.us
>> old fun new fun with optimise
>> 8 203777 241934
>> 16 245611 409278
>> 32 236384 408419
>> 64 275499 447732
>> 128 354909 416439
>> 256 360472 406598
>> 512 431072 409168
>> 1024 463822 407401
>
[-- Attachment #2: Type: text/html, Size: 2180 bytes --]
next prev parent reply other threads:[~2020-04-17 4:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-17 2:03 Bernard Zhao
2020-04-17 3:23 ` Matthew Wilcox
2020-04-17 4:55 ` 赵军奎 [this message]
2020-04-20 5:33 ` kbuild test robot
2020-04-20 11:41 ` kbuild test robot
2020-04-20 13:20 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AJoAMQC7CEStwOY-mOhlf4pz.3.1587099345148.Hmail.bernard@vivo.com \
--to=bernard@vivo.com \
--cc=akpm@linux-foundation.org \
--cc=cl@linux.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=kernel@vivo.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=penberg@kernel.org \
--cc=rientjes@google.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox