From: Zi Yan <ziy@nvidia.com>
To: Yang Shi <shy828301@gmail.com>
Cc: <mhocko@suse.com>, <songliubraving@fb.com>, <mgorman@suse.de>,
<jack@suse.cz>, <akpm@linux-foundation.org>, <linux-mm@kvack.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 4/5] mm: migrate: clean up migrate_prep{_local}
Date: Fri, 6 Nov 2020 15:05:54 -0500 [thread overview]
Message-ID: <AFF11692-A120-4BA2-9707-079F37B462A6@nvidia.com> (raw)
In-Reply-To: <20201103130334.13468-5-shy828301@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 476 bytes --]
On 3 Nov 2020, at 8:03, Yang Shi wrote:
> The migrate_prep{_local} never fails, so it is pointless to have return
> value and check the return value.
>
> Signed-off-by: Yang Shi <shy828301@gmail.com>
> ---
> include/linux/migrate.h | 4 ++--
> mm/mempolicy.c | 8 ++------
> mm/migrate.c | 8 ++------
> 3 files changed, 6 insertions(+), 14 deletions(-)
>
LGTM. Thanks. Reviewed-by: Zi Yan <ziy@nvidia.com>
—
Best Regards,
Yan Zi
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 854 bytes --]
next prev parent reply other threads:[~2020-11-06 20:06 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-03 13:03 [PATCH 0/5] mm: misc migrate cleanup and improvement Yang Shi
2020-11-03 13:03 ` [PATCH 1/5] mm: truncate_complete_page is not existed anymore Yang Shi
2020-11-06 9:16 ` Jan Kara
2020-11-03 13:03 ` [PATCH 2/5] mm: migrate: simplify the logic for handling permanent failure Yang Shi
2020-11-06 20:03 ` Zi Yan
2020-11-06 21:34 ` Yang Shi
2020-11-03 13:03 ` [PATCH 3/5] mm: migrate: skip shared exec THP for NUMA balancing Yang Shi
2020-11-03 13:03 ` [PATCH 4/5] mm: migrate: clean up migrate_prep{_local} Yang Shi
2020-11-06 20:05 ` Zi Yan [this message]
2020-11-03 13:03 ` [PATCH 5/5] mm: migrate: return -ENOSYS if THP migration is unsupported Yang Shi
2020-11-06 20:17 ` Zi Yan
2020-11-06 21:53 ` Yang Shi
2020-11-06 22:02 ` Yang Shi
2020-11-06 23:15 ` Yang Shi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AFF11692-A120-4BA2-9707-079F37B462A6@nvidia.com \
--to=ziy@nvidia.com \
--cc=akpm@linux-foundation.org \
--cc=jack@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=mhocko@suse.com \
--cc=shy828301@gmail.com \
--cc=songliubraving@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox