linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: H Hartley Sweeten <hartleys@visionengravers.com>
To: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Cc: "linux-mm@kvack.org" <linux-mm@kvack.org>,
	"benh@kernel.crashing.org" <benh@kernel.crashing.org>,
	"yinghai@kernel.org" <yinghai@kernel.org>,
	"hpa@linux.intel.com" <hpa@linux.intel.com>,
	Andrew Morton <akpm@linux-foundation.org>
Subject: [Q] mm/memblock.c: cast truncates bits from RED_INACTIVE
Date: Tue, 14 Jun 2011 19:47:19 -0500	[thread overview]
Message-ID: <ADE657CA350FB648AAC2C43247A983F001F382220E0F@AUSP01VMBX24.collaborationhost.net> (raw)

Hello all,

Sparse is reporting a couple warnings in mm/memblock.c:

	warning: cast truncates bits from constant value (9f911029d74e35b becomes 9d74e35b)

The warnings are due to the cast of RED_INACTIVE in memblock_analyze():

	/* Check marker in the unused last array entry */
	WARN_ON(memblock_memory_init_regions[INIT_MEMBLOCK_REGIONS].base
		!= (phys_addr_t)RED_INACTIVE);
	WARN_ON(memblock_reserved_init_regions[INIT_MEMBLOCK_REGIONS].base
		!= (phys_addr_t)RED_INACTIVE);

And in memblock_init():

	/* Write a marker in the unused last array entry */
	memblock.memory.regions[INIT_MEMBLOCK_REGIONS].base = (phys_addr_t)RED_INACTIVE;
	memblock.reserved.regions[INIT_MEMBLOCK_REGIONS].base = (phys_addr_t)RED_INACTIVE;

Could this cause any problems?  If not, is there anyway to quiet the sparse noise?

Regards,
Hartley

             reply	other threads:[~2011-06-15  0:48 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-15  0:47 H Hartley Sweeten [this message]
2011-06-21  0:02 ` Andrew Morton
2011-06-21  0:31   ` H Hartley Sweeten
2011-06-21  5:49     ` Pekka Enberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ADE657CA350FB648AAC2C43247A983F001F382220E0F@AUSP01VMBX24.collaborationhost.net \
    --to=hartleys@visionengravers.com \
    --cc=akpm@linux-foundation.org \
    --cc=benh@kernel.crashing.org \
    --cc=hpa@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=yinghai@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox