linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Zi Yan <ziy@nvidia.com>
To: Qi Zheng <zhengqi.arch@bytedance.com>
Cc: Matthew Wilcox <willy@infradead.org>,
	Christian Brauner <brauner@kernel.org>,
	"Darrick J . Wong" <djwong@kernel.org>,
	Dave Chinner <david@fromorbit.com>,
	linux-mm@kvack.org, linux-xfs@vger.kernel.org,
	linux-fsdevel@vger.kernel.org, Jann Horn <jannh@google.com>,
	David Hildenbrand <david@redhat.com>
Subject: Re: xfs/folio splat with v6.14-rc1
Date: Sun, 09 Feb 2025 23:18:03 -0500	[thread overview]
Message-ID: <AD32F66E-777A-43D4-8DFB-F2D5402AD3F4@nvidia.com> (raw)
In-Reply-To: <8c71f41e-3733-4100-ab55-1176998ced29@bytedance.com>

On 9 Feb 2025, at 23:02, Qi Zheng wrote:

> Hi Zi,
>
> On 2025/2/10 11:35, Zi Yan wrote:
>> On 7 Feb 2025, at 17:17, Matthew Wilcox wrote:
>>
>>> On Fri, Feb 07, 2025 at 04:29:36PM +0100, Christian Brauner wrote:
>>>> while true; do ./xfs.run.sh "generic/437"; done
>>>>
>>>> allows me to reproduce this fairly quickly.
>>>
>>> on holiday, back monday
>>
>> git bisect points to commit
>> 4817f70c25b6 ("x86: select ARCH_SUPPORTS_PT_RECLAIM if X86_64").
>> Qi is cc'd.
>>
>> After deselect PT_RECLAIM on v6.14-rc1, the issue is gone.
>> At least, no splat after running for more than 300s,
>> whereas the splat is usually triggered after ~20s with
>> PT_RECLAIM set.
>
> The PT_RECLAIM mainly made the following two changes:
>
> 1) try to reclaim page table pages during madvise(MADV_DONTNEED)
> 2) Unconditionally select MMU_GATHER_RCU_TABLE_FREE
>
> Will ./xfs.run.sh "generic/437" perform the madvise(MADV_DONTNEED)?

Yes. See: https://github.com/kdave/xfstests/blob/master/src/t_mmap_cow_race.c#L34

>
> Anyway, I will try to reproduce it locally and troubleshoot it.

You will need xfstests and run "while true; do sudo ./check "generic/437"; done".

The local.config for xfstests is at:
https://lore.kernel.org/linux-mm/20250207-anbot-bankfilialen-acce9d79a2c7@brauner/


--
Best Regards,
Yan, Zi


  parent reply	other threads:[~2025-02-10  4:18 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-07 15:16 Christian Brauner
2025-02-07 15:29 ` Christian Brauner
2025-02-07 22:17   ` Matthew Wilcox
2025-02-10  3:35     ` Zi Yan
2025-02-10  4:02       ` Qi Zheng
2025-02-10  4:16         ` Qu Wenruo
2025-02-10  4:33           ` Qi Zheng
2025-02-10  4:18         ` Zi Yan [this message]
2025-02-10  4:35           ` Qi Zheng
2025-02-10  8:18         ` Qi Zheng
2025-02-10  8:50           ` Qu Wenruo
2025-02-10  9:00             ` Qi Zheng
2025-02-10 14:12           ` Zi Yan
2025-02-11  2:43             ` Qi Zheng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=AD32F66E-777A-43D4-8DFB-F2D5402AD3F4@nvidia.com \
    --to=ziy@nvidia.com \
    --cc=brauner@kernel.org \
    --cc=david@fromorbit.com \
    --cc=david@redhat.com \
    --cc=djwong@kernel.org \
    --cc=jannh@google.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linux-xfs@vger.kernel.org \
    --cc=willy@infradead.org \
    --cc=zhengqi.arch@bytedance.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox