From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C71C7C7115A for ; Wed, 18 Jun 2025 19:10:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 23FC56B00A4; Wed, 18 Jun 2025 15:10:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1EFF76B00A8; Wed, 18 Jun 2025 15:10:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 090C86B00DB; Wed, 18 Jun 2025 15:10:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id E88E16B00A4 for ; Wed, 18 Jun 2025 15:10:23 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 60A7F16084E for ; Wed, 18 Jun 2025 19:10:23 +0000 (UTC) X-FDA: 83569462326.03.1721FB1 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2070.outbound.protection.outlook.com [40.107.92.70]) by imf04.hostedemail.com (Postfix) with ESMTP id 9CAE540019 for ; Wed, 18 Jun 2025 19:10:19 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b="qAS2CFm/"; dmarc=pass (policy=reject) header.from=nvidia.com; arc=pass ("microsoft.com:s=arcselector10001:i=1"); spf=pass (imf04.hostedemail.com: domain of ziy@nvidia.com designates 40.107.92.70 as permitted sender) smtp.mailfrom=ziy@nvidia.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1750273819; a=rsa-sha256; cv=pass; b=4V1iffq1rRarpEVDxMkeRwqCWoZjUpI4ZhKGIZO6eGXBraPtBE8WvtkMFZR2T72sC0LhHQ lR+JNEsPblSyX5PMDNZLwGAvqpW1sjnDxN8UEg71sTAT22mVqdki96SvAj0N3rl/nFH2pi FkJGdFWh/6Tth647y1wk40VwE1EBwJg= ARC-Authentication-Results: i=2; imf04.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b="qAS2CFm/"; dmarc=pass (policy=reject) header.from=nvidia.com; arc=pass ("microsoft.com:s=arcselector10001:i=1"); spf=pass (imf04.hostedemail.com: domain of ziy@nvidia.com designates 40.107.92.70 as permitted sender) smtp.mailfrom=ziy@nvidia.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750273819; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Kr1ucAdzhuPBSYm277iLPVUHjG6+LfJxNq3NVaNMrm0=; b=sQdrsHb87p/imlH8a8EjrJUasOLIoFdsbMDp8Hx78yR8VwCP/no1D8VGcjYbDwWp5/ayMj +rj2wA0cHfEHeWVnJpZGVutdufZ/NfCP/siUh+EmOtJS1TvT0gMy+SF8228l7HOARwUmZx tEYTzQdypalWf2UYdInVUKEz9eghu2U= ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=uq1vXZ6mSmKw7MbFf8iK0W8QjXZf1pr8nZjTYL60ic5zJ1b14S3sfJ6Sd/b9PXByRm/WvhVMhnbEUJAboe4+HSXBlj53kACgq5978SromsgzTdaXUpN/LEvcmX/tM/mhn0Vc02w83eu6n70TbNSw6fM/OoHtWG412MsWjPizRFuDBzmbttvJl0sLVpzV0mYItPeC0dSDuacFMMi/jSRdnSfmetRq7jo59unZKkA+vflyO7NpoxR4mK8SNXs76qrqG6odFAMa43sUHzSy2YItp1ArJ1kVCW//fsQV3iNJ3W5EHVAHOQyGU7PVkzV2QzUpkK+CYjMmjUNgOgkzveeZSg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Kr1ucAdzhuPBSYm277iLPVUHjG6+LfJxNq3NVaNMrm0=; b=J80s6gIylL2jIRjq74vlY15BpGChsXqEv/ftTJK2xXU8jbZfpMsrXhwCTDQ6TWuCbQDxAdJBw+y2fAzk0jhEuHUW6zRB0+3+U2URaXc6Ve8zKqm6K0VFvVIMmrGN0EHkqkSKrLmwd4V4IqCEGFJNCYFHAYzU+3h9pcncDRg4+i8v2e7axcn5N8W0px/JlcWosiEIbq3cTcTw4flPtasO33oL3Y14WUI5cY+Jwl0InVjn1daQ/Z7oJybTdEsNoq7Ub3aRBeXnBsM5ZoQBgCAh4XL/yWJ4fjOWwUxItR7admudR4H1d+MxFqHWGNdaQQqDFU6lsi6zAOYDbO+QTZ4lCw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Kr1ucAdzhuPBSYm277iLPVUHjG6+LfJxNq3NVaNMrm0=; b=qAS2CFm/x7GO9LGWJIw4NImSNDOmnYLrQ/FJxKykFneD/QD3N4GMUvUzcND6teuiUh0m3IgKglpPh3zYNfW5r30NI+J8Ucq+m043C1InDocwpXx6pqUjqAI49/Ma0os6KfbNFOqMVYbNA56bYrpGoqyvLobPx22gnLoz69nqBHxHPtbdb7Xtyfu4HYWdRkTdkO9vdmFMMo6pAinHRd5WK6geTXDYhlucdPk/k1Ssejt001ZH8JBNjY385wP/gzKfE2scor2xRVlnLYqq3vAulo9xvZGnodgjfqS9/matZUjTmWUnYiP/pSESmlvMuNXnzKgKlzIurJ5jRhpjI5F75w== Received: from DS7PR12MB9473.namprd12.prod.outlook.com (2603:10b6:8:252::5) by DM4PR12MB6637.namprd12.prod.outlook.com (2603:10b6:8:bb::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8835.29; Wed, 18 Jun 2025 19:10:16 +0000 Received: from DS7PR12MB9473.namprd12.prod.outlook.com ([fe80::5189:ecec:d84a:133a]) by DS7PR12MB9473.namprd12.prod.outlook.com ([fe80::5189:ecec:d84a:133a%5]) with mapi id 15.20.8835.027; Wed, 18 Jun 2025 19:10:16 +0000 From: Zi Yan To: David Hildenbrand Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-doc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, virtualization@lists.linux.dev, linux-fsdevel@vger.kernel.org, Andrew Morton , Jonathan Corbet , Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Jerrin Shaji George , Arnd Bergmann , Greg Kroah-Hartman , "Michael S. Tsirkin" , Jason Wang , Xuan Zhuo , =?utf-8?q?Eugenio_P=C3=A9rez?= , Alexander Viro , Christian Brauner , Jan Kara , Matthew Brost , Joshua Hahn , Rakie Kim , Byungchul Park , Gregory Price , Ying Huang , Alistair Popple , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , "Matthew Wilcox (Oracle)" , Minchan Kim , Sergey Senozhatsky , Brendan Jackman , Johannes Weiner , Jason Gunthorpe , John Hubbard , Peter Xu , Xu Xin , Chengming Zhou , Miaohe Lin , Naoya Horiguchi , Oscar Salvador , Rik van Riel , Harry Yoo , Qi Zheng , Shakeel Butt Subject: Re: [PATCH RFC 08/29] mm/migrate: rename putback_movable_folio() to putback_movable_ops_page() Date: Wed, 18 Jun 2025 15:10:10 -0400 X-Mailer: MailMate (2.0r6265) Message-ID: In-Reply-To: <20250618174014.1168640-9-david@redhat.com> References: <20250618174014.1168640-1-david@redhat.com> <20250618174014.1168640-9-david@redhat.com> Content-Type: text/plain Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: BN8PR04CA0066.namprd04.prod.outlook.com (2603:10b6:408:d4::40) To DS7PR12MB9473.namprd12.prod.outlook.com (2603:10b6:8:252::5) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS7PR12MB9473:EE_|DM4PR12MB6637:EE_ X-MS-Office365-Filtering-Correlation-Id: f6f24617-9e9e-4c35-ad92-08ddae9bc262 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|7416014|376014|366016|1800799024|7053199007; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?PMHSta2xY4BOazYoqXot9skOxRN2l2iIZ1HYPz6RzKJX8cnO/qjgdZG3DDH7?= =?us-ascii?Q?Qkx7S+BlJJXehmo5kTmzYbFnN+6TwhP2jam6qA7yjcAAJ/FAnvUrR75wv2hb?= =?us-ascii?Q?gfUNaIE5aS8/t2JfRZGVMXtHk8UO1W0TruV2eD/UijeRKplso8/XCj1kWLrD?= =?us-ascii?Q?6vnr2UN5Kuji70PAu+HCS1kjYy1ygVZgIjwxhj9Ft7YvbrzXx/dQSAcbh82Y?= =?us-ascii?Q?gbL2WvYxzj+uPFSzpxwy8jkIW79pvvutzk+LemaokCEaMvgQIszRMfcCDxgC?= =?us-ascii?Q?SveI6lCTl+BJvaYb1NHbqeruORuo/dpg39eVWwuhEyVCRXnvteZpOvDUa4Yn?= =?us-ascii?Q?ELmqg/ul9Vu8kdWxBJJOllI31UGYFK3S58xYGsEsoFiFi/JoalaMBkdsFk8Z?= =?us-ascii?Q?k5b3ii369rKoZGY7cp2Qvolf7IROHvb+yURYr97RLOuJJ4SVMdIcyHAFx+es?= =?us-ascii?Q?O6X/3+TEVMeemD66LgltBpdyFSqV9fkG2u3363UFjsZNjAJaFf3N3x/9U6T6?= =?us-ascii?Q?6/npCp7ejmeYTCyS7RQXmZu8b+5YsZij30iXJkDusZYNntBW+hSNeW6MJFVV?= =?us-ascii?Q?/KRYFHHZvgOxg3jxRR0cPJHNeHjffZ9i+mLBuII2PbnOXK56cje4UBF8dEIP?= =?us-ascii?Q?xqw5Bn3P2EIroXTIMV6bM3mL+rNF5ngn6tvcLOHOF6SDlhozgA6YmB86up6+?= =?us-ascii?Q?jBox6Sc4OnMX6BHDvdNdYMd6FEJsdHA+svR5/U3uQC5OMdZwx0KuQlZX/ozN?= =?us-ascii?Q?1ARSupTfxcUsNxy1nJI5P5UdoG/lUaZrFHBI74rE2JVqx4Jdzun7Bda/hPnE?= =?us-ascii?Q?wq2aeBewZITKuruRY54nKLybvTSjjco1agKADst4/dwyXYi7RkPJG4Y2TE2y?= =?us-ascii?Q?luKl/XUrFyTT9yYAgZK1CM6o3TkxXyEDNfbDPzKzHR5mdasx5sB+e6D+ke0G?= =?us-ascii?Q?xdFZQhuPKIlRsy7YBkyIyMmfjM2mLuthihHoG0f+7KApmG4CKTCX+kWwrmql?= =?us-ascii?Q?50hmMaQmOpjDsg/OyvfbgOlo8MlsknDHFqd9+eCVwDnIy/zrV1eJvX5H0DID?= =?us-ascii?Q?3YOa6z5sHx6AFnTRJyqRjnqeIpkhntS3yVDfjti5rCRo4SgKxlygryRjCQRa?= =?us-ascii?Q?Rwi9+mAjx1YK6EhYsDWB8+pLcrp/DiVbdcL1H2JxuOgh833GcuLo2wYfP5qi?= =?us-ascii?Q?IEm2tT5MJQONNLoxsQyVUtOfVGGlzllS3+sqSbMpy8NPbi9PTuBePmzAb4sK?= =?us-ascii?Q?g51b2Dqso2Q90BT9s6LatreFozo2fepebg99+++VA3G9SzDbmRyyNeBh1RPY?= =?us-ascii?Q?My/FVB/jdxbRJDbskeWZb+AO3FAKdfm0knnGnm9z6PU/ltkES74PAylJlJbl?= =?us-ascii?Q?G3lV/XvRwo4YcDYbBKFNZuPE6c6Dc/9VfDDVWF7lEtMpxcQCxfEU2x+9m0Qd?= =?us-ascii?Q?MUmi7xieyPM=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR12MB9473.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(7416014)(376014)(366016)(1800799024)(7053199007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?OrU7s5zXdBiZaGcvSoFtCLaWCMzlKQQaIwp7w6ySeSFklVqE5mHeeMhv3je9?= =?us-ascii?Q?EWQwziMFyDheU5z+rfFALpgHeOraPt5KmcgW2uW4JgLTJAaUmSglQtF33RMI?= =?us-ascii?Q?Mxtji2SpR1srFKyMrUMMlVYemL1upZ1lXm4AosXshA1dCGyHUKFkKPKmFCaV?= =?us-ascii?Q?d7zpk0eZT25eqocbe8bwWEUIgzdok6keirsZzruV8HKay99xtAQWaXY+guej?= =?us-ascii?Q?TsdbFTGt7hPPuu9YmqozIKGQMGSlger2kSGwehUZNT7+HDeIjOw3RH4WMQ+C?= =?us-ascii?Q?/EKk8Syl3GCaZOiNNrBeCrgFl27oL83pIpkXjn4AH1Vn1Nc8QQMJPO2YqLLk?= =?us-ascii?Q?CYfeIZts6fFcSGsOGezoqTZZMC7dsFVLPxs54CLjaP8AgoX9Jv07k8mpMKcW?= =?us-ascii?Q?ZzR/kgUN9U07LfsbAfOGeaisStXCKhG/th2ygXVTC5sgE4L1yKzQY4JSBCZH?= =?us-ascii?Q?P38raB6kMTCyp+VyQjbF1NnVM6OZDzXc1XauVJn4dNyCQWn7DESM327wC2jq?= =?us-ascii?Q?wRV7yPYkiKawlkQWgl/PE+azs0O5iT7Ch0suJZ/Z5z37v8ofRNzCcKnXiacC?= =?us-ascii?Q?y7Qxk7VBEUiBnxsWoQWGJa8zmSF0FSeqySjfA5cX6gbpQTa0FGyz3osP20TC?= =?us-ascii?Q?6/I0boob9+nzap83QZLvX+FDnrybDnPIZ94VQFvTbv0rOCpxqA/HNAWqQaCp?= =?us-ascii?Q?3via+nPQRkkyxkqpVc/VC407JmvwLM1g0BsgLrWJCprayxFI2tdPRWrxtJZT?= =?us-ascii?Q?2zJnN3A+GWXkfR/Xs+EXQsxi/MUy4yWNl9rj5FTvGcK0ykRUU9+Let/iO7q+?= =?us-ascii?Q?me4aiJA8gJw0Ax8b4YvfTp2lkqBBTS4aI2+BME1Rl7evTxzOYS7CqQz9m8UT?= =?us-ascii?Q?3AadKID+dLuTsUR1luLoEf2KDFl/HK95tg50RQDlZ4v55ZGteDA8OXXC78xX?= =?us-ascii?Q?Ysvck5R7tSn7Uivv5GaBbUA4AnLeJVcKlF+XWt7UFtLM+rxYgYAJWM/jg7RN?= =?us-ascii?Q?auYfPGJEvUOezPJa4KtViY4jXI3TMUBjznJjRpddLn7mmVsLwhlaSOhTWg26?= =?us-ascii?Q?49xj+OlEhvYVPcGAXoId63h1EncIwCMzuDUX5VBSFDvdVrrHARFVbi63cnv5?= =?us-ascii?Q?Vv/M6opzcZ4tEHs12GO7YEhrMCEAHjdEGU8wAclATXHq6Uj8U+2ZYQk9z1KP?= =?us-ascii?Q?P7m8m1yyoWiQz43bX3boH6vM0d9KfQ9J8xZR29V3smYc6PXAGmWRf0MzslkJ?= =?us-ascii?Q?u0qq7MlIglaSePrld0YdOgjr9MDc9o1+bAQU7C42mdoNJRYNngj5bryoEswq?= =?us-ascii?Q?cgsp1Ccib14AumWOV01iDZUJz2r4qFif+7zrzRYG5WrKOsywktl+Uw8Puvl0?= =?us-ascii?Q?ShMiH1kMUFPn8iqjGmLf9k/d3agnTOw/UBoGcpmxszaSU9fknJ3w95Jfz7U5?= =?us-ascii?Q?TTPEZcRmVAxy0tj3M/bCzTUfckPrbP7AHpTBDrW57RU475FOqc19F+XXOWAd?= =?us-ascii?Q?JEQ9cCnxeVstCssaC/0CcQ5vqjgg8Br8nZmVkIZ6abWfX+5cQ8WMXSZ23Voc?= =?us-ascii?Q?OandTNTWpKWe5uMEfuBRLCnRXJ4yJO6HkAGzvZ1i?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: f6f24617-9e9e-4c35-ad92-08ddae9bc262 X-MS-Exchange-CrossTenant-AuthSource: DS7PR12MB9473.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Jun 2025 19:10:16.4171 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: /ZX0YVpFKi2hAYnKUwAFlmqtckgzicV/2JB93W8O157uQFnayKycGmT8zvW8v8Lo X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB6637 X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 9CAE540019 X-Stat-Signature: sxbdbo44tyt6yymc6zgcqjin3to5j8wk X-Rspam-User: X-HE-Tag: 1750273819-416452 X-HE-Meta: U2FsdGVkX1/4T7//kMpQURI6q42rH1b4nuu0XcqaDLB4deCXqctLmDozz+1Lq74xl84/2Pad+xQtATWWeCwQyXGPX/IaN9Mv745qWgPLnakruxpS748Jmu45KZazjjk5SbaM50V8T9UPnob+x3YpCE6+zeQSXQOAenMmeguu/TuPTjENkZqrAvWpiy6TYYVb1M8F7u6sLhMEcSRSvB3BL2ldA+xHXkYWGtSbpgFGrg59nSf4yBY5PZVPgEjZJoU4BGAIGUF6HwiFd+xOt5ViizAaiQA9u2ZqMKfaGLSIDLjtITU8lWpK9dKsyTe2K8i9gZYQyombmZtjtwOBLoEETpVqstu5s0PitrUjgiSZ0wrHEuwktuREdDP948IB50SCP4ByLRUdR6tio58iBsod+ocHMQcbBouXZ1RJhQib0yVrydfEXH9jZQoakxtvVgi9jxMDv18Hdcxn724TeCeNcPSZ6ffy6CamAY6cPt8YnK6GcnHVL3yy4kCFk7P3+rmj6+o1I2W9IIMCXLzjlqCK+9xWXGUWIQOeLWqQWhlafhBbb9/YqdX6r06t92Sukv6NUDCMKZmPpoZ/v0Hf0Pzk3o/BV4TYQDAy/HPSn/+b0A7yenr5Jq16KAIUEsuht0yx88rzgdhJ4LVOSErzHC0/B8EOTBbuMWYCkIsKug0XayhLNxb1ljTf9oVG9aNx4mT3XKnC78LNhd+tkGWECSZSiz6s/2WrrNz524JHhWH7YW13APyW1KyiJIKnaQKa62Wj7DXbBIg8piqYFgUoA6BXq2nQWkrTsJGFR18ip1xYCU0CbtmUvzzgHAg7lU6ljfGwYYEQImNzRJfLdvc/wElKNQA47OT8VVEhidkGpGf8kJhN1bSk3hAEM7Q9Pg6eKBcFQmm5BlJ8sFHMTDXxQ4jlKpnno4GuwRoJlmsNLxvkBYjo9e+ypQUVSaBxTB8sK4jxC/zMon7sAFufpXe7HGd 6pNDObjj s1KxO+FZL0K2DSADn4m9P5768C9VEKOrM2mGx+UdZTNNkbb6VMmxsHGZBXrJmA+sYMpFA7v2NuEFuH6nrCQ44LThYlruP3MDmx6RUYNZY1ata/0aOdndWQYCt4HVwK3ddy78JF6oKgDnzuXg9htZKA9AA7mFCUIApNXq/dm2P6rCokHPsnXpDMyuoWnx5z8q1zhGhxQdGGM2hR01oe8tXqe6C7JuqZO004ORJgQ6iqLSs1wRFhzurKeuEbuW0KAwNmH4grdtwT/+/lDQ+sftM5PxbvBwdV2FiTVJ8mvpimnltI/J/QwkuIxTLHsGffl2e2v2hZV0WyLE8pHPxqYRDCZ6OlcagPknL3MR1QrdNOwDh44QVcaoymBCErLnpeEc/K3uT803Jqlx1MCHLRPrCmHaz9AuQkuAB6C8/w2JINP+o/20Gql+4l83+0B6XF/s3rp8eCXS6Op/RAYH+d2xuby3S7S1xpXtz/m0XjTWCLrE8LTYj3rt/kHqMWC1IkUCH0O8OJS1OFR9jdL+r6TLRhDFKkFq9DtF3PBemoErTg+Msa4XzdDqoHd3skVdwQjgTTKl/ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 18 Jun 2025, at 13:39, David Hildenbrand wrote: > ... and factor the complete handling of movable_ops pages out. > Convert it similar to isolate_movable_ops_page(). > > While at it, convert the VM_BUG_ON_FOLIO() into a VM_WARN_ON_PAGE(). > > Signed-off-by: David Hildenbrand > --- > mm/migrate.c | 37 ++++++++++++++++++++++++------------- > 1 file changed, 24 insertions(+), 13 deletions(-) > > diff --git a/mm/migrate.c b/mm/migrate.c > index 6bbb455f8b593..32e77898f7d6c 100644 > --- a/mm/migrate.c > +++ b/mm/migrate.c > @@ -133,12 +133,30 @@ bool isolate_movable_ops_page(struct page *page, = isolate_mode_t mode) > return false; > } > > -static void putback_movable_folio(struct folio *folio) > +/** > + * putback_movable_ops_page - putback an isolated movable_ops page > + * @page: The isolated page. > + * > + * Putback an isolated movable_ops page. > + * > + * After the page was putback, it might get freed instantly. > + */ > +static void putback_movable_ops_page(struct page *page) > { > - const struct movable_operations *mops =3D folio_movable_ops(folio); > - > - mops->putback_page(&folio->page); > - folio_clear_isolated(folio); > + /* > + * TODO: these pages will not be folios in the future. All > + * folio dependencies will have to be removed. > + */ > + struct folio *folio =3D page_folio(page); > + > + VM_WARN_ON_ONCE_PAGE(!PageIsolated(page), page); > + folio_lock(folio); > + /* If the page was released by it's owner, there is nothing to do. */= > + if (PageMovable(page)) > + page_movable_ops(page)->putback_page(page); > + ClearPageIsolated(page); > + folio_unlock(folio); > + folio_put(folio); Why not use page version of lock, unlock, and put? Especially you are thinking about not using folio for these pages. Just a question, I am OK with current patch. > } > > /* > @@ -166,14 +184,7 @@ void putback_movable_pages(struct list_head *l) > * have PAGE_MAPPING_MOVABLE. > */ > if (unlikely(__folio_test_movable(folio))) { > - VM_BUG_ON_FOLIO(!folio_test_isolated(folio), folio); > - folio_lock(folio); > - if (folio_test_movable(folio)) > - putback_movable_folio(folio); > - else > - folio_clear_isolated(folio); > - folio_unlock(folio); > - folio_put(folio); > + putback_movable_ops_page(&folio->page); > } else { > node_stat_mod_folio(folio, NR_ISOLATED_ANON + > folio_is_file_lru(folio), -folio_nr_pages(folio)); > -- = > 2.49.0 Acked-by: Zi Yan Best Regards, Yan, Zi