From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 70D49C25B4E for ; Tue, 24 Jan 2023 13:41:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BFBC06B0074; Tue, 24 Jan 2023 08:41:02 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B85676B0075; Tue, 24 Jan 2023 08:41:02 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9FF7E6B0078; Tue, 24 Jan 2023 08:41:02 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 8762B6B0074 for ; Tue, 24 Jan 2023 08:41:02 -0500 (EST) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id EC121140B32 for ; Tue, 24 Jan 2023 13:41:01 +0000 (UTC) X-FDA: 80389803522.18.624C80C Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by imf14.hostedemail.com (Postfix) with ESMTP id E81B9100018 for ; Tue, 24 Jan 2023 13:40:59 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=2bZMNHzl; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=z42iM2O1; spf=pass (imf14.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.29 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1674567660; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=abri0zFA+xjooP9Ux7FyiMJ1tEcfHRQmA6ycin20OiU=; b=oHiHJ8nDqyovabda15SlJ1qLxKjfjCszT0TPFzYIjZQWOrhY6Ms8aWTX8hhKitQiYTFDr3 595eafU8FRN2166ePKFduu2VPmYb8J7DWNNRyMBxVHtXo77mLnIBfLlPSQP0gKa2CSAmbT IaAw+y8gq1BSixJ6hVG08KuVSr7BsQc= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=2bZMNHzl; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=z42iM2O1; spf=pass (imf14.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.29 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1674567660; a=rsa-sha256; cv=none; b=ZLoxWz63fRx/Lwlce+a2bzR0/qlt/bUXt7IOm63mCUtj1iPZMMzfpZ0jbmrpBXkcjq81ZS IF2Is2206T34EGW4iE6yDhgkcvdacDAhHEkOrH3kFfYB2HJHZW+VVM/1umTH0L+VTytNFt AlGBc1kKSgrgrB/ZAYJOYT6ZnSBhr5s= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 2A47E1FDAB; Tue, 24 Jan 2023 13:40:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1674567658; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=abri0zFA+xjooP9Ux7FyiMJ1tEcfHRQmA6ycin20OiU=; b=2bZMNHzl2etHCSdbjIvf9JPvQRmje+DRWoIA59q9l0qb3e/pSIkNnMbbogxfeua2Nq4jNN q9sU+KwAAx8V8s143WDCb1EkL7EYCBQyf6QKspa8kd138NZjC1dRhfKltiuLj0mYjaQYOe W29fte9MKLw0VUqbZtITDa13cTbvM7Q= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1674567658; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=abri0zFA+xjooP9Ux7FyiMJ1tEcfHRQmA6ycin20OiU=; b=z42iM2O16v7RZ9l2xP6I7NGba8aNNuxfmNysErxOtpoz7jZfs1W8OgwfHV+g/Swc0HwL38 VZQcFpFxo+JYpcCA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id E6C9513487; Tue, 24 Jan 2023 13:40:57 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id m9xBNunfz2NHZwAAMHmgww (envelope-from ); Tue, 24 Jan 2023 13:40:57 +0000 Date: Tue, 24 Jan 2023 14:40:54 +0100 From: Vlastimil Babka To: Mike Rapoport CC: Jonathan Corbet , Andrew Morton , Bagas Sanjaya , David Hildenbrand , Johannes Weiner , Lorenzo Stoakes , "Matthew Wilcox (Oracle)" , Mel Gorman , Michal Hocko , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Michal Hocko Subject: =?US-ASCII?Q?Re=3A_=5BPATCH_v4_1/1=5D_docs/mm=3A_Physical_Memory=3A_ad?= =?US-ASCII?Q?d_structure=2C_introduction_and_nodes_description?= User-Agent: K-9 Mail for Android In-Reply-To: References: <20230115184212.996298-1-rppt@kernel.org> <20230115184212.996298-2-rppt@kernel.org> Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: E81B9100018 X-Stat-Signature: gtmyfg8pg5try9xwzn764tehmmfhwa69 X-Rspam-User: X-HE-Tag: 1674567659-307395 X-HE-Meta: U2FsdGVkX1/FxUmAR3spBl77PW3FVzqvBlw8yGVtcDpqhTamVM5N08r8YTaoimNl/pd3f6iYDUoFIIwhphjzCw9Z29rQsOoMspW3p9Lbaby/O4yo3fr8ktOmd5o9l50MazveR0wdirQC7T3a27gDcrWDb+xGqKr7XPnJwyS2bTc/GXjRNCbdkPFHYFtqds2ICv6u1Y4Gzph5DYaWHgaUjuAvT9c76dvgmktLTH2Y2tty/KBrlIiXwKwutwb+7tCPYOfID55QqAVctFKrmwEYi5J3TZfge8gJ7/B6y7/gOLnSBeikZ3HQKRCCPVKzP49DUFYxT+dVlH0gjsPUFlGIYPsZ5OdZtlnnRfzAWrIMB5Gqt+ritrCdsK4hHLEXkHpvBGVtJ9e4ARGdnQTAlAk6R/e3r7gZ9LZqKaIeeVDVknz3/muzm/Wp/kSw4JmNJ5ruSY+eda11G5lWJfIKxzUuKR5mqFleWUr3SOi65LT1MiWm4hcIjRi1+GkuvcUUBCo8ANSTl7GAtg+M5ysAM1D9x+RvnmUCYfBppXBTmc7MJEwONoEtSfUVR3tLppX4hY3Z77CJC2jfV2bq+4iZr1jTxKnzyLUSItnl2i1kC40W9HMIpMp8pzsy6sPqAVFcinr+lwHmhlYvf5LnZCIJqp5vSCzKi1iJaSNfbPHFedXlmuIp49EnIz2DM5bIf1vuXrBo/uSrdExvtbkQ4KSAwz8j1GDwoCX3XxSJRFXa1rpcgAnyXvtx98tNDZkiCtulOE0GlVNiveZrL6gPLhNysHvzJkIyoE1mMD7unYLb/NFStbNDlfE3u5bTk8TYy/6FYXnUpDB5r6VP+eT6kXHeWxOqNgHwSDsbBTS+MRURs1/Iirv5MUmqBSGIVNqDI1Y0F7OC0Q8uaRjqmNntMIGxjFGu6ZJbLQ6qwJfc6ORXVqnPz5rqew7qTB7A2XweCsB0EYzdTRV4llCUgInpOac4tpg vezBFxF0 lVF9Go2ae7mRlXhvois5T1XLbDc2lIoV5pguVO8tTzw1/DSpVIKttqTZ6udeP2/inJog3xUVPjlK+xGUlwoeXV9s85Bs3WIxS5lWEEpcr2FKdkhn9QH6E9K4oVWdIFrekqG9Ll0D8nO3hBcPN8Rem7ZfSCySAkdqbUtkCX+b+PYP6O/hab0RXhzxh+gkRqWe3Uq5ejZpFpAh0ys5OMG9QWAEYj2kffhBpcOUDLIGOzQAcWCMnQnX7ZPbMjXuL04THcWx3Y6t/3AGae/nDaNehEcfhVsXS55ETPSONxFJe/eKuEXaNbaQ73/DH1NaC5XoQpJg6d3glnly0hlBXYLWKtUTjwKxxVDAL2cj2+3ibTDzdTKQ2QiDa0XhQy7qx9TuTDEqz8eK1kYy0VPRumgke7fpaJ3000LWi8iiV X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On January 24, 2023 12:16:20 PM GMT+01:00, Mike Rapoport wrote: >On Tue, Jan 24, 2023 at 12:00:07PM +0100, Vlastimil Babka wrote: >> On 1/15/23 19:42, Mike Rapoport wrote: >> > From: "Mike Rapoport (IBM)" >> >=20 >> > Add structure, introduction and Nodes section to Physical Memory >> > chapter=2E >> >=20 >> > As the new documentation references core-api/dma-api and mm/page_recl= aim, >> > add page labels to those documents=2E >> >=20 >> > Reviewed-by: Bagas Sanjaya >> > Reviewed-by: Lorenzo Stoakes >> > Acked-by: Michal Hocko >> > Signed-off-by: Mike Rapoport (IBM) >>=20 >> Acked-by: Vlastimil Babka >>=20 >> A small bug to fix below? >>=20 >> >>=20 >> > + >> > +Along with the node structures, kernel maintains an array of ``nodem= ask_t`` >> > +bitmasks called ``node_states``=2E Each bitmask in this array repres= ents a set of >> > +nodes with particular properties as defined by ``enum node_states``: >> > + >> > +``N_POSSIBLE`` >> > + The node could become online at some point=2E >> > +``N_ONLINE`` >> > + The node is online=2E >> > +``N_NORMAL_MEMORY`` >> > + The node has regular memory=2E >> > +``N_HIGH_MEMORY`` >> > + The node has regular or high memory=2E When ``CONFIG_HIGHMEM`` is = disabled >> > + aliased to ``N_NORMAL_MEMORY``=2E >>=20 >> Noted=2E >>=20 >> > +``N_MEMORY`` >> > + The node has memory(regular, high, movable) >> > +``N_CPU`` >> > + The node has one or more CPUs >> > + >> > +For each node that has a property described above, the bit correspon= ding to the >> > +node ID in the ``node_states[]`` bitmask is set=2E >> > + >> > +For example, for node 2 with normal memory and CPUs, bit 2 will be s= et in :: >> > + >> > + node_states[N_POSSIBLE] >> > + node_states[N_ONLINE] >> > + node_states[N_NORMAL_MEMORY] >> > + node_states[N_MEMORY] >> > + node_states[N_CPU] >>=20 >> Should it be set also in node_states[N_HIGH_MEMORY]? >=20 >You mean because of the aliasing of N_NORMAL_MEMORY and N_HIGH_MEMORY? No I meant due to "The node has regular or high memory=2E" Or do I misunde= rstand?