From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2A836C282D0 for ; Fri, 28 Feb 2025 17:17:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B7B506B0082; Fri, 28 Feb 2025 12:17:50 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B2AE8280005; Fri, 28 Feb 2025 12:17:50 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9CBDC280004; Fri, 28 Feb 2025 12:17:50 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 8372F6B0082 for ; Fri, 28 Feb 2025 12:17:50 -0500 (EST) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 371015096F for ; Fri, 28 Feb 2025 17:17:50 +0000 (UTC) X-FDA: 83170010700.11.562DB19 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2084.outbound.protection.outlook.com [40.107.220.84]) by imf21.hostedemail.com (Postfix) with ESMTP id 6BFB91C0007 for ; Fri, 28 Feb 2025 17:17:47 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b=Gkb2XnjB; spf=pass (imf21.hostedemail.com: domain of ziy@nvidia.com designates 40.107.220.84 as permitted sender) smtp.mailfrom=ziy@nvidia.com; arc=pass ("microsoft.com:s=arcselector10001:i=1"); dmarc=pass (policy=reject) header.from=nvidia.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740763067; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=1FX7iZEic2QMuXeZKyXOWxz8yIuOz3fRqrm6AJjy2pY=; b=qGjnotUIc3rS8P9v686AULRAec07wOmf1baU4H2jSwfoq62iqdKycRpr+xyFcoMrVuvKpT dofVK9NkuX2lE+6ucbe8CE+nDWEPIaIv1a8aZTCa7SkhGIjAn1ZCaWCtpwgtp8XxC/0uNr CaloV2rTDbWDbMcA/cNmhgWF8buVWxk= ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1740763067; a=rsa-sha256; cv=pass; b=2bsoy/GLGQ52faM/XqA3slpCvvMyvQpY8M5M40p1ia0xCHvGj6ckDbU0qg4Ox0UDYZ3yTm LCINyS1TodH2F17Co0JN4YJxq3AzGY2LZC/Olt6kzzxfVdgPvsoeUOLCsx39BrhHeMDCQe o+SvzrhyFxZ7iGi9t0NwbOAv/CE3Qto= ARC-Authentication-Results: i=2; imf21.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b=Gkb2XnjB; spf=pass (imf21.hostedemail.com: domain of ziy@nvidia.com designates 40.107.220.84 as permitted sender) smtp.mailfrom=ziy@nvidia.com; arc=pass ("microsoft.com:s=arcselector10001:i=1"); dmarc=pass (policy=reject) header.from=nvidia.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=lLeAM+EQ/bzjoPM2lkoxBpE415vvzR+ldrPmIQ3dc/ZguNt5aIWAkSFUI8MIWVqsV//RV+f+UwF5wH7pgCMh18GDyc1RKACyCQL77etwaWoHda9r7aTOi+GSGUIOWK9+/z1G0sbqGfQtulsT5TxrC8mzjS9pjaEaZov9/+vSvQNaVX+Gk7pzXEBzzI7scp/IWH8lkHE3lv1ZG7h+T3aKjdBoH55OQSf4IZXK3D+NlVB4OPQuW1iHxijuiij08NhZAC6brX18l6dR4iRNZcYCYiZAf/tyI70UidwEdIEYVW9cPEmRTMHG2Q+tUoyvnu/nHnK3sfwIYDcSJOYRoZ0YAQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1FX7iZEic2QMuXeZKyXOWxz8yIuOz3fRqrm6AJjy2pY=; b=vaHlC92VSFmq5nIVtc/QiopZzGtpXAIewh/ZRl71srnT5Y45/ym35BrglckvwIBVnwXahwarwtdx93cQ0vg53DmgnTNQX+AsFq2iL+kXJ76d1gRFyXmjIiNOSuhKDPD3k9zgL21xbe9Z1b78CZkTmzi1jh3WXbUJUY450IkHNcfjFbYrH2WJaGAC3fR7d9jZZNTK45IZhSXxHFGomDi9fLULj7FU95jFu6AXFQ/tVsOlISLIX4umyWUuly2JYEkxHnWrQIaEDxpg5KUWowujkQZaUUhh0HaHF06yPN8Tfh1NBEmsGMraGHulV+ulJsHjSFtzSvqL64w9fks/mbvr1A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1FX7iZEic2QMuXeZKyXOWxz8yIuOz3fRqrm6AJjy2pY=; b=Gkb2XnjBxLO0to+sx7vnF5NqkLd2SpRS5bIdT1C6vWlsrQc3mp7311XgyNd6vrllpjaAuD9h+wufYvIwQNrvdZbt7OHtw58RqnJK9G12PDWDXJ+D6YsBCaAFgR8aK2pNTTWO5ViDIOupbqhmM9h+tRaLn9gX8VR3RTSeN5cKf10nRWJRp81vABhFr3u91wvA9BEVUY/IRgIAGtjR93KSGmD3sOZxWrA5UXgeXyxXID7JcXdNkTAuyrCJ55t6wgiJS/H1lz1MLmrxAhPPa4/azG83s6nMjzVEu6mvYXD8G662kg1MtUd8cmKi6H6KkCXLj832G5c/3rLENJSqHRYF2g== Received: from DS7PR12MB9473.namprd12.prod.outlook.com (2603:10b6:8:252::5) by SN7PR12MB8170.namprd12.prod.outlook.com (2603:10b6:806:32c::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8489.22; Fri, 28 Feb 2025 17:17:44 +0000 Received: from DS7PR12MB9473.namprd12.prod.outlook.com ([fe80::5189:ecec:d84a:133a]) by DS7PR12MB9473.namprd12.prod.outlook.com ([fe80::5189:ecec:d84a:133a%5]) with mapi id 15.20.8489.021; Fri, 28 Feb 2025 17:17:43 +0000 From: Zi Yan To: Shivank Garg Cc: Liu Shixin , Baolin Wang , linux-mm@kvack.org, Andrew Morton , Barry Song , David Hildenbrand , Kefeng Wang , Lance Yang , Ryan Roberts , Matthew Wilcox , Hugh Dickins , Charan Teja Kalla , linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm/migrate: fix shmem xarray update during migration Date: Fri, 28 Feb 2025 12:17:41 -0500 X-Mailer: MailMate (2.0r6222) Message-ID: In-Reply-To: <028f5f2b-ec42-4704-b82b-2f604fd11cf8@amd.com> References: <20250228154219.2214149-1-ziy@nvidia.com> <028f5f2b-ec42-4704-b82b-2f604fd11cf8@amd.com> Content-Type: text/plain Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: MN0P220CA0006.NAMP220.PROD.OUTLOOK.COM (2603:10b6:208:52e::30) To DS7PR12MB9473.namprd12.prod.outlook.com (2603:10b6:8:252::5) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS7PR12MB9473:EE_|SN7PR12MB8170:EE_ X-MS-Office365-Filtering-Correlation-Id: 77546580-8fe4-41c3-244c-08dd581bd039 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|7416014|376014|7053199007; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?zko31fFzdpbYtuYz9+I3AemHEPJi0763Jl0HGw1S/m6dS/wnJyzl2EBjqNZ3?= =?us-ascii?Q?qHUd/HDNWVDhyoH5XiXPsndV9lH9RLRzC2OhMxjUdCqFGpkjzrqRGPNd6vki?= =?us-ascii?Q?mFTCrJ+tNO2QV2dqJUGp5csMiJQtrFyKLuNauRjB591ph/sCUdQ8LyS2vptz?= =?us-ascii?Q?CRYFh42rXLgxSgttXvCqTytaHgIBK1zE4g0lRtMA3WxDaTFK4y/C/Ry146cU?= =?us-ascii?Q?yJTvXFUhHwcenFhiIE7J9dM9yiamAiHlIqTDJsiAzIxskj74m/OGL+ntXwx5?= =?us-ascii?Q?0uJ3phRjGqwJJgm11EV7UKhFHwUubIZRbwCuXQYNKwCD1x/42F8mqpiOM+x1?= =?us-ascii?Q?2ropNQNmWzYukvCLz/Nq10GPZLlCNoFlczQ2Sy3OP3ludz2cRCnCXeHkWrJY?= =?us-ascii?Q?qJ2JPmfNL+Bltgi2W3mC54grM/nuVomPzNiXaoZqV71BsSgURdVDNfiYLlFC?= =?us-ascii?Q?avfEXP2w6zqHLdUEKKm4PS/Eo0fwtZNWbwBUmslzafdZTKsTr3CPHoBjvrZo?= =?us-ascii?Q?gfJ0+hCR4rAYrCoW0u96yArligS9MgjSyPuFoSkMToPiVG7KGJ5oUXO4c3zW?= =?us-ascii?Q?+oa1eRBKs4RtqitABd32ZanXcbqRGuaymwY7rn0e1y8yM8ct1eMga8cooJzf?= =?us-ascii?Q?8iaDbhn8URBudspRR06f1aB47Rhu9xppcLy9IpfF4Ue2lYBAGr6WUI48rxA3?= =?us-ascii?Q?XOFRoowox6Iei6xAmnNv9T2cnBo9zqelnweGhDo/veAlhkCCQWz/A2tGfwRY?= =?us-ascii?Q?DbCQAoCBK8pJn8qcT9bJe6JcC97/QA1L+t3gWavhrV7A0bpZLpK2FzeDkbsd?= =?us-ascii?Q?4FjAZm5Blf6cx34G+zMsaSGHR1uUpiK45nL38A09bMnPKK218GhpU1wCnq99?= =?us-ascii?Q?V0oWeDJi8afJ1CgKLCCNIIbhUpWK86EBv5St4BtDnI6ZN0l5YZx8v0kyc9aU?= =?us-ascii?Q?pdY3FChwTiSoBrRM5Q8Sl3sH0TUhBBiCsUAhYl8M9L6Bp2QX7/KOxZ3mU4cx?= =?us-ascii?Q?EfdsGLsFey94yoXpTccU9zCB2HdzxsczHxdyUojt7By9exVFBwDiUx94CjAI?= =?us-ascii?Q?WEYBfyYrvVKf7QTc4jh9RCoX5BRIRB5gGU4s3yfuIzkRwvWBC96oy6LjifOJ?= =?us-ascii?Q?5dcKPqQcVAOH4AGqt2yi1wNugmkyczejxk8IxF9b+6s6x1rEAL56T4LnK7aA?= =?us-ascii?Q?rAVx58rXrq4k/MXj10iVPXpXJtPzNo9MCae9rJPMwQ9E4N6WL2Uanoykeh4+?= =?us-ascii?Q?aLpHLO9ffVcAhcsl0CZWMK8dXYVFaAx7AoSd/mh9t6vOZzdZ6WwGQSl+McH2?= =?us-ascii?Q?DAunWjknIN1LXDCdl7pokxIIBzbD9e5JYH6Dsex+yr/P0m0pEo8ZyDjBgLVt?= =?us-ascii?Q?z5IFbLOJPfWbetxfZd4MeWxhAOFT?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR12MB9473.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(366016)(7416014)(376014)(7053199007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?e1f0oNWYNp3NcL9qVJKUNW0e7Ep4P8gs8VQnl62CHKHK7c0SyMRlaC2UG0WR?= =?us-ascii?Q?vRNKilaMHoXaf7jVUywvPvjyYqHXxTb8BEB+Oj78L3dcb8ysqCqbQ5KK4YYm?= =?us-ascii?Q?2zpp+YAIIk/qUK1Urcrq3/eUAREdgQwaNIge+RwWZh252UbxXAd15v3V8I3s?= =?us-ascii?Q?4IKpZawl0tNEH3SesWnKKGxgM4Tbpeh020LOyqlLc1HTW6sIYPcsvMUmXxrf?= =?us-ascii?Q?SKxW1Q50TPltYGv3iPZj93mkWMpXIm8PdJjkgzjSRG8u74289Szm3G/l63I+?= =?us-ascii?Q?waPMfpNjR8DI0UYmH/JY1vyfgJvuOp//o6gz1vVDH4TMf4asTT9kHqFDkfIg?= =?us-ascii?Q?M8ABrGrFjWXneiOkK5NFeVU/pEhxqxQDV+Y8ifMtPCJCY2rLbTcB1KPQeoAs?= =?us-ascii?Q?g9IGqNpXJ7GRESKWs0dX+eCU4/zcWExkmIo1JtX7HMyOoF00E9Gzc1GID5jq?= =?us-ascii?Q?7hm/P4cFI4o+5UgNFZVI/7SQaqvHKRG/ONdz6ConkoJZ6C5REJDhkd/ZNeO9?= =?us-ascii?Q?ORzV6zcbFIUlwUWTB2Bwos0KqtonvpM97uS0Fp2emW0aJv8iZpEwncxFGA2u?= =?us-ascii?Q?X4d1zVWqevpy4DUntsJloHRSVjpt9jQmtjMODWHXJXCmwYQvf6tiUQFXjJuf?= =?us-ascii?Q?t3sJ/cJxg4WtK+rJrd6Grx23eOnQ3/0gJBXkPxldIytIrg4CYInrGBoYWtlv?= =?us-ascii?Q?fquuIF34VrBI/7iPpTeaTAzFkNyRiZO4NttOpCbk3bJAHq7ZQJdiUUeU53Zd?= =?us-ascii?Q?m2UCUqtydUkB73cqp1wTA3MKf4sqAWX3ApXA+8e+JhTCsbtLjrlXeTMOPivr?= =?us-ascii?Q?jTfJJ3QZ4oM3UiG1K3V6485otcyddn9jlceLw0oE5KCS4L6KuSFXkGT55QGk?= =?us-ascii?Q?PnpuCLvmsiu573zOW/AYl1c79HSAlIh3oBhzc/B9lojTaRdjMQHKvWLo/ml+?= =?us-ascii?Q?QN/eNsCsJFt9KIlHLP2BGUiKYdI+HCbYbNf6OC9FtZI2THJ9LRIMyNVPWRQB?= =?us-ascii?Q?xwILYe5iAR0fRlaXrOdfGkW7S6oHN4XgDGtzEPtq+gtI4elh1deAJ+rVeqRc?= =?us-ascii?Q?s4PpOPEvi2BZU/Wrr0mIhzdawN7gEspMPbk0lb+v1mwH/wwUbvo/GbA3aOe/?= =?us-ascii?Q?UjQzO68TcHaXfvQdoOKpJVIJ+YNhgro6nvnuqm9EgMuuzGcD0MlXBxtutgPT?= =?us-ascii?Q?fBerQF4PCBfHvFzHg5qkEY1dWFZkSAla4Rw+WFQArxr/fPvtkXUoJs3g+dFn?= =?us-ascii?Q?vh/19FTIrIUVPlAeMK8Q9/gWwyz0nrzsnKW8/sLb5amc5IvBDKor1tpDUHO3?= =?us-ascii?Q?TTqcl9Vjr6Oq3ix8C9UfS+xOA9tjder402Nk+JKV/gAw7kRxygxJn2lL44Tp?= =?us-ascii?Q?ppHkiX/X0YReihKN1yXa9RZgdArOmgfn1LiLVYMteAfzceOjwB9y4LRno9xL?= =?us-ascii?Q?6Zkj2sVF+LG1wOd3b5KCGTbmHSERpOckb/rC6hsgF4SDLLFFBNmwyCBqIKJG?= =?us-ascii?Q?cJn7D8vSKoMpGWUCjbnMzQCH/ojRCKzDd00mspu+yVWi7GlSpmyYdRyJkUxL?= =?us-ascii?Q?raZA4cdRQdV5MOoUj0XAdKEnFi1ykkh3ly/pUXyz?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 77546580-8fe4-41c3-244c-08dd581bd039 X-MS-Exchange-CrossTenant-AuthSource: DS7PR12MB9473.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Feb 2025 17:17:43.8470 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: vYiCjungZuaEEGwyytZUFK/Bc+0Nn8FuSCQMfzCP4o5Mk/kELm42ZOppIAbA6WoY X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR12MB8170 X-Stat-Signature: 5m7gs8ukxsns8q9xm73mtx3bm4bk5da1 X-Rspamd-Queue-Id: 6BFB91C0007 X-Rspam-User: X-Rspamd-Server: rspam01 X-HE-Tag: 1740763067-204213 X-HE-Meta: U2FsdGVkX1+FT8O2VBa74bY0eZSp9dP5NDan2jTlJGGG3Jw/DiFd6pPBzp/kSkVTtU2TDtf5KnPjdmVkU3GNprPL/lSPfFOVhljYxyA+sPx19iXUtUXwvpHMARqvMso9O1nqGyjHJ/Ei48RrqSUR4uSgQVk4wKnJEKEb1Uo82S4bXL7uF8wthDm0n3XIDN6b33z68DPe2uk0EVWyqalQftX9c52EpYlQy74MzAhGF3Wi2lKnm+VcoidAnYMnP4oh9BgdEdqPvgqKj/hmdBxeGFkF5laSYvsnclSQHwur0GHYCxdS54QQDvwesF07BJUF0mKAEsR/OTF6vitwjYxJ3Q+S9kZfsblDlne6F1zJ+hFle9VvkaSxuB3G2RF+g4zeYUgAM8dcGV71slADF+5geiRZ2Y1PW8Keas3jw9sAMMhcAePu52n4XZp5tlvUOccaj93TjPvTsNHL1OAwittf73lvB4OY6IQ5phz8yDeVaNejvCUlJ3+j1uVbPBUC7LpvJwBC1YkQ/3EplpkxmaPggDoqzSVdUfc44H+4+o8AxMwOfPjHMJbJUFJYR7WIqi8NGamI2RNS3mm/L1HVTtgwVgTeVTvY8Sv+F/WpKHCeV8862mzs4lADeZ07s6zLhxCBcWI6I14eKVprNWMfBFB0GqhSNbrhsiYj/PRZ6mspu8hX0UGbUTpiq246Dpza/MSMG+ddo6GX1P96z2qtDrMDNirJTPsIA/JgssFX6tKYEPY2XLee1kosvtWVu9Zow4YLfoVSrFcMFZpevjZcDqUw/TnP/h297xUPTfCmg3JV3xFj0XJKXjIBhdKwhlBDA2aFFpIWvtDN7Iy4lr77nmvM4V9c0GiNulZ10EhfbtVfUF/4Y/yGxWl+JgMgJJhdwNlIM6bKEUgIA4GhIF9EUn8ROOya789BiNHGBNunJYfijMUc3+lgYww3GPBykul45ubUFBAZ+671QAvDYiIw8kJ LYWdH3zK bTP+KB8JkcDkHlzbbEdLS+8tscqakA/UhlPTXdJbac0D52Bb7iG+wUEenoM06ymiQoxWqh0/qIU6BsEDSwyimOynsIk5P2xx/eDxcDp4zjDkg7wbrsu/5FxwJkEHub9bxs61eGb/oG86J2KYWVy+rK52WHkqjHWDLXppjifC9QOMtg4oU9g//8kaqwvSA2IEC1TTAymMjrDSLBjqCTg6mSVWpF4/PHgvxxjJcBr54hPqYTmld8dOUL2/ZwXC1ByCOIZIidpgbcCVMCl6/5iP2XsqMaV1+RiBhdvs7m4uAiZfr6lLbHD9Gf7q8XoaWhucxrdNhAVdXEDhAfUhdTH4oit7D6Z+iFirvu+uvN7THlNjgRYOVl45X+3dVAPhWZjFN8RMc2xIAO8mBAzyG0ruXWjZS/oKqbeOAipdX0SSsTzTSfr7KG9QDeoGXwJNJvjnAOc9PENQ37eWGUOA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 28 Feb 2025, at 12:02, Shivank Garg wrote: > On 2/28/2025 9:12 PM, Zi Yan wrote: >> Pagecache uses multi-index entries for large folio, so does shmem. Onl= y >> swap cache still stores multiple entries for a single large folio. >> Commit fc346d0a70a1 ("mm: migrate high-order folios in swap cache corr= ectly") >> fixed swap cache but got shmem wrong by storing multiple entries for >> a large shmem folio. Fix it by storing a single entry for a shmem >> folio. >> >> Fixes: fc346d0a70a1 ("mm: migrate high-order folios in swap cache corr= ectly") >> Reported-by: Liu Shixin >> Closes: https://lore.kernel.org/all/28546fb4-5210-bf75-16d6-43e1f86460= 80@huawei.com/ >> Signed-off-by: Zi Yan >> --- >> mm/migrate.c | 7 ++++++- >> 1 file changed, 6 insertions(+), 1 deletion(-) >> >> diff --git a/mm/migrate.c b/mm/migrate.c >> index 365c6daa8d1b..9db26f5527a8 100644 >> --- a/mm/migrate.c >> +++ b/mm/migrate.c >> @@ -44,6 +44,7 @@ >> #include >> #include >> #include >> +#include >> >> #include >> >> @@ -524,7 +525,11 @@ static int __folio_migrate_mapping(struct address= _space *mapping, >> folio_set_swapcache(newfolio); >> newfolio->private =3D folio_get_private(folio); >> } >> - entries =3D nr; >> + /* shmem uses high-order entry */ >> + if (shmem_mapping(mapping)) >> + entries =3D 1; >> + else >> + entries =3D nr; > > LGTM functionally. > As a minor style suggestion, can we consider using a ternary operator: > > entries =3D shmem_mapping(mapping) ? 1 : nr; /* shmem uses high-order= entry */ > > This looks cleaner to me. > > Reviewed-by: Shivank Garg Thanks. Best Regards, Yan, Zi