From: Minchan Kim <minchan.kim@gmail.com>
To: David Rientjes <rientjes@google.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-mm <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>,
Wu Fengguang <fengguang.wu@intel.com>,
Peter Zijlstra <a.p.zijlstra@chello.nl>
Subject: Re: [PATCH] writeback: avoid unnecessary determine_dirtyable_memory call
Date: Tue, 4 Jan 2011 07:33:15 +0900 [thread overview]
Message-ID: <AANLkTinb+W-hByy18tko8NFtYYzQonABps0gi7+7kQ5R@mail.gmail.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1101031400550.10636@chino.kir.corp.google.com>
On Tue, Jan 4, 2011 at 7:03 AM, David Rientjes <rientjes@google.com> wrote:
> On Tue, 4 Jan 2011, Minchan Kim wrote:
>
>> diff --git a/mm/page-writeback.c b/mm/page-writeback.c
>> index fc93802..c340536 100644
>> --- a/mm/page-writeback.c
>> +++ b/mm/page-writeback.c
>> @@ -390,9 +390,12 @@ void global_dirty_limits(unsigned long *pbackground, unsigned long *pdirty)
>> {
>> unsigned long background;
>> unsigned long dirty;
>> - unsigned long available_memory = determine_dirtyable_memory();
>> + unsigned long available_memory;
>
> You need unsigned long uninitialized_var(available_memory) to avoid the
> warning.
Yes. It's my fault. Andrew already fixed it.
Thanks, David.
--
Kind regards,
Minchan Kim
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom policy in Canada: sign http://dissolvethecrtc.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2011-01-03 22:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-03 16:30 Minchan Kim
2011-01-03 22:03 ` David Rientjes
2011-01-03 22:33 ` Minchan Kim [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AANLkTinb+W-hByy18tko8NFtYYzQonABps0gi7+7kQ5R@mail.gmail.com \
--to=minchan.kim@gmail.com \
--cc=a.p.zijlstra@chello.nl \
--cc=akpm@linux-foundation.org \
--cc=fengguang.wu@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox