Re: [PATCH] memcg: clean up migration

[Minchan Kim <minchan.kim@gmail.com>]

On Mon, Feb 28, 2011 at 6:09 AM, Johannes Weiner <hannes@cmpxchg.org> wrote:
> On Mon, Feb 28, 2011 at 12:49:25AM +0900, Minchan Kim wrote:
>> This patch cleans up unncessary BUG_ON check and confusing
>> charge variable.
>>
>> That's because memcg charge/uncharge could be handled by
>> mem_cgroup_[prepare/end] migration itself so charge local variable
>> in unmap_and_move lost the role since we introduced 01b1ae63c2.
>>
>> And mem_cgroup_prepare_migratio return 0 if only it is successful.
>> Otherwise, it jumps to unlock label to clean up so BUG_ON(charge)
>> isn;t meaningless.
>>
>> Cc: Johannes Weiner <hannes@cmpxchg.org>
>> Cc: Balbir Singh <balbir@linux.vnet.ibm.com>
>> Cc: Daisuke Nishimura <nishimura@mxp.nes.nec.co.jp>
>> Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
>> Signed-off-by: Minchan Kim <minchan.kim@gmail.com>
>
> Reviewed-by: Johannes Weiner <hannes@cmpxchg.org>
>
> Thanks, Minchan!
>
>        Hannes
>
> PS: Btw, people sometimes refer to commits by hashes from trees other
> than Linus's, so it's nice to include the subject as well:
>
>        01b1ae6 memcg: simple migration handling
>
> You get this easily by taking the first line of
>
>        git show --oneline <commithash>
>
> though there are probably other ways.
>

I forgot adding the name with old comment's copy & paste. I will
resend with fixing some typo.

Thanks.


-- 
Kind regards,
Minchan Kim

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>