From: Minchan Kim <minchan.kim@gmail.com>
To: Ben Gamari <bgamari.foss@gmail.com>
Cc: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
Andrew Morton <akpm@linux-foundation.org>,
Rik van Riel <riel@redhat.com>, linux-mm <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>,
Wu Fengguang <fengguang.wu@intel.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Nick Piggin <npiggin@kernel.dk>
Subject: Re: [PATCH v4 4/7] Reclaim invalidated page ASAP
Date: Thu, 9 Dec 2010 08:10:17 +0900 [thread overview]
Message-ID: <AANLkTin642NFLMubtCQhSVUNLzfdk5ajz-RWe2zT+Lw6@mail.gmail.com> (raw)
In-Reply-To: <87oc8wa063.fsf@gmail.com>
On Wed, Dec 8, 2010 at 10:01 PM, Ben Gamari <bgamari.foss@gmail.com> wrote:
>> Make sense to me. If Ben is busy, I will measure it and send the result.
>
> I've done measurements on the patched kernel. All that remains is to do
> measurements on the baseline unpached case. To summarize the results
> thusfar,
>
> Times:
> =======
> user sys %cpu inputs outputs
> Patched, drop 142 64 46 13557744 14052744
> Patched, nodrop 55 57 33 13557936 13556680
>
> vmstat:
> ========
> free_pages inact_anon act_anon inact_file act_file dirtied written reclaim
> Patched, drop, pre 306043 37541 185463 276266 153955 3689674 3604959 1550641
> Patched, drop, post 13233 38462 175252 536346 178792 5527564 5371563 3169155
>
> Patched, nodrop, pre 475211 38602 175242 81979 178820 5527592 5371554 3169155
> Patched, nodrop, post 7697 38959 176986 547984 180855 7324836 7132158 3169155
>
> Altogether, it seems that something is horribly wrong, most likely with
> my test (or rsync patch). I'll do the baseline benchmarks today.
>
> Thoughts?
How do you test it?
I think patch's effect would be good in big memory pressure environment.
Quickly I did it on my desktop environment.(2G DRAM)
So it's not completed result. I will test more when out of office.
Used kernel : mmotm-12-02 + my patch series
Used rsync :
1. rsync_normal : v3.0.7 vanilla
2. rsync_patch : v3.0.7 + Ben's patch(fadvise)
Test scenario :
* kernel full compile
* git clone linux-kernel
* rsync local host directory to local host dst directory
1) rsync_normal : 89.08user 127.48system 33:22.24elapsed
2) rsync_patch : 88.42user 135.26system 31:30.56elapsed
1) rsync_normal vmstat :
pgfault : 45538203
pgmajfault : 4181
pgactivate 377416
pgdeactivate 34183
pginvalidate 0
pgreclaim 0
pgsteal_dma 0
pgsteal_normal 2144469
pgsteal_high 2884412
pgsteal_movable 0
pgscan_kswapd_dma 0
pgscan_kswapd_normal 2149739
pgscan_kswapd_high 2909140
pgscan_kswapd_movable 0
pgscan_direct_dma 0
pgscan_direct_normal 647
pgscan_direct_high 716
pgscan_direct_movable 0
pginodesteal 0
slabs_scanned 1737344
kswapd_steal 5028353
kswapd_inodesteal 438910
pageoutrun 81208
allocstall 9
pgrotated 1642
2) rsync_patch vmstat:
pgfault : 47570231
pgmajfault : 2669
pgactivate 391806
pgdeactivate 36861
pginvalidate 1685065
pgreclaim 1685065
pgrefill_dma 0
pgrefill_normal 32025
pgrefill_high 9619
pgrefill_movable 0
pgsteal_dma 0
pgsteal_normal 744904
pgsteal_high 1079709
pgsteal_movable 0
pgscan_kswapd_dma 0
pgscan_kswapd_normal 745017
pgscan_kswapd_high 1096660
pgscan_kswapd_movable 0
pgscan_direct_dma 0
pgscan_direct_normal 0
pgscan_direct_high 0
pgscan_direct_movable 0
pginodesteal 0
slabs_scanned 1896960
kswapd_steal 1824613
kswapd_inodesteal 703499
pageoutrun 26828
allocstall 0
pgrotated 1681570
In summary,
Unfortunately, the number of fault is increased (47570231 - 45538203)
but pgmajfault is reduced (4181 - 2669).
The number of scanning is much reduced. 2149739 -> 745017, 2909140 ->
1096660 and even no direct reclaim in patched rsync.
The number of steal is much reduced. 2144469 -> 744904, 2884412 ->
1079709, 5028353 -> 1824613.
The elapsed time is reduced 2 minutes.
I think result is good. Reduced the steal number could imply prevent
eviction of working set pages.
It has a good result with small effort(small scanning).
I will resend with more exact measurement after repeated test.
> Thanks,
>
> - Ben
>
>
--
Kind regards,
Minchan Kim
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom policy in Canada: sign http://dissolvethecrtc.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2010-12-08 23:10 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-05 17:29 [PATCH v4 0/7] f/madivse(DONTNEED) support Minchan Kim
2010-12-05 17:29 ` [PATCH v4 1/7] Fix checkpatch's report in swap.c Minchan Kim
2010-12-06 1:47 ` Rik van Riel
2010-12-07 14:37 ` Johannes Weiner
2010-12-05 17:29 ` [PATCH v4 2/7] deactivate invalidated pages Minchan Kim
2010-12-06 14:53 ` Mel Gorman
2010-12-07 14:49 ` Johannes Weiner
2010-12-07 15:07 ` Minchan Kim
2010-12-07 15:19 ` Johannes Weiner
2010-12-07 15:26 ` Minchan Kim
2010-12-07 15:56 ` Johannes Weiner
2010-12-07 22:51 ` Minchan Kim
2010-12-08 0:56 ` KAMEZAWA Hiroyuki
2010-12-08 1:43 ` Minchan Kim
2010-12-08 1:56 ` KAMEZAWA Hiroyuki
2010-12-08 2:15 ` Minchan Kim
2010-12-08 6:56 ` Balbir Singh
2010-12-09 0:19 ` Minchan Kim
2010-12-05 17:29 ` [PATCH v4 3/7] move memcg reclaimable page into tail of inactive list Minchan Kim
2010-12-06 0:04 ` KAMEZAWA Hiroyuki
2010-12-06 3:04 ` Rik van Riel
2010-12-07 0:17 ` Minchan Kim
2010-12-06 3:34 ` Balbir Singh
2010-12-07 0:20 ` Minchan Kim
2010-12-07 14:52 ` Johannes Weiner
2010-12-08 8:08 ` KOSAKI Motohiro
2010-12-05 17:29 ` [PATCH v4 4/7] Reclaim invalidated page ASAP Minchan Kim
2010-12-07 15:05 ` Johannes Weiner
2010-12-07 15:21 ` Minchan Kim
2010-12-08 8:04 ` KOSAKI Motohiro
2010-12-08 8:16 ` Minchan Kim
2010-12-08 13:01 ` Ben Gamari
2010-12-08 23:10 ` Minchan Kim [this message]
2010-12-13 15:31 ` Minchan Kim
2010-12-13 20:06 ` Ben Gamari
2010-12-14 2:36 ` Minchan Kim
2011-07-25 3:08 ` Ben Gamari
2011-07-25 3:47 ` Minchan Kim
2010-12-14 2:07 ` KAMEZAWA Hiroyuki
2010-12-14 2:34 ` Minchan Kim
2010-12-05 17:29 ` [PATCH v4 5/7] add profile information for invalidated page reclaim Minchan Kim
2010-12-06 3:24 ` Rik van Riel
2010-12-08 8:02 ` KOSAKI Motohiro
2010-12-08 8:13 ` Minchan Kim
2010-12-08 8:36 ` KOSAKI Motohiro
2010-12-05 17:29 ` [PATCH v4 6/7] Remove zap_details NULL dependency Minchan Kim
2010-12-06 3:25 ` Rik van Riel
2010-12-07 4:26 ` Hugh Dickins
2010-12-07 5:30 ` Minchan Kim
2010-12-05 17:29 ` [PATCH v4 7/7] Prevent activation of page in madvise_dontneed Minchan Kim
2010-12-07 4:48 ` Hugh Dickins
2010-12-07 5:44 ` Minchan Kim
2010-12-08 7:26 ` Hugh Dickins
2010-12-08 7:55 ` Minchan Kim
[not found] ` <AANLkTim71krrCcmhTTCZTzxeUDkvOdBTOkeYQu6EXt32@mail.gmail.com>
2010-12-07 1:52 ` [PATCH v4 0/7] f/madivse(DONTNEED) support Ben Gamari
2010-12-07 2:16 ` Minchan Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AANLkTin642NFLMubtCQhSVUNLzfdk5ajz-RWe2zT+Lw6@mail.gmail.com \
--to=minchan.kim@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=bgamari.foss@gmail.com \
--cc=fengguang.wu@intel.com \
--cc=hannes@cmpxchg.org \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=npiggin@kernel.dk \
--cc=riel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox