From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail203.messagelabs.com (mail203.messagelabs.com [216.82.254.243]) by kanga.kvack.org (Postfix) with ESMTP id C171F8D0039 for ; Mon, 7 Mar 2011 10:39:35 -0500 (EST) Received: by iyf13 with SMTP id 13so5379322iyf.14 for ; Mon, 07 Mar 2011 07:39:34 -0800 (PST) MIME-Version: 1.0 In-Reply-To: <1299350956-5614-1-git-send-email-cesarb@cesarb.net> References: <1299350956-5614-1-git-send-email-cesarb@cesarb.net> Date: Tue, 8 Mar 2011 00:39:34 +0900 Message-ID: Subject: Re: [PATCH] mm: remove inline from scan_swap_map From: Minchan Kim Content-Type: text/plain; charset=UTF-8 Sender: owner-linux-mm@kvack.org List-ID: To: Cesar Eduardo Barros Cc: linux-mm@kvack.org, Andrew Morton , Hugh Dickins , KAMEZAWA Hiroyuki , Jens Axboe , linux-kernel@vger.kernel.org On Sun, Mar 6, 2011 at 3:49 AM, Cesar Eduardo Barros wrote: > scan_swap_map is a large function (224 lines), with several loops and a > complex control flow involving several gotos. > > Given all that, it is a bit silly that is is marked as inline. The > compiler agrees with me: on a x86-64 compile, it did not inline the > function. > > Remove the "inline" and let the compiler decide instead. > > Signed-off-by: Cesar Eduardo Barros Reviewed-by: Minchan Kim -- Kind regards, Minchan Kim -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org