linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Minchan Kim <minchan.kim@gmail.com>
To: "Penttilä Mika" <mika.penttila@ixonos.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-mm@kvack.org" <linux-mm@kvack.org>
Subject: Re: [PATCH] Tight check of pfn_valid on sparsemem - v3
Date: Mon, 26 Jul 2010 07:26:27 +0900	[thread overview]
Message-ID: <AANLkTim9eEcfszuYz0RnPs4K3U_t4z7XdQjsNZpE+kkf@mail.gmail.com> (raw)
In-Reply-To: <1A61D8EA6755AF458F06EA669A4EC818013896@JKLMAIL02.ixonos.local>

2010/7/26 Penttilä Mika <mika.penttila@ixonos.com>:
> I don't think this works because if the memmap pages get reused, the corresponding struct page->private could be used by chance in such a way that it has the value of MEMMAP_HOLE. Of course unlikely but possible. And after all the whole point of freeing part of the memmap is that it could be reused.
>

You're absolutely right.
Previous version, I didn't do such as.
In this version, I wanted to remove dependency of page->private and
mem_section to identify hole memmap for using it in FLATMEM of ARM but
make mistake.
I will resend the patch

Thanks for careful review.

> --Mika
>
>
>
>



-- 
Kind regards,
Minchan Kim

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2010-07-25 22:26 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1A61D8EA6755AF458F06EA669A4EC81801387C@JKLMAIL02.ixonos.local>
2010-07-25 20:22 ` Penttilä Mika
2010-07-25 22:26   ` Minchan Kim [this message]
2010-07-25 14:02 Minchan Kim
2010-07-25 17:03 ` Balbir Singh
2010-07-25 22:22   ` Minchan Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=AANLkTim9eEcfszuYz0RnPs4K3U_t4z7XdQjsNZpE+kkf@mail.gmail.com \
    --to=minchan.kim@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mika.penttila@ixonos.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox