From: Maxin John <maxin.john@gmail.com>
To: Catalin Marinas <catalin.marinas@arm.com>
Cc: Daniel Baluta <dbaluta@ixiacom.com>,
naveen yadav <yad.naveen@gmail.com>,
linux-mips@linux-mips.org, linux-kernel@vger.kernel.org,
linux-mm@kvack.org
Subject: Re: kmemleak for MIPS
Date: Wed, 30 Mar 2011 11:08:48 +0100 [thread overview]
Message-ID: <AANLkTim9+kQYSKXRbkOPArJ63jTxvjkFg=AEywr5meNN@mail.gmail.com> (raw)
In-Reply-To: <1301476505.29074.47.camel@e102109-lin.cambridge.arm.com>
Hi,
> If you for the kmemleak scan (via echo) a few times, do you get more
> leaks?
Yes. I am getting some leaks after the scan.
> The udp_table_init() function looks like it could leak some
> memory but I haven't seen it before. I'm not sure whether this is a
> false positive or a real leak.
As Daniel suggested, this could be a real leak . However, we need to
confirm this.
udp_table_init() -> alloc_large_system_hash() -> alloc_pages_exact()
followed by kmemleak_alloc()
> I think the last line should be more like:
As per your suggestion, I have modified the patch.
Signed-off-by: Maxin B. John <maxin.john@gmail.com>
Acked-by: Catalin Marinas <catalin.marinas@arm.com>
---
diff --git a/arch/mips/include/asm/cache.h b/arch/mips/include/asm/cache.h
index 650ac9b..b4db69f 100644
--- a/arch/mips/include/asm/cache.h
+++ b/arch/mips/include/asm/cache.h
@@ -17,6 +17,6 @@
#define SMP_CACHE_SHIFT L1_CACHE_SHIFT
#define SMP_CACHE_BYTES L1_CACHE_BYTES
-#define __read_mostly __attribute__((__section__(".data.read_mostly")))
+#define __read_mostly __attribute__((__section__(".data..read_mostly")))
#endif /* _ASM_CACHE_H */
diff --git a/arch/mips/kernel/vmlinux.lds.S b/arch/mips/kernel/vmlinux.lds.S
index 832afbb..4f10141 100644
--- a/arch/mips/kernel/vmlinux.lds.S
+++ b/arch/mips/kernel/vmlinux.lds.S
@@ -68,12 +68,14 @@ SECTIONS
RODATA
/* writeable */
+ _sdata = .; /* Start of data section */
.data : { /* Data */
. = . + DATAOFFSET; /* for CONFIG_MAPPED_KERNEL */
INIT_TASK_DATA(PAGE_SIZE)
NOSAVE_DATA
CACHELINE_ALIGNED_DATA(1 << CONFIG_MIPS_L1_CACHE_SHIFT)
+ READ_MOSTLY_DATA(1 << CONFIG_MIPS_L1_CACHE_SHIFT)
DATA_DATA
CONSTRUCTORS
}
diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
index df9234c..5042421 100644
--- a/lib/Kconfig.debug
+++ b/lib/Kconfig.debug
@@ -398,7 +398,7 @@ config SLUB_STATS
config DEBUG_KMEMLEAK
bool "Kernel memory leak detector"
depends on DEBUG_KERNEL && EXPERIMENTAL && !MEMORY_HOTPLUG && \
- (X86 || ARM || PPC || S390 || SPARC64 || SUPERH ||
MICROBLAZE || TILE)
+ (X86 || ARM || PPC || MIPS || S390 || SPARC64 ||
SUPERH || MICROBLAZE || TILE)
select DEBUG_FS if SYSFS
select STACKTRACE if STACKTRACE_SUPPORT
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2011-03-30 10:08 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-02 13:54 naveen yadav
2011-03-24 9:27 ` Daniel Baluta
2011-03-24 9:55 ` Catalin Marinas
2011-03-28 21:15 ` Maxin John
2011-03-29 10:40 ` Catalin Marinas
2011-03-29 11:38 ` Maxin John
2011-03-29 11:50 ` Catalin Marinas
2011-03-29 12:27 ` Maxin John
2011-03-29 19:36 ` Maxin John
2011-03-29 19:54 ` Daniel Baluta
2011-03-30 9:15 ` Catalin Marinas
2011-03-30 9:54 ` Daniel Baluta
2011-03-30 9:58 ` Catalin Marinas
2011-03-30 11:03 ` Maxin John
2011-03-30 11:24 ` Daniel Baluta
2011-03-30 11:38 ` Catalin Marinas
2011-03-30 12:17 ` Maxin John
2011-03-30 12:27 ` Eric Dumazet
2011-03-30 12:40 ` Maxin John
2011-03-30 12:52 ` Daniel Baluta
2011-03-30 13:17 ` Maxin John
2011-03-30 13:27 ` Eric Dumazet
2011-03-30 14:07 ` Maxin John
2011-03-30 14:07 ` Catalin Marinas
2011-03-30 12:22 ` Eric Dumazet
2011-03-30 10:08 ` Maxin John [this message]
2011-03-30 14:28 ` Ralf Baechle
2011-03-30 14:21 ` Ralf Baechle
-- strict thread matches above, loose matches on Subject: below --
2009-11-02 17:07 Kmemleak for mips Luis R. Rodriguez
2009-11-03 9:23 ` Catalin Marinas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='AANLkTim9+kQYSKXRbkOPArJ63jTxvjkFg=AEywr5meNN@mail.gmail.com' \
--to=maxin.john@gmail.com \
--cc=catalin.marinas@arm.com \
--cc=dbaluta@ixiacom.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=linux-mm@kvack.org \
--cc=yad.naveen@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox