From: Minchan Kim <minchan.kim@gmail.com>
To: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Cc: "linux-mm@kvack.org" <linux-mm@kvack.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
andi.kleen@intel.com, KOSAKI Motohiro <kosaki.motohiro@gmail.com>,
fujita.tomonori@lab.ntt.co.jp, felipe.contreras@gmail.com,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
Jonathan Corbet <corbet@lwn.net>,
Michal Nazarewicz <m.nazarewicz@samsung.com>,
Russell King <linux@arm.linux.org.uk>,
Pawel Osciak <p.osciak@samsung.com>,
Peter Zijlstra <peterz@infradead.org>
Subject: Re: [RFC][PATCH 0/3] big chunk memory allocator v2
Date: Thu, 28 Oct 2010 08:22:38 +0900 [thread overview]
Message-ID: <AANLkTim4fFXQKqmFCeR8pvi0SZPXpjDqyOkbV6PYJYkR@mail.gmail.com> (raw)
In-Reply-To: <20101026190042.57f30338.kamezawa.hiroyu@jp.fujitsu.com>
On Tue, Oct 26, 2010 at 7:00 PM, KAMEZAWA Hiroyuki
<kamezawa.hiroyu@jp.fujitsu.com> wrote:
> Hi, here is version 2.
>
> I only did small test and it seems to work (but I think there will be bug...)
> I post this now just because I'll be out of office 10/31-11/15 with ksummit and
> a private trip.
>
> Any comments are welcome but please see the interface is enough for use cases or
> not. For example) If MAX_ORDER alignment is too bad, I need to rewrite almost
> all code.
First of all, thanks for the endless your effort to embedded system.
It's time for statkeholders to review this.
Cced some guys. Maybe many people of them have to attend KS.
So I hope SAMSUNG guys review this.
Maybe they can't test this since ARM doesn't support movable zone now.
(I will look into this).
As Kame said, please, review this patch whether this patch have enough
interface and meet
your requirement.
I think this can't meet _all_ of your requirements(ex, latency and
making sure getting big contiguous memory) but I believe it can meet
NOT CRITICAL many cases, I guess.
>
> Now interface is:
>
>
> struct page *__alloc_contig_pages(unsigned long base, unsigned long end,
> unsigned long nr_pages, int align_order,
> int node, gfp_t gfpflag, nodemask_t *mask)
>
> * @base: the lowest pfn which caller wants.
> * @end: the highest pfn which caller wants.
> * @nr_pages: the length of a chunk of pages to be allocated.
> * @align_order: alignment of start address of returned chunk in order.
> * Returned' page's order will be aligned to (1 << align_order).If smaller
> * than MAX_ORDER, it's raised to MAX_ORDER.
> * @node: allocate near memory to the node, If -1, current node is used
next prev parent reply other threads:[~2010-10-27 23:22 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-26 10:00 KAMEZAWA Hiroyuki
2010-10-26 10:02 ` [RFC][PATCH 1/3] move code from memory_hotplug to page_isolation KAMEZAWA Hiroyuki
2010-10-26 10:04 ` [RFC][PATCH 2/3] a help function for find physically contiguous block KAMEZAWA Hiroyuki
2010-10-29 3:53 ` Bob Liu
2010-10-29 4:00 ` KAMEZAWA Hiroyuki
2010-10-26 10:08 ` [RFC][PATCH 3/3] a big contig memory allocator KAMEZAWA Hiroyuki
2010-10-29 3:55 ` Bob Liu
2010-10-29 4:02 ` KAMEZAWA Hiroyuki
2010-10-27 23:22 ` Minchan Kim [this message]
2010-10-29 9:20 ` [RFC][PATCH 0/3] big chunk memory allocator v2 Michał Nazarewicz
2010-10-29 10:31 ` Andi Kleen
2010-10-29 10:59 ` KAMEZAWA Hiroyuki
2010-10-29 12:29 ` Andi Kleen
2010-10-29 12:31 ` KAMEZAWA Hiroyuki
2010-10-29 12:43 ` Michał Nazarewicz
2010-10-29 14:27 ` Andi Kleen
2010-10-29 14:58 ` Michał Nazarewicz
2010-10-29 13:11 ` Minchan Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AANLkTim4fFXQKqmFCeR8pvi0SZPXpjDqyOkbV6PYJYkR@mail.gmail.com \
--to=minchan.kim@gmail.com \
--cc=andi.kleen@intel.com \
--cc=corbet@lwn.net \
--cc=felipe.contreras@gmail.com \
--cc=fujita.tomonori@lab.ntt.co.jp \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=kosaki.motohiro@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux@arm.linux.org.uk \
--cc=m.nazarewicz@samsung.com \
--cc=p.osciak@samsung.com \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox