Re: [RFC] oom-kill: give the dying task a higher priority

[Minchan Kim <minchan.kim@gmail.com>]

On Mon, May 31, 2010 at 2:04 PM, KAMEZAWA Hiroyuki
<kamezawa.hiroyu@jp.fujitsu.com> wrote:
> On Mon, 31 May 2010 14:01:03 +0900
> Minchan Kim <minchan.kim@gmail.com> wrote:
>
>> Hi, Kame.
>>
>> On Mon, May 31, 2010 at 9:21 AM, KAMEZAWA Hiroyuki
>> <kamezawa.hiroyu@jp.fujitsu.com> wrote:
>> > On Fri, 28 May 2010 13:48:26 -0300
>> > "Luis Claudio R. Goncalves" <lclaudio@uudg.org> wrote:
>> >>
>> >> oom-killer: give the dying task rt priority (v3)
>> >>
>> >> Give the dying task RT priority so that it can be scheduled quickly and die,
>> >> freeing needed memory.
>> >>
>> >> Signed-off-by: Luis Claudio R. Gonçalves <lgoncalv@redhat.com>
>> >>
>> >> diff --git a/mm/oom_kill.c b/mm/oom_kill.c
>> >> index 84bbba2..2b0204f 100644
>> >> --- a/mm/oom_kill.c
>> >> +++ b/mm/oom_kill.c
>> >> @@ -266,6 +266,8 @@ static struct task_struct *select_bad_process(unsigned long *ppoints)
>> >>   */
>> >>  static void __oom_kill_task(struct task_struct *p, int verbose)
>> >>  {
>> >> +     struct sched_param param;
>> >> +
>> >>       if (is_global_init(p)) {
>> >>               WARN_ON(1);
>> >>               printk(KERN_WARNING "tried to kill init!\n");
>> >> @@ -288,6 +290,8 @@ static void __oom_kill_task(struct task_struct *p, int verbose)
>> >>        * exit() and clear out its resources quickly...
>> >>        */
>> >>       p->time_slice = HZ;
>> >> +     param.sched_priority = MAX_RT_PRIO-10;
>> >> +     sched_setscheduler(p, SCHED_FIFO, &param);
>> >>       set_tsk_thread_flag(p, TIF_MEMDIE);
>> >>
>> >
>> > BTW, how about the other threads which share mm_struct ?
>>
>> Could you elaborate your intention? :)
>>
>
> IIUC, the purpose of rising priority is to accerate dying thread to exit()
> for freeing memory AFAP. But to free memory, exit, all threads which share
> mm_struct should exit, too. I'm sorry if I miss something.

How do we kill only some thread and what's the benefit of it?
I think when if some thread receives  KILL signal, the process include
the thread will be killed.

I think
> Thanks,
> -Kame
>
>
>
>



-- 
Kind regards,
Minchan Kim

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>