From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail172.messagelabs.com (mail172.messagelabs.com [216.82.254.3]) by kanga.kvack.org (Postfix) with SMTP id 027886B01F2 for ; Sat, 15 May 2010 10:31:22 -0400 (EDT) Received: by fxm20 with SMTP id 20so1697071fxm.14 for ; Sat, 15 May 2010 07:31:21 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: References: <1273869997-12720-1-git-send-email-gthelen@google.com> Date: Sat, 15 May 2010 23:31:16 +0900 Message-ID: Subject: Re: [PATCH] mm: Consider the entire user address space during node migration From: KOSAKI Motohiro Content-Type: text/plain; charset=ISO-8859-1 Sender: owner-linux-mm@kvack.org To: Christoph Lameter Cc: Greg Thelen , Andrew Morton , Lee Schermerhorn , Mel Gorman , kamezawa.hiroyu@jp.fujitsu.com, nishimura@mxp.nes.nec.co.jp, balbir@linux.vnet.ibm.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org List-ID: Hi Mysteriously, I haven't receive original post. So now I'm guessing you acked following patch. http://lkml.org/lkml/2010/5/14/393 but I don't think it is correct. > - check_range(mm, mm->mmap->vm_start, TASK_SIZE, &nmask, > + check_range(mm, mm->mmap->vm_start, TASK_SIZE_MAX, &nmask, > flags | MPOL_MF_DISCONTIG_OK, &pagelist); Because TASK_SIZE_MAX is defined on x86 only. Why can we ignore other platform? Please put following line anywhere. #define TASK_SIZE_MAX TASK_SIZE But this patch is conceptually good. if it fixes the bug. I'll ack gladly. Thanks. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org