From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail144.messagelabs.com (mail144.messagelabs.com [216.82.254.51]) by kanga.kvack.org (Postfix) with SMTP id E0DB86B01B8 for ; Fri, 11 Jun 2010 04:08:11 -0400 (EDT) Received: by bwz18 with SMTP id 18so91009bwz.14 for ; Fri, 11 Jun 2010 01:08:08 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <1276168866.24535.25.camel@e102109-lin.cambridge.arm.com> References: <1275929000.3021.56.camel@e102109-lin.cambridge.arm.com> <20100609211617.3e7e41bd@annuminas.surriel.com> <1276168866.24535.25.camel@e102109-lin.cambridge.arm.com> Date: Fri, 11 Jun 2010 16:08:08 +0800 Message-ID: Subject: Re: [PATCH -mm] only drop root anon_vma if not self From: Dave Young Content-Type: text/plain; charset=UTF-8 Sender: owner-linux-mm@kvack.org To: Catalin Marinas Cc: Rik van Riel , Andrew Morton , Linux Kernel Mailing List , linux-mm@kvack.org List-ID: On Thu, Jun 10, 2010 at 7:21 PM, Catalin Marinas wrote: > Dave, > > On Thu, 2010-06-10 at 02:30 +0100, Dave Young wrote: >> On Thu, Jun 10, 2010 at 9:16 AM, Rik van Riel wrote: >> > On Wed, 9 Jun 2010 17:19:02 +0800 >> > Dave Young wrote: >> > >> >> > Manually bisected mm patches, the memleak caused by following patch: >> >> > >> >> > mm-extend-ksm-refcounts-to-the-anon_vma-root.patch >> >> >> >> >> >> So I guess the refcount break, either drop-without-get or over-drop >> > >> > I'm guessing I did not run the kernel with enough debug options enabled >> > when I tested my patches... >> > >> > Dave & Catalin, thank you for tracking this down. >> > >> > Dave, does the below patch fix your issue? >> >> Yes, it fixed the issue. Thanks. > > Thanks for investigating this issue. > > BTW, without my kmemleak nobootmem patch (and CONFIG_NOBOOTMEM enabled), > do you get other leaks (false positives). Hi, catalin I didn't see difference before/after apply your patch, how to test specific to bootmem? > If my patch fixes the > nobootmem problem, can I add a Tested-by: Dave Young? > > Thanks. > > -- > Catalin > > -- Regards dave -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org