linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Dave Young <hidave.darkstar@gmail.com>
To: Catalin Marinas <catalin.marinas@arm.com>
Cc: Rik van Riel <riel@redhat.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	linux-mm@kvack.org
Subject: Re: [PATCH -mm] only drop root anon_vma if not self
Date: Fri, 11 Jun 2010 16:08:08 +0800	[thread overview]
Message-ID: <AANLkTikl2Lp6dhDIN2NpyZHJne_vhOYJrwwBGebkslCf@mail.gmail.com> (raw)
In-Reply-To: <1276168866.24535.25.camel@e102109-lin.cambridge.arm.com>

On Thu, Jun 10, 2010 at 7:21 PM, Catalin Marinas
<catalin.marinas@arm.com> wrote:
> Dave,
>
> On Thu, 2010-06-10 at 02:30 +0100, Dave Young wrote:
>> On Thu, Jun 10, 2010 at 9:16 AM, Rik van Riel <riel@redhat.com> wrote:
>> > On Wed, 9 Jun 2010 17:19:02 +0800
>> > Dave Young <hidave.darkstar@gmail.com> wrote:
>> >
>> >> > Manually bisected mm patches, the memleak caused by following patch:
>> >> >
>> >> > mm-extend-ksm-refcounts-to-the-anon_vma-root.patch
>> >>
>> >>
>> >> So I guess the refcount break, either drop-without-get or over-drop
>> >
>> > I'm guessing I did not run the kernel with enough debug options enabled
>> > when I tested my patches...
>> >
>> > Dave & Catalin, thank you for tracking this down.
>> >
>> > Dave, does the below patch fix your issue?
>>
>> Yes, it fixed the issue. Thanks.
>
> Thanks for investigating this issue.
>
> BTW, without my kmemleak nobootmem patch (and CONFIG_NOBOOTMEM enabled),
> do you get other leaks (false positives).

Hi, catalin

I didn't see difference before/after apply your patch, how to test
specific to bootmem?

> If my patch fixes the
> nobootmem problem, can I add a Tested-by: Dave Young?
>
> Thanks.
>
> --
> Catalin
>
>



-- 
Regards
dave

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2010-06-11  8:08 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-04  8:27 mmotm 2010-06-03-16-36 lots of suspected kmemleak Dave Young
2010-06-04 10:50 ` Catalin Marinas
2010-06-04 13:55   ` Dave Young
2010-06-07  5:20     ` Dave Young
2010-06-07  9:19       ` Catalin Marinas
2010-06-07 10:00         ` Dave Young
2010-06-07 16:43           ` Catalin Marinas
2010-06-08  1:37             ` Dave Young
2010-06-09  2:37             ` Dave Young
2010-06-09  2:44               ` Dave Young
2010-06-09  9:19               ` Dave Young
2010-06-10  1:16                 ` [PATCH -mm] only drop root anon_vma if not self Rik van Riel
2010-06-10  1:30                   ` Dave Young
2010-06-10 11:21                     ` Catalin Marinas
2010-06-11  8:08                       ` Dave Young [this message]
2010-06-11  9:17                         ` Catalin Marinas
2010-06-11  9:30                           ` Dave Young
2010-06-11  9:48                             ` Dave Young
2010-06-11 10:06                               ` Catalin Marinas
2010-06-12  1:50                                 ` Dave Young
2010-06-07  8:30 ` mmotm 2010-06-03-16-36 lots of suspected kmemleak Dave Young

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=AANLkTikl2Lp6dhDIN2NpyZHJne_vhOYJrwwBGebkslCf@mail.gmail.com \
    --to=hidave.darkstar@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=catalin.marinas@arm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=riel@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox