From: Minchan Kim <minchan.kim@gmail.com>
To: Daisuke Nishimura <nishimura@mxp.nes.nec.co.jp>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Balbir Singh <balbir@linux.vnet.ibm.com>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
LKML <linux-kernel@vger.kernel.org>,
linux-mm <linux-mm@kvack.org>
Subject: Re: [BUGFIX][PATCH] memcg: fix memory migration of shmem swapcache
Date: Wed, 5 Jan 2011 16:18:27 +0900 [thread overview]
Message-ID: <AANLkTikdkmf7+8S2wWqnaJnQZ7DizY4MFVVZAQtrxx0q@mail.gmail.com> (raw)
In-Reply-To: <20110105154748.0a012407.nishimura@mxp.nes.nec.co.jp>
On Wed, Jan 5, 2011 at 3:47 PM, Daisuke Nishimura
<nishimura@mxp.nes.nec.co.jp> wrote:
> On Wed, 5 Jan 2011 13:48:50 +0900
> Minchan Kim <minchan.kim@gmail.com> wrote:
>
>> Hi,
>>
>> On Wed, Jan 5, 2011 at 1:00 PM, Daisuke Nishimura
>> <nishimura@mxp.nes.nec.co.jp> wrote:
>> > Hi.
>> >
>> > This is a fix for a problem which has bothered me for a month.
>> >
>> > ===
>> > From: Daisuke Nishimura <nishimura@mxp.nes.nec.co.jp>
>> >
>> > In current implimentation, mem_cgroup_end_migration() decides whether the page
>> > migration has succeeded or not by checking "oldpage->mapping".
>> >
>> > But if we are tring to migrate a shmem swapcache, the page->mapping of it is
>> > NULL from the begining, so the check would be invalid.
>> > As a result, mem_cgroup_end_migration() assumes the migration has succeeded
>> > even if it's not, so "newpage" would be freed while it's not uncharged
next prev parent reply other threads:[~2011-01-05 7:18 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-05 4:00 Daisuke Nishimura
2011-01-05 4:48 ` Minchan Kim
2011-01-05 6:47 ` Daisuke Nishimura
2011-01-05 7:18 ` Minchan Kim [this message]
2011-01-06 0:52 ` KAMEZAWA Hiroyuki
2011-01-06 2:51 ` Minchan Kim
2011-01-05 11:58 ` Johannes Weiner
2011-01-06 1:09 ` Daisuke Nishimura
2011-01-06 1:55 ` KAMEZAWA Hiroyuki
2011-01-06 2:49 ` Minchan Kim
2011-01-06 3:34 ` [BUGFIX][PATCH v3] " Daisuke Nishimura
2011-01-06 5:42 ` Balbir Singh
2011-01-06 6:29 ` [BUGFIX][PATCH v4] " Daisuke Nishimura
2011-01-08 9:26 ` Johannes Weiner
2011-01-10 9:05 ` Balbir Singh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AANLkTikdkmf7+8S2wWqnaJnQZ7DizY4MFVVZAQtrxx0q@mail.gmail.com \
--to=minchan.kim@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=balbir@linux.vnet.ibm.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=nishimura@mxp.nes.nec.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox