From: Balbir Singh <balbir@linux.vnet.ibm.com>
To: Greg Thelen <gthelen@google.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
David Rientjes <rientjes@google.com>,
KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
Minchan Kim <minchan.kim@gmail.com>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] oom: handle overflow in mem_cgroup_out_of_memory()
Date: Wed, 26 Jan 2011 19:10:34 +0530 [thread overview]
Message-ID: <AANLkTikZwbmVr-jvOoyd0WZhfxtHvqK=n1B-zWLr3xDa@mail.gmail.com> (raw)
In-Reply-To: <1296030555-3594-1-git-send-email-gthelen@google.com>
On Wed, Jan 26, 2011 at 1:59 PM, Greg Thelen <gthelen@google.com> wrote:
> mem_cgroup_get_limit() returns a byte limit as a unsigned 64 bit value,
> which is converted to a page count by mem_cgroup_out_of_memory(). Prior
> to this patch the conversion could overflow on 32 bit platforms
> yielding a limit of zero.
>
Why would the overflow occur? Due to the right shift being used with
unsigned long long? I am afraid I don't have quick access to a 32 bit
box to test the patch. May be I too drained to understand the problem,
can you post the corresponding assembly for analysis?
Balbir
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom policy in Canada: sign http://dissolvethecrtc.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2011-01-26 13:40 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-26 8:29 Greg Thelen
2011-01-26 13:40 ` Balbir Singh [this message]
2011-01-26 17:07 ` Johannes Weiner
2011-01-26 17:33 ` Greg Thelen
2011-01-26 18:30 ` Johannes Weiner
2011-01-26 20:32 ` Greg Thelen
2011-01-26 22:29 ` Andrew Morton
2011-01-27 0:24 ` KAMEZAWA Hiroyuki
2011-01-27 0:53 ` [BUGFIX] memcg: fix res_counter_read_u64 lock aware (Was " KAMEZAWA Hiroyuki
2011-01-27 1:08 ` Andrew Morton
2011-01-27 1:24 ` KAMEZAWA Hiroyuki
2011-01-27 1:34 ` KAMEZAWA Hiroyuki
2011-01-27 1:55 ` Andrew Morton
2011-01-27 1:43 ` [BUGFIX v2] " KAMEZAWA Hiroyuki
2011-01-27 1:57 ` Andrew Morton
2011-01-27 2:13 ` KAMEZAWA Hiroyuki
2011-01-27 0:40 ` KAMEZAWA Hiroyuki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='AANLkTikZwbmVr-jvOoyd0WZhfxtHvqK=n1B-zWLr3xDa@mail.gmail.com' \
--to=balbir@linux.vnet.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=gthelen@google.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=minchan.kim@gmail.com \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox