From: Minchan Kim <minchan.kim@gmail.com>
To: Rik van Riel <riel@redhat.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Ying Han <yinghan@google.com>, linux-mm <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>,
KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
Johannes Weiner <hannes@cmpxchg.org>
Subject: Re: [PATCH v2] vmscan: prevent background aging of anon page in no swap system
Date: Fri, 3 Sep 2010 00:34:03 +0900 [thread overview]
Message-ID: <AANLkTikWok_3ANHuxVs=muTVKi3AbcQTphxAfBT613u2@mail.gmail.com> (raw)
In-Reply-To: <4C7FBFE6.7060600@redhat.com>
Will fix.
Thanks for the quick response. Rik.
On Fri, Sep 3, 2010 at 12:16 AM, Rik van Riel <riel@redhat.com> wrote:
> On 09/02/2010 11:12 AM, Minchan Kim wrote:
>
>> + /*
>> + * If we don't have enough swap space, anonymous page deactivation
>> + * is pointless.
>> + */
>> + if (!nr_swap_pages)
>> + return 0;
>
> It may be better to test !total_swap_pages and change the
> comment to:
>
> /*
> * If we don't have swap space, anonymous page deactivation
> * is pointless.
> */
>
> --
> All rights reversed
>
--
Kind regards,
Minchan Kim
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2010-09-02 15:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-02 15:12 Minchan Kim
2010-09-02 15:16 ` Rik van Riel
2010-09-02 15:34 ` Minchan Kim [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='AANLkTikWok_3ANHuxVs=muTVKi3AbcQTphxAfBT613u2@mail.gmail.com' \
--to=minchan.kim@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=riel@redhat.com \
--cc=yinghan@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox